All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: "Maciej Żenczykowski" <maze@google.com>
Cc: Greg Kroah-Hartman <gregkh@google.com>,
	Sasha Levin <sashalevin@google.com>,
	stable@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: 4.9 LTS inclusion request for "net: fix nla_strcmp to handle more then one trailing null character"
Date: Fri, 10 Jun 2022 09:01:38 -0400	[thread overview]
Message-ID: <YqNAspwWkbEDXpji@sashalap> (raw)
In-Reply-To: <CANP3RGezxyXRmX3_cuXksjjcNkzbi+EOe7biMQRAdroV9DMhkA@mail.gmail.com>

On Fri, Jun 10, 2022 at 05:50:55AM -0700, Maciej Żenczykowski wrote:
>Please pull into 4.9 LTS:
>
>https://gitlab.arm.com/linux-arm/linux-power/-/commit/2c16db6c92b0ee4aa61e88366df82169e83c3f7e
>"net: fix nla_strcmp to handle more then one trailing null character"
>
>+++ lib/nlattr.c
>@@ -379,7 +379,7 @@ int nla_strcmp(const struct nlattr *nla, const char *str)
>-       if (attrlen > 0 && buf[attrlen - 1] == '\0')
>+       while (attrlen > 0 && buf[attrlen - 1] == '\0')
>
>which appears to be present in 4.14.233 (and presumably newer LTS),
>but not in 4.9:
>
>$ git log --oneline -n1
>remotes/linux-stable/v4.14.233..143722a05028ebb8691d349007f85656a4e90a8e
>
>We've got some code that is confirmed failing due to the lack of this one-liner,
>and the fix is obvious enough...

Queued up, thanks!

>(assuming it applies it presumably wouldn't hurt in 4.4 LTS either,
>but I think that tree isn't even maintained, and I don't care about it
>there)

No, no one cares :)

-- 
Thanks,
Sasha

      reply	other threads:[~2022-06-10 13:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-10 12:50 4.9 LTS inclusion request for "net: fix nla_strcmp to handle more then one trailing null character" Maciej Żenczykowski
2022-06-10 13:01 ` Sasha Levin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YqNAspwWkbEDXpji@sashalap \
    --to=sashal@kernel.org \
    --cc=gregkh@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=maze@google.com \
    --cc=sashalevin@google.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.