From: Greg KH <gregkh@linuxfoundation.org>
To: Tokunori Ikegami <ikegami.t@gmail.com>
Cc: stable@vger.kernel.org, Vignesh Raghavendra <vigneshr@ti.com>,
Miquel Raynal <miquel.raynal@bootlin.com>
Subject: Re: [PATCH for 4.9.y 2/2] mtd: cfi_cmdset_0002: Use chip_ready() for write on S29GL064N
Date: Mon, 13 Jun 2022 11:21:42 +0200 [thread overview]
Message-ID: <YqcBphMj/XeAaDEC@kroah.com> (raw)
In-Reply-To: <20220610155604.1342511-2-ikegami.t@gmail.com>
On Sat, Jun 11, 2022 at 12:56:04AM +0900, Tokunori Ikegami wrote:
> Since commit dfeae1073583("mtd: cfi_cmdset_0002: Change write buffer to
> check correct value") buffered writes fail on S29GL064N. This is
> because, on S29GL064N, reads return 0xFF at the end of DQ polling for
> write completion, where as, chip_good() check expects actual data
> written to the last location to be returned post DQ polling completion.
> Fix is to revert to using chip_good() for S29GL064N which only checks
> for DQ lines to settle down to determine write completion.
>
> Link: https://lore.kernel.org/r/b687c259-6413-26c9-d4c9-b3afa69ea124@pengutronix.de/
> Fixes: dfeae1073583("mtd: cfi_cmdset_0002: Change write buffer to check correct value")
> Cc: stable@vger.kernel.org
> Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
> Acked-by: Vignesh Raghavendra <vigneshr@ti.com>
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> Link: https://lore.kernel.org/linux-mtd/20220323170458.5608-3-ikegami.t@gmail.com
> ---
> drivers/mtd/chips/cfi_cmdset_0002.c | 42 +++++++++++++++++++++++------
> include/linux/mtd/cfi.h | 1 +
> 2 files changed, 35 insertions(+), 8 deletions(-)
All now queued up, thanks.
greg k-h
prev parent reply other threads:[~2022-06-13 9:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-10 15:56 [PATCH for 4.9.y 1/2] mtd: cfi_cmdset_0002: Move and rename chip_check/chip_ready/chip_good_for_write Tokunori Ikegami
2022-06-10 15:56 ` [PATCH for 4.9.y 2/2] mtd: cfi_cmdset_0002: Use chip_ready() for write on S29GL064N Tokunori Ikegami
2022-06-13 9:21 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YqcBphMj/XeAaDEC@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=ikegami.t@gmail.com \
--cc=miquel.raynal@bootlin.com \
--cc=stable@vger.kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.