From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Yury Norov <yury.norov@gmail.com>
Cc: wang.yi59@zte.com.cn, Andrew Morton <akpm@linux-foundation.org>,
linux-mm <linux-mm@kvack.org>,
linux@rasmusvillemoes.dk, linux-kernel@vger.kernel.org,
xue.zhihong@zte.com.cn, wang.liang82@zte.com.cn,
Liu.Jianjun3@zte.com.cn
Subject: Re: [PATCH] bitmap: fix a unproper remap when mpol_rebind_nodemask()
Date: Tue, 14 Jun 2022 19:50:28 +0300 [thread overview]
Message-ID: <Yqi8VH39+1L72hw1@smile.fi.intel.com> (raw)
In-Reply-To: <CAAH8bW_GCviYSadmf5CUxgJixkXbq+SfL63ZJt7Lsm9OAmPjVQ@mail.gmail.com>
On Tue, Jun 14, 2022 at 09:40:08AM -0700, Yury Norov wrote:
> On Mon, Jun 13, 2022 at 8:45 PM <wang.yi59@zte.com.cn> wrote:
> > > On Mon, Jun 13, 2022 at 4:31 AM Yi Wang <wang.yi59@zte.com.cn> wrote:
...
> > > Anyways, as per name, bitmap_remap() is intended to change bit
> > > positions, and it doesn't look wrong if it does so.
Haven't read the discussion in full, but saw the function here and my 2 cents
are the following:
1) if we don't have tests for bitmap_remap() / bitmap_bitremap(), we should;
2) these functions are used at least in one GPIO driver, so it would be nice
to not touch them if they are not broken (see 1 above).
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-06-14 16:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-13 11:29 [PATCH] bitmap: fix a unproper remap when mpol_rebind_nodemask() Yi Wang
2022-06-13 19:20 ` Yury Norov
2022-06-14 3:45 ` wang.yi59
2022-06-14 16:40 ` [PATCH] " Yury Norov
2022-06-14 16:50 ` Andy Shevchenko [this message]
2022-06-15 8:54 ` wang.yi59
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yqi8VH39+1L72hw1@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Liu.Jianjun3@zte.com.cn \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@rasmusvillemoes.dk \
--cc=wang.liang82@zte.com.cn \
--cc=wang.yi59@zte.com.cn \
--cc=xue.zhihong@zte.com.cn \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.