From: asmadeus@codewreck.org
To: Yang Li <yang.lee@linux.alibaba.com>
Cc: ericvh@gmail.com, lucho@ionkov.net, linux_oss@crudebyte.com,
v9fs-developer@lists.sourceforge.net,
linux-kernel@vger.kernel.org,
Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH -next] 9p: Fix some kernel-doc comments
Date: Wed, 15 Jun 2022 12:02:51 +0900 [thread overview]
Message-ID: <YqlL22D6l7XErRoo@codewreck.org> (raw)
In-Reply-To: <20220615012039.43479-1-yang.lee@linux.alibaba.com>
Yang Li wrote on Wed, Jun 15, 2022 at 09:20:39AM +0800:
> Remove warnings found by running scripts/kernel-doc,
> which is caused by using 'make W=1'.
ugh, I was told W=1 would become the default for net,
but I guess it isn't question about that yet for fs...
Do you know how to make W=1 the default for part of the subtree?
> fs/9p/fid.c:35: warning: Function parameter or member 'pfid' not described in 'v9fs_fid_add'
> fs/9p/fid.c:35: warning: Excess function parameter 'fid' description in 'v9fs_fid_add'
> fs/9p/fid.c:80: warning: Function parameter or member 'pfid' not described in 'v9fs_open_fid_add'
> fs/9p/fid.c:80: warning: Excess function parameter 'fid' description in 'v9fs_open_fid_add'
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Will apply and add a note that it is NULLed out, thanks.
> ---
> fs/9p/fid.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/9p/fid.c b/fs/9p/fid.c
> index 289a85eae2ae..3a0f5963b8bd 100644
> --- a/fs/9p/fid.c
> +++ b/fs/9p/fid.c
> @@ -28,7 +28,7 @@ static inline void __add_fid(struct dentry *dentry, struct p9_fid *fid)
> /**
> * v9fs_fid_add - add a fid to a dentry
> * @dentry: dentry that the fid is being added to
> - * @fid: fid to add
> + * @pfid: fid to add
> *
> */
> void v9fs_fid_add(struct dentry *dentry, struct p9_fid **pfid)
> @@ -72,7 +72,7 @@ static struct p9_fid *v9fs_fid_find_inode(struct inode *inode, kuid_t uid)
> /**
> * v9fs_open_fid_add - add an open fid to an inode
> * @inode: inode that the fid is being added to
> - * @fid: fid to add
> + * @pfid: fid to add
> *
> */
>
prev parent reply other threads:[~2022-06-15 3:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-15 1:20 [PATCH -next] 9p: Fix some kernel-doc comments Yang Li
2022-06-15 3:02 ` asmadeus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YqlL22D6l7XErRoo@codewreck.org \
--to=asmadeus@codewreck.org \
--cc=abaci@linux.alibaba.com \
--cc=ericvh@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux_oss@crudebyte.com \
--cc=lucho@ionkov.net \
--cc=v9fs-developer@lists.sourceforge.net \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.