From: William Breathitt Gray <william.gray@linaro.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
linux-iio <linux-iio@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] iio: adc: stx104: Implement and utilize register structures
Date: Wed, 15 Jun 2022 07:55:54 -0400 [thread overview]
Message-ID: <YqnIygHDSUbV5yws@fedora> (raw)
In-Reply-To: <CAHp75VepZ8P_cqnN8qJ_Wb=xM0LW3y-a22tv1otDReFSqRDFYA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 526 bytes --]
On Wed, Jun 15, 2022 at 11:44:54AM +0200, Andy Shevchenko wrote:
> On Mon, Jun 6, 2022 at 4:27 PM William Breathitt Gray
> <william.gray@linaro.org> wrote:
> >
> > Reduce magic numbers and improve code readability by implementing and
> > utilizing named register data structures.
>
> Can we consider using regmap APIs instead?
>
>
> --
> With Best Regards,
> Andy Shevchenko
The regmap API may be more appropriate here. I'll investigate and see if
I can convert this over to it.
William Breathitt Gray
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2022-06-15 11:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-06 14:15 [PATCH 0/2] iio: Implement and utilize register structures for William Breathitt Gray
2022-06-06 14:15 ` [PATCH 1/2] iio: adc: stx104: Implement and utilize register structures William Breathitt Gray
2022-06-14 11:22 ` Jonathan Cameron
2022-06-14 16:12 ` William Breathitt Gray
2022-06-15 9:44 ` Andy Shevchenko
2022-06-15 11:55 ` William Breathitt Gray [this message]
2022-06-15 12:00 ` Andy Shevchenko
2022-06-15 12:19 ` William Breathitt Gray
2022-06-15 12:43 ` Andy Shevchenko
2022-06-16 13:27 ` Mark Brown
2022-06-06 14:15 ` [PATCH 2/2] iio: dac: cio-dac: " William Breathitt Gray
2022-06-14 11:26 ` Jonathan Cameron
2022-06-14 16:15 ` William Breathitt Gray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YqnIygHDSUbV5yws@fedora \
--to=william.gray@linaro.org \
--cc=andy.shevchenko@gmail.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.