From: Sean Christopherson <seanjc@google.com>
To: Varad Gautam <varad.gautam@suse.com>
Cc: kvm@vger.kernel.org, pbonzini@redhat.com, drjones@redhat.com,
marcorr@google.com, zxwang42@gmail.com, erdemaktas@google.com,
rientjes@google.com, brijesh.singh@amd.com,
Thomas.Lendacky@amd.com, jroedel@suse.de, bp@suse.de
Subject: Re: [kvm-unit-tests PATCH v3 11/11] x86: Provide a common 64-bit AP entrypoint for EFI and non-EFI
Date: Wed, 15 Jun 2022 23:13:36 +0000 [thread overview]
Message-ID: <YqpnoHntuPDggAKc@google.com> (raw)
In-Reply-To: <20220426114352.1262-12-varad.gautam@suse.com>
On Tue, Apr 26, 2022, Varad Gautam wrote:
> +void ap_start64(void)
> +{
> + setup_gdt_tss();
> + reset_apic();
> + load_idt();
> + save_id();
> + enable_apic();
> + enable_x2apic();
> + sti();
> + asm volatile ("nop");
> + printf("setup: AP %d online\n", apic_id());
> + atomic_inc(&cpu_online_count);
> + while (1) {
Unnecessary curly braces. And rather then spin, let's do "hlt", that way everything
from the sti onwards can be moved to a common helper, e.g. ap_online().
next prev parent reply other threads:[~2022-06-15 23:13 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-26 11:43 [kvm-unit-tests PATCH v3 00/11] SMP Support for x86 UEFI Tests Varad Gautam
2022-04-26 11:43 ` [kvm-unit-tests PATCH v3 01/11] x86: Share realmode trampoline between i386 and x86_64 Varad Gautam
2022-04-26 11:43 ` [kvm-unit-tests PATCH v3 02/11] x86: Move ap_init() to smp.c Varad Gautam
2022-06-15 21:20 ` Sean Christopherson
2022-06-15 21:31 ` Sean Christopherson
2022-06-16 11:56 ` Andrew Jones
2022-06-16 16:44 ` Sean Christopherson
2022-04-26 11:43 ` [kvm-unit-tests PATCH v3 03/11] x86: Move load_idt() to desc.c Varad Gautam
2022-04-26 11:43 ` [kvm-unit-tests PATCH v3 04/11] x86: desc: Split IDT entry setup into a generic helper Varad Gautam
2022-04-26 11:43 ` [kvm-unit-tests PATCH v3 05/11] x86: Move load_gdt_tss() to desc.c Varad Gautam
2022-04-26 11:43 ` [kvm-unit-tests PATCH v3 06/11] x86: efi: Provide a stack within testcase memory Varad Gautam
2022-04-26 11:43 ` [kvm-unit-tests PATCH v3 07/11] x86: efi: Provide percpu storage Varad Gautam
2022-04-26 11:43 ` [kvm-unit-tests PATCH v3 08/11] x86: efi, smp: Transition APs from 16-bit to 32-bit mode Varad Gautam
2022-04-26 11:43 ` [kvm-unit-tests PATCH v3 09/11] x86: Move 32-bit bringup routines to start32.S Varad Gautam
2022-06-15 23:10 ` Sean Christopherson
2022-04-26 11:43 ` [kvm-unit-tests PATCH v3 10/11] x86: efi, smp: Transition APs from 32-bit to 64-bit mode Varad Gautam
2022-06-15 23:12 ` Sean Christopherson
2022-04-26 11:43 ` [kvm-unit-tests PATCH v3 11/11] x86: Provide a common 64-bit AP entrypoint for EFI and non-EFI Varad Gautam
2022-06-15 23:13 ` Sean Christopherson [this message]
2022-06-15 21:19 ` [kvm-unit-tests PATCH v3 00/11] SMP Support for x86 UEFI Tests Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YqpnoHntuPDggAKc@google.com \
--to=seanjc@google.com \
--cc=Thomas.Lendacky@amd.com \
--cc=bp@suse.de \
--cc=brijesh.singh@amd.com \
--cc=drjones@redhat.com \
--cc=erdemaktas@google.com \
--cc=jroedel@suse.de \
--cc=kvm@vger.kernel.org \
--cc=marcorr@google.com \
--cc=pbonzini@redhat.com \
--cc=rientjes@google.com \
--cc=varad.gautam@suse.com \
--cc=zxwang42@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.