From: Ming Lei <ming.lei@redhat.com>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v3 3/3] block: Make blk_mq_get_sq_hctx() select the proper hardware queue type
Date: Thu, 16 Jun 2022 09:37:35 +0800 [thread overview]
Message-ID: <YqqJXxWGINzHfvm6@T590> (raw)
In-Reply-To: <20220615225549.1054905-4-bvanassche@acm.org>
On Wed, Jun 15, 2022 at 03:55:49PM -0700, Bart Van Assche wrote:
> Since the introduction of blk_mq_get_hctx_type() the operation type in
> the second argument of blk_mq_get_hctx_type() matters. The introduction
> of blk_mq_get_hctx_type() caused blk_mq_get_sq_hctx() to select a
> hardware queue of type HCTX_TYPE_READ instead of HCTX_TYPE_DEFAULT.
> Switch to hardware queue type HCTX_TYPE_DEFAULT since HCTX_TYPE_READ
> should only be used for read requests.
>
> Cc: Ming Lei <ming.lei@redhat.com>
> Cc: Christoph Hellwig <hch@lst.de>
> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Reviewed-by: Ming Lei <ming.lei@redhat.com>
Thanks,
Ming
next prev parent reply other threads:[~2022-06-16 1:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-15 22:55 [PATCH v3 0/3] Three small block layer patches Bart Van Assche
2022-06-15 22:55 ` [PATCH v3 1/3] blk-iocost: Simplify ioc_rqos_done() Bart Van Assche
2022-06-15 22:55 ` [PATCH v3 2/3] block: Rename a blk_mq_map_queue() argument Bart Van Assche
2022-06-15 22:55 ` [PATCH v3 3/3] block: Make blk_mq_get_sq_hctx() select the proper hardware queue type Bart Van Assche
2022-06-16 1:37 ` Ming Lei [this message]
2022-06-16 6:17 ` Christoph Hellwig
2022-06-16 20:46 ` [PATCH v3 0/3] Three small block layer patches Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YqqJXxWGINzHfvm6@T590 \
--to=ming.lei@redhat.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.