From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4CDDCC43334 for ; Thu, 16 Jun 2022 10:36:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2sFmWeLujqH2RZjszKhcuhNqY58I1DcIWIJGp0NxIdE=; b=aVYQOvq3UYqebL lw8IxvCwzSeisfTCBZfcQqp3euzQ7DqMozd3kNB+zN3ViVimiOqYge2i67SntfDLhC6LbfkaeHGKz /tf9ZE16/Ipoyw+fdSvlY/Y69RyOpvU7Uyk3G6eILJ9RZuz0+umNHVWz8MiG/9LsyRdvjRoWOnyiQ fw3ySKeUB1xYwBICA1tC5mGx2PNqGcc/VppTwv3re4vtg3D+W1Sn3qZLOk/7+Z6Bm65wWou0l3ldq VTmA+SQLAdsObzzqckPtdpCn4FFWK4L0it1FpkSE8fvFAHxk+WnZVRi/bVB8ZQ0ci4VhSHTT2OxDW YvaRo/akUzrpwT8lgZkw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o1mqp-001ti7-TZ; Thu, 16 Jun 2022 10:35:47 +0000 Received: from mga12.intel.com ([192.55.52.136]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o1mql-001tgt-Ju for linux-mtd@lists.infradead.org; Thu, 16 Jun 2022 10:35:45 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1655375743; x=1686911743; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=bfn7Kr/6Mg81QIsDd2mRVCMs364rPZOp5AMz87j7Fog=; b=lMzypovoHSMG5W3a5fV+LsHyxWdTBrCwGtH7zgiHUJZf7RubDZJO/Djx mF6EIoUfTcb7x+xaUv2xXOeKO8/dEn5+Z1VDXVkbHTZtORpENgVTLZk2f QrHdq+EaRLHqUUyFDWDnLX6OxkAH14wbHNxe5gNW78N80+oIMmooNls1K mSrmN9xaKGbYNPeuqZv2xcUnT1rHveeYH1MG5pxhC0P3v95/OjPPJU8ia kbzHMany296XEdXJANn8BsnPop0nhqkfOmE2glruMqxITiOFAXTx8KW0N p9wzet0qyTTI/UQJKZTJSYwocP0GYFduCd4z+z2i7QJvxOsYFZ8DFccxq A==; X-IronPort-AV: E=McAfee;i="6400,9594,10379"; a="259073413" X-IronPort-AV: E=Sophos;i="5.91,304,1647327600"; d="scan'208";a="259073413" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jun 2022 03:35:37 -0700 X-IronPort-AV: E=Sophos;i="5.91,304,1647327600"; d="scan'208";a="727840496" Received: from lahna.fi.intel.com (HELO lahna) ([10.237.72.162]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jun 2022 03:35:31 -0700 Received: by lahna (sSMTP sendmail emulation); Thu, 16 Jun 2022 13:35:28 +0300 Date: Thu, 16 Jun 2022 13:35:28 +0300 From: Mika Westerberg To: "Oleksandr Ocheretnyi -X (oocheret - GLOBALLOGIC INC at Cisco)" Cc: "tudor.ambarus@microchip.com" , "miquel.raynal@bootlin.com" , "p.yadav@ti.com" , "michael@walle.cc" , "richard@nod.at" , "vigneshr@ti.com" , "broonie@kernel.org" , "linux-mtd@lists.infradead.org" , "linux-spi@vger.kernel.org" , "mauro.lima@eclypsium.com" , "lee.jones@linaro.org" , "linux-kernel@vger.kernel.org" , "xe-linux-external(mailer list)" Subject: Re: [PATCH v2] mtd: spi-nor: handle unsupported FSR opcodes properly Message-ID: References: <6A852B9E-D84C-4F80-9C17-62BFBB98CC8A@walle.cc> <20220615191153.3017939-1-oocheret@cisco.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220616_033543_713632_4DEDE2B8 X-CRM114-Status: GOOD ( 28.01 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGksCgpPbiBUaHUsIEp1biAxNiwgMjAyMiBhdCAwNzo0MDoxOEFNICswMDAwLCBPbGVrc2FuZHIg T2NoZXJldG55aSAtWCAob29jaGVyZXQgLSBHTE9CQUxMT0dJQyBJTkMgYXQgQ2lzY28pIHdyb3Rl Ogo+ICAgIEhpIE1pa2EsCj4gCj4gICAgICA+IE9yaWdpbmFsbHkgY29tbWl0IDA5NGQzYjkgKCJt dGQ6IHNwaS1ub3I6IEFkZCBVU0VfRlNSIGZsYWcgZm9yCj4gICAgICBuMjVxKgo+ICAgICAgPiBl bnRyaWVzIikgYW5kIGZvbGxvd2luZyBvbmUgOGY5MzgyNiAoIm10ZDogc3BpLW5vcjogbWljcm9u LXN0Ogo+ICAgICAgY29udmVydAo+ICAgICAgPiBVU0VfRlNSIHRvIGEgbWFudWZhY3R1cmVyIGZs YWciKSBlbmFibGVkIFNQSU5PUl9PUF9SREZTUiBvcGNvZGUKPiAgICAgIGhhbmRsaW5nCj4gICAg ICA+IGFiaWxpdHksIGhvd2V2ZXIgc29tZSBjb250cm9sbGVyIGRyaXZlcnMgc3RpbGwgY2Fubm90 IGhhbmRsZSBpdAo+ICAgICAgcHJvcGVybHkKPiAgICAgID4gaW4gdGhlIG1pY3Jvbl9zdF9ub3Jf cmVhZHkoKSBjYWxsIHdoYXQgYnJlYWtzIHNvbWUgbXRkIGNhbGxiYWNrcwo+ICAgICAgd2l0aAo+ ICAgICAgPiBuZXh0IGVycm9yIGxvZ3M6Cj4gICAgICA+Cj4gICAgICA+IG10ZGJsb2NrOiBlcmFz ZSBvZiByZWdpb24gW2FkZHJlc3MxLCBzaXplMV0gb24gIkJJT1MiIGZhaWxlZAo+ICAgICAgPiBt dGRibG9jazogZXJhc2Ugb2YgcmVnaW9uIFthZGRyZXNzMiwgc2l6ZTJdIG9uICJCSU9TIiBmYWls ZWQKPiAgICAgID4KPiAgICAgID4gVGhlIEludGVsIFNQSSBjb250cm9sbGVyIGRvZXMgbm90IHN1 cHBvcnQgbG93IGxldmVsIG9wZXJhdGlvbnMsCj4gICAgICBsaWtlCj4gICAgICA+IHJlYWRpbmcg dGhlIGZsYWcgc3RhdHVzIHJlZ2lzdGVyIChGU1IpLiBJdCBvbmx5IGV4cG9zZXMgYSBzZXQgb2YK PiAgICAgIGhpZ2gKPiAgICAgID4gbGV2ZWwgb3BlcmF0aW9ucyBmb3Igc29mdHdhcmUgdG8gdXNl LiBGb3IgdGhpcyByZWFzb24gY2hlY2sgdGhlCj4gICAgICByZXR1cm4KPiAgICAgID4gdmFsdWUg b2YgbWljcm9uX3N0X25vcl9yZWFkX2ZzcigpIGFuZCBpZiB0aGUgb3BlcmF0aW9uIHdhcyBub3QK PiAgICAgID4gc3VwcG9ydGVkLCB1c2UgdGhlIHN0YXR1cyByZWdpc3RlciB2YWx1ZSBvbmx5LiBU aGlzIGFsbG93cyB0aGUKPiAgICAgIGNoaXAgdG8KPiAgICAgID4gd29yayBldmVuIHdoZW4gYXR0 YWNoZWQgdG8gSW50ZWwgU1BJIGNvbnRyb2xsZXIgKHRoZXJlIGFyZSBzdWNoCj4gICAgICBzeXN0 ZW1zCj4gICAgICA+IG91dCB0aGVyZSkuCj4gICAgICA+Cj4gCj4gICAgPiBTaWduZWQtb2ZmLWJ5 OiBNaWthIFdlc3RlcmJlcmcgPG1pa2Eud2VzdGVyYmVyZ0BsaW51eC5pbnRlbC5jb20+Cj4gCj4g ICAgICBJIGRvbid0IHRoaW5rIEkgc2lnbmVkIHRoaXMgb2ZmLgo+IAo+ICAgIEkgdGhvdWdodCBp ZiBJIHRha2UgeW91ciBjYXNlICgtRU9QTk9UU1VQUCkgYW5kIHVwZGF0ZSBpdCB3aXRoCj4gICAg KC1FTk9UU1VQUCkgSSBuZWVkIHRvIGtlZXAKPiAKPiAgICB5b3VyIFNpZ2hlZC1vZmYtYnk6IG5v dGUgYXMgd2VsbC4KClRoYXQncyBub3QgaG93IGl0IHR5cGljYWxseSB3b3Jrcy4gUGVvcGxlIHdp bGwgZ2l2ZSB0aGVpciB0YWcgZXhwbGljaXRseQphbmQgdGhlbiB5b3UgY2FuIGFkZCB0aG9zZS4K Cj4gICAgPiBTaWduZWQtb2ZmLWJ5OiBPbGVrc2FuZHIgT2NoZXJldG55aSA8b29jaGVyZXRAY2lz Y28uY29tPgo+ICAgID4gTGluazogWzFdaHR0cHM6Ly9sb3JlLmtlcm5lbC5vcmcvbGttbC9ZbVpV Q0lFJTJGTkQ4MkJsTmhAbGFobmEvCj4gICAgPiAtLS0KPiAKPiAgICBXaGF0IGNoYW5nZWQgYmV0 d2VlbiB2MSBhbmQgdjI/Cj4gCj4gICAg4oCLSSB1cGRhdGVkIHYxIHBhdGNoIHRha2luZyBpbnRv IGFjY291bnQgeW91ciBjaGFuZ2VzCj4gICAgWzJdaHR0cHM6Ly9sb3JlLmtlcm5lbC5vcmcvbGlu dXgtbXRkLzIwMjIwNTA2MTA1MTU4LjQzNjEzLTEtbWlrYS53ZXN0ZXIKPiAgICBiZXJnQGxpbnV4 LmludGVsLmNvbSB0byBjaGVjayAtRU9QTk9UU1VQUCBjYXNlIGFzIHdlbGwuIEFmdGVyIEkKPiAg ICBjb21iaW5lZCBib3RoIHBhdGNoZXMgSSd2ZSBnb3QgdjIuCgpQbGVhc2UgcHV0IHRoYXQgaW5m b3JtYXRpb24gYWZ0ZXIgdGhlICctLS0nIGluIHRoZSBwYXRjaC4KCj4gICAgQW5kIGRpZCB5b3Ug dGFrZSBpbnRvIGNvbnNpZGVyYXRpb24gdGhlIGNvbW1lbnRzIEkgZ2F2ZT8KPiAKPiAgICDigItJ ZiB5b3Ugc2F5IGFib3V0IGtlZXBpbmcgLUVOT1RTVVBQIGFzIGludGVsIGRyaXZlciBlcnJvcmNv ZGUgLSBJIHRvb2sKPiAgICBpdCBob3dldmVyIGRvdWJ0ZWQgdG8gdXNlIGl0IGhlcmUgYmVjYXVz ZSBvZiBub3RlIGFib3V0IG5mcyBhYm92ZS4KPiAgICBUaGVyZSBpcyBubyBwcm9ibGVtIHRvIHJl c3RvcmUgcHJldmlvdXMgdmFyaWFudCB3aXRoIC1FTk9UU1VQUCBpbiBpbnRlbAo+ICAgIGRyaXZl ciBlcnJvcmNvZGUuCgpXZWxsIHdlIHdvdWxkIG5lZWQgdG8gZ2V0IHNvbWUgZmVlZGJhY2sgZnJv bSBTUEktTk9SIG1haW50YWluZXJzLiBJCndvdWxkIHBlcnNvbmFsbHkga2VlcCB1c2luZyBFTk9U U1VQUCB0byBiZSBjb25zaXN0ZW50IHdpdGggdGhlIHJlc3Qgb2YKdGhlIGNvZGUgaW4gU1BJLU5P UiBjb2RlIChvciBjb252ZXJ0IGl0IHRvIHVzZSBFT1BOT1RTVVBQIGV2ZXJ5d2hlcmUpCmJ1dCBp dCBpcyBub3QgdXAgdG8gbWUgOy0pCgpGb3IgSW50ZWwgZHJpdmVyIGl0IGlzIGZpbmUgdG8gdXNl IGVpdGhlciAod2hldGV2ZXIgdGhlIGRlY2lzaW9uIG9mClNQSS1OT1IgbWFpbnRhaW5lcnMnIGlz KS4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpMaW51eCBNVEQgZGlzY3Vzc2lvbiBtYWlsaW5nIGxpc3QKaHR0cDovL2xpc3RzLmluZnJhZGVh ZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1tdGQvCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3168CC43334 for ; Thu, 16 Jun 2022 10:36:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230216AbiFPKgb (ORCPT ); Thu, 16 Jun 2022 06:36:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50962 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230237AbiFPKf7 (ORCPT ); Thu, 16 Jun 2022 06:35:59 -0400 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AF1B75DBFB; Thu, 16 Jun 2022 03:35:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1655375735; x=1686911735; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=bfn7Kr/6Mg81QIsDd2mRVCMs364rPZOp5AMz87j7Fog=; b=C+HO0dlgTSRS5BfiNc1wvbzLqRPtBxh4lxKP++PeFC57ARyGINKRpntX 0zyMKWsvVTNVYHuC6ewnc1eT2T4K4Edtlllg948WtjDY9EIBPNC1wEAi/ 7MfO3q6B4v1XjQ564zn8Ec5n0B0cSC96prihpGOri1RhurvnFojyhC6o0 /jnxvSYj/40fOFsU13bsfC0UY/6V2aLPs+4Dccvg5a2qUxrOAYdrBM4P8 VDXzqMJHj65sGGZQOgeMOONPgWe26/IQevpSVxwI4BHXe1cHfVlF1GsPE StZzrOtvrn6Phr2ycnJFnCt+KR0bxXIWRt/thukjN0Cdtt3+qtzXu++Cv g==; X-IronPort-AV: E=McAfee;i="6400,9594,10379"; a="259681977" X-IronPort-AV: E=Sophos;i="5.91,304,1647327600"; d="scan'208";a="259681977" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jun 2022 03:35:35 -0700 X-IronPort-AV: E=Sophos;i="5.91,304,1647327600"; d="scan'208";a="727840496" Received: from lahna.fi.intel.com (HELO lahna) ([10.237.72.162]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jun 2022 03:35:31 -0700 Received: by lahna (sSMTP sendmail emulation); Thu, 16 Jun 2022 13:35:28 +0300 Date: Thu, 16 Jun 2022 13:35:28 +0300 From: Mika Westerberg To: "Oleksandr Ocheretnyi -X (oocheret - GLOBALLOGIC INC at Cisco)" Cc: "tudor.ambarus@microchip.com" , "miquel.raynal@bootlin.com" , "p.yadav@ti.com" , "michael@walle.cc" , "richard@nod.at" , "vigneshr@ti.com" , "broonie@kernel.org" , "linux-mtd@lists.infradead.org" , "linux-spi@vger.kernel.org" , "mauro.lima@eclypsium.com" , "lee.jones@linaro.org" , "linux-kernel@vger.kernel.org" , "xe-linux-external(mailer list)" Subject: Re: [PATCH v2] mtd: spi-nor: handle unsupported FSR opcodes properly Message-ID: References: <6A852B9E-D84C-4F80-9C17-62BFBB98CC8A@walle.cc> <20220615191153.3017939-1-oocheret@cisco.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org Hi, On Thu, Jun 16, 2022 at 07:40:18AM +0000, Oleksandr Ocheretnyi -X (oocheret - GLOBALLOGIC INC at Cisco) wrote: > Hi Mika, > > > Originally commit 094d3b9 ("mtd: spi-nor: Add USE_FSR flag for > n25q* > > entries") and following one 8f93826 ("mtd: spi-nor: micron-st: > convert > > USE_FSR to a manufacturer flag") enabled SPINOR_OP_RDFSR opcode > handling > > ability, however some controller drivers still cannot handle it > properly > > in the micron_st_nor_ready() call what breaks some mtd callbacks > with > > next error logs: > > > > mtdblock: erase of region [address1, size1] on "BIOS" failed > > mtdblock: erase of region [address2, size2] on "BIOS" failed > > > > The Intel SPI controller does not support low level operations, > like > > reading the flag status register (FSR). It only exposes a set of > high > > level operations for software to use. For this reason check the > return > > value of micron_st_nor_read_fsr() and if the operation was not > > supported, use the status register value only. This allows the > chip to > > work even when attached to Intel SPI controller (there are such > systems > > out there). > > > > > Signed-off-by: Mika Westerberg > > I don't think I signed this off. > > I thought if I take your case (-EOPNOTSUPP) and update it with > (-ENOTSUPP) I need to keep > > your Sighed-off-by: note as well. That's not how it typically works. People will give their tag explicitly and then you can add those. > > Signed-off-by: Oleksandr Ocheretnyi > > Link: [1]https://lore.kernel.org/lkml/YmZUCIE%2FND82BlNh@lahna/ > > --- > > What changed between v1 and v2? > > ​I updated v1 patch taking into account your changes > [2]https://lore.kernel.org/linux-mtd/20220506105158.43613-1-mika.wester > berg@linux.intel.com to check -EOPNOTSUPP case as well. After I > combined both patches I've got v2. Please put that information after the '---' in the patch. > And did you take into consideration the comments I gave? > > ​If you say about keeping -ENOTSUPP as intel driver errorcode - I took > it however doubted to use it here because of note about nfs above. > There is no problem to restore previous variant with -ENOTSUPP in intel > driver errorcode. Well we would need to get some feedback from SPI-NOR maintainers. I would personally keep using ENOTSUPP to be consistent with the rest of the code in SPI-NOR code (or convert it to use EOPNOTSUPP everywhere) but it is not up to me ;-) For Intel driver it is fine to use either (whetever the decision of SPI-NOR maintainers' is).