From: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: bpf@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net,
netdev@vger.kernel.org, magnus.karlsson@intel.com,
bjorn@kernel.org, Alexandr Lobakin <alexandr.lobakin@intel.com>
Subject: Re: [PATCH v2 bpf-next 01/10] ice: allow toggling loopback mode via ndo_set_features callback
Date: Thu, 16 Jun 2022 19:00:11 +0200 [thread overview]
Message-ID: <Yqthm2ZFoJ1SnK6B@boxer> (raw)
In-Reply-To: <20220616094740.276b8312@kernel.org>
On Thu, Jun 16, 2022 at 09:47:40AM -0700, Jakub Kicinski wrote:
> On Thu, 16 Jun 2022 18:00:40 +0200 Maciej Fijalkowski wrote:
> > > Loopback or not, I don't think we should be accepting the shutdown ->
> > > set config -> pray approach in modern drivers. ice_open() seems to be
> > > allocating all the Rx memory, and can fail.
> >
> > They say that those who sing pray twice, so why don't we sing? :)
> >
> > But seriously, I'll degrade this to ice_down/up and check retvals. I think
> > I just mimicked flow from ice_self_test(), which should be fixed as
> > well...
> >
> > I'll send v4.
>
> checking retval is not enough, does ice not have the ability to
> allocate resources upfront? I think iavf was already restructured
> to follow the "resilient" paradigm, time for ice to follow suit?
I'm not aware of such restructure TBH. FWIW ice_down() won't free
irqs/rings. I said I'll switch to it plus check its retval whereas I feel
like you took it like I would want to keep the ice_stop() and check its
retval.
>
> This is something DaveM complained about in the first Ethernet driver
> I upstreamed, which must have been a decade ago by now. It's time we
> all get on board :)
next prev parent reply other threads:[~2022-06-16 17:00 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-14 17:47 [PATCH v2 bpf-next 00/10] AF_XDP ZC selftests Maciej Fijalkowski
2022-06-14 17:47 ` [PATCH v2 bpf-next 01/10] ice: allow toggling loopback mode via ndo_set_features callback Maciej Fijalkowski
2022-06-15 10:38 ` Alexander Lobakin
2022-06-15 14:01 ` Maciej Fijalkowski
2022-06-15 16:09 ` Maciej Fijalkowski
2022-06-15 23:47 ` Jakub Kicinski
2022-06-16 16:00 ` Maciej Fijalkowski
2022-06-16 16:47 ` Jakub Kicinski
2022-06-16 17:00 ` Maciej Fijalkowski [this message]
2022-06-14 17:47 ` [PATCH v2 bpf-next 02/10] ice: check DD bit on Rx descriptor rather than (EOP | RS) Maciej Fijalkowski
2022-06-14 17:47 ` [PATCH v2 bpf-next 03/10] ice: do not setup vlan for loopback VSI Maciej Fijalkowski
2022-06-14 17:47 ` [PATCH v2 bpf-next 04/10] selftests: xsk: query for native XDP support Maciej Fijalkowski
2022-06-15 7:07 ` Magnus Karlsson
2022-06-14 17:47 ` [PATCH v2 bpf-next 05/10] selftests: xsk: add missing close() on netns fd Maciej Fijalkowski
2022-06-14 17:47 ` [PATCH v2 bpf-next 06/10] selftests: xsk: introduce default Rx pkt stream Maciej Fijalkowski
2022-06-14 17:47 ` [PATCH v2 bpf-next 07/10] selftests: xsk: add support for executing tests on physical device Maciej Fijalkowski
2022-06-14 17:47 ` [PATCH v2 bpf-next 08/10] selftests: xsk: rely on pkts_in_flight in wait_for_tx_completion() Maciej Fijalkowski
2022-06-14 17:47 ` [PATCH v2 bpf-next 09/10] selftests: xsk: remove struct xsk_socket_info::outstanding_tx Maciej Fijalkowski
2022-06-14 17:47 ` [PATCH v2 bpf-next 10/10] selftests: xsk: add support for zero copy testing Maciej Fijalkowski
2022-06-15 7:09 ` Magnus Karlsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yqthm2ZFoJ1SnK6B@boxer \
--to=maciej.fijalkowski@intel.com \
--cc=alexandr.lobakin@intel.com \
--cc=ast@kernel.org \
--cc=bjorn@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kuba@kernel.org \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.