From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 00F7AC433EF for ; Thu, 16 Jun 2022 20:40:20 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 896EC1AF8; Thu, 16 Jun 2022 22:39:28 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 896EC1AF8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1655412018; bh=pmK7hqntMtift0Pd/khpkTdQCSMUI0c+tUiQ8GB6EdQ=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=VpWqkr85MCxWoDi+PxE+kAX1ZY7fRP8ZV+z21KA1rO7PNIWKr32mmGVPkUiteINru 5ITjkChpEFJCILSh+XNETPufpx9JI5fj65h+UYUi+uqblwhLcwLJoFi1FXTUXRoMq2 93DW8NpEwg9oA4KwYPjz5JjNVqDwqLQeL6RFyc88= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 2033AF8012A; Thu, 16 Jun 2022 22:39:28 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 4A5E0F801D8; Thu, 16 Jun 2022 22:39:27 +0200 (CEST) Received: from mail-pj1-x1030.google.com (mail-pj1-x1030.google.com [IPv6:2607:f8b0:4864:20::1030]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id C37E7F800B9 for ; Thu, 16 Jun 2022 22:39:20 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz C37E7F800B9 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="ROZn+y/7" Received: by mail-pj1-x1030.google.com with SMTP id v11-20020a17090a4ecb00b001e2c5b837ccso2806170pjl.3 for ; Thu, 16 Jun 2022 13:39:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=pkTlqBCv4kkUBzXfdE69AlbwDzWnDXPmq1X/ctwZ1RI=; b=ROZn+y/7o3WKT8p5stMPNJszpKJne4D3/Za9voE4D9qs7VwnFgZTseD6+HxsBnKHov rlTxbyYs4W0Iquvo4qHE70ivqOFlD9BOvwBoC+2PAKOw5Li1rI5SuWzQIMoZoQdgMPQQ xeKSWDr237Bfr3p2GiCiYStFm/NkPc/o4cp4Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=pkTlqBCv4kkUBzXfdE69AlbwDzWnDXPmq1X/ctwZ1RI=; b=N83jgB+tXTG4J1pu9yWgRV8q9eHo0LgOI5kv480S2Hs8svcaYAULKBUMsECKI7Pcse Q8OGnIvIs3iSOTy65+VHcxnybSA+GE6Jau33HprJsxoAzg5Eoxeb3NhFq8DX2kgU2RAY lMjm06rsCPP5FYwJVkc7yNtnjrH3ccoGGOzUWbD0QKKVIy4X7aUfeE6SJHAMFMFPSNop jnPWdQzqWAS+g4vyVOVwoX8VZkKvJjlYKtAF/+Z4Uj7evSHdMd9/vRIc6r94uDHqD24P qCOOlShfFleTXqHm3Gp+08BRN2sBGIMuGhgFaisHqTnJHY9JUck/xI0wx0c4LRedD+Ro ymyg== X-Gm-Message-State: AJIora+ScDENPPSL2m9WvU9SmO4057cbUYCVJqZTV2RR1AjM5im0wiSx NPHLAdBsjLczti+M4rNvYL7KTw== X-Google-Smtp-Source: AGRyM1uRzdYi2h3WMgzsyG09F2s9/Uo4CiVLNg4n/tohSEwV59gL8BG6VgxVEBMNWkC3PEFczoXGPA== X-Received: by 2002:a17:902:a609:b0:169:a8b:7c3c with SMTP id u9-20020a170902a60900b001690a8b7c3cmr3281133plq.67.1655411957916; Thu, 16 Jun 2022 13:39:17 -0700 (PDT) Received: from google.com ([2620:15c:202:201:4709:a407:1ca6:24ea]) by smtp.gmail.com with ESMTPSA id jh17-20020a170903329100b00168b9093a06sm2038204plb.243.2022.06.16.13.39.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jun 2022 13:39:16 -0700 (PDT) Date: Thu, 16 Jun 2022 13:39:14 -0700 From: Brian Norris To: Judy Hsiao Subject: Re: [PATCH v2 3/3] ASoC: dt-bindings: rockchip: Document pinctrl-names for i2s Message-ID: References: <20220616155836.3401420-1-judyhsiao@chromium.org> <20220616155836.3401420-4-judyhsiao@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220616155836.3401420-4-judyhsiao@chromium.org> Cc: alsa-devel@alsa-project.org, Heiko Stuebner , linux-kernel@vger.kernel.org, Liam Girdwood , Rob Herring , linux-rockchip@lists.infradead.org, Mark Brown , Chen-Yu Tsai , linux-arm-kernel@lists.infradead.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Thu, Jun 16, 2022 at 03:58:36PM +0000, Judy Hsiao wrote: > This patch documents pinctrl-names for i2s. > > Signed-off-by: Judy Hsiao > --- > Documentation/devicetree/bindings/sound/rockchip-i2s.yaml | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/sound/rockchip-i2s.yaml b/Documentation/devicetree/bindings/sound/rockchip-i2s.yaml > index 5ea16b8ef93f..af1069278623 100644 > --- a/Documentation/devicetree/bindings/sound/rockchip-i2s.yaml > +++ b/Documentation/devicetree/bindings/sound/rockchip-i2s.yaml > @@ -61,6 +61,13 @@ properties: > - const: tx > - const: rx > > + pinctrl-names: > + oneOf: > + - const: default > + - items: I'm far from a YAML expert, but I think you have the indentation wrong? You want the "const: default" and the "items:" schema to be on the same level of indentation, right? If you haven't already, you might run through the 'make dt_binding_check' process. Brian > + - const: bclk_on > + - const: bclk_off > + > power-domains: > maxItems: 1 > > -- > 2.36.1.476.g0c4daa206d-goog > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 33C61C43334 for ; Thu, 16 Jun 2022 20:39:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mrQkhgibWo0BwxgG591YaZmLUOzHywS55eDrAVMQcm8=; b=oH7QGo3zZqQOgX msPV3ZQwDLKk1V6/D/PBFXsdm/hdS86o9uHgYdSMt6Vjcykm+/0yiHgB+gFGxmHQn2NnDc1mJsU4j pWAaEkr0eghWWbtHobGWxGw4rETokwSpds+as0dtqHNpuUaBYNQqO3oJdHE0sdEfhxaPSRmmKqzmu grMoH/Bz1H+WLTXmwPbepi1/UbSeRPM5j2x/7tpOBkcWxOAyJwCx/ILPwmzN6hxy2slTnFyc4evF5 ZWx+M6y/hjYBznMuYBTkPhpyo+r/thkogm0xc0KSOYWRl2k8mpAo9+aqQqivO8fhVBml8lU3syGtW ZNj2qn+bT7rAiGLXpZUw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o1wGy-004Bj9-5s; Thu, 16 Jun 2022 20:39:24 +0000 Received: from mail-pj1-x1032.google.com ([2607:f8b0:4864:20::1032]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o1wGv-004BhR-GV for linux-rockchip@lists.infradead.org; Thu, 16 Jun 2022 20:39:22 +0000 Received: by mail-pj1-x1032.google.com with SMTP id k12-20020a17090a404c00b001eaabc1fe5dso2831311pjg.1 for ; Thu, 16 Jun 2022 13:39:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=pkTlqBCv4kkUBzXfdE69AlbwDzWnDXPmq1X/ctwZ1RI=; b=ROZn+y/7o3WKT8p5stMPNJszpKJne4D3/Za9voE4D9qs7VwnFgZTseD6+HxsBnKHov rlTxbyYs4W0Iquvo4qHE70ivqOFlD9BOvwBoC+2PAKOw5Li1rI5SuWzQIMoZoQdgMPQQ xeKSWDr237Bfr3p2GiCiYStFm/NkPc/o4cp4Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=pkTlqBCv4kkUBzXfdE69AlbwDzWnDXPmq1X/ctwZ1RI=; b=hhN3tTsFgoB0W7heobKYtSIYBrGzJeyWLkGCs0JSZE+dGoKLrCV3sZNPUPTjgfKqWF wiZCytcx5rFPobUkneBwqXilbEKwJ9r/NJ7YYIUaC6TlWRrv3ebjtl5Sb/iPFl86Z91Z QuuGXQZpLKHnNYVlWmw0XbP+epKx5TFt7WY30k8LK++S0ovLLbKDOKmtvwZLSzl8EW2d 2jmIbBmAf0uu5ByYZZPApQ9zZ053pZWegf4b6kRjEmx0IxTyZ3X7RLrFHX5smAOebyPR 5M7cCimuYi2s3s9yelBjXMGlVw4t+/mY/NlO9ciPzJzh14oI9Hwta0XruC296EQaZUxO 9gHQ== X-Gm-Message-State: AJIora+672YiQkQmYRbY4lP6PG0LGCozgmE0iksQa/YCX23kLwbh821o m0pyuNwNVIPpIMe42pqYNfN4RQ== X-Google-Smtp-Source: AGRyM1uRzdYi2h3WMgzsyG09F2s9/Uo4CiVLNg4n/tohSEwV59gL8BG6VgxVEBMNWkC3PEFczoXGPA== X-Received: by 2002:a17:902:a609:b0:169:a8b:7c3c with SMTP id u9-20020a170902a60900b001690a8b7c3cmr3281133plq.67.1655411957916; Thu, 16 Jun 2022 13:39:17 -0700 (PDT) Received: from google.com ([2620:15c:202:201:4709:a407:1ca6:24ea]) by smtp.gmail.com with ESMTPSA id jh17-20020a170903329100b00168b9093a06sm2038204plb.243.2022.06.16.13.39.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jun 2022 13:39:16 -0700 (PDT) Date: Thu, 16 Jun 2022 13:39:14 -0700 From: Brian Norris To: Judy Hsiao Cc: Heiko Stuebner , Liam Girdwood , Rob Herring , Mark Brown , Jaroslav Kysela , Chen-Yu Tsai , alsa-devel@alsa-project.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/3] ASoC: dt-bindings: rockchip: Document pinctrl-names for i2s Message-ID: References: <20220616155836.3401420-1-judyhsiao@chromium.org> <20220616155836.3401420-4-judyhsiao@chromium.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220616155836.3401420-4-judyhsiao@chromium.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220616_133921_603839_02683963 X-CRM114-Status: GOOD ( 16.04 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On Thu, Jun 16, 2022 at 03:58:36PM +0000, Judy Hsiao wrote: > This patch documents pinctrl-names for i2s. > > Signed-off-by: Judy Hsiao > --- > Documentation/devicetree/bindings/sound/rockchip-i2s.yaml | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/sound/rockchip-i2s.yaml b/Documentation/devicetree/bindings/sound/rockchip-i2s.yaml > index 5ea16b8ef93f..af1069278623 100644 > --- a/Documentation/devicetree/bindings/sound/rockchip-i2s.yaml > +++ b/Documentation/devicetree/bindings/sound/rockchip-i2s.yaml > @@ -61,6 +61,13 @@ properties: > - const: tx > - const: rx > > + pinctrl-names: > + oneOf: > + - const: default > + - items: I'm far from a YAML expert, but I think you have the indentation wrong? You want the "const: default" and the "items:" schema to be on the same level of indentation, right? If you haven't already, you might run through the 'make dt_binding_check' process. Brian > + - const: bclk_on > + - const: bclk_off > + > power-domains: > maxItems: 1 > > -- > 2.36.1.476.g0c4daa206d-goog > _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BF212C43334 for ; Thu, 16 Jun 2022 20:40:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9dHhu5RAOQNM2CvA7Rd/sL4wyD7hdi9SCF/7j+lN/SI=; b=kVsxfWerV7h0E3 cp+1qpH7k61BsIaQGLbsLLfM+zCTYpXFSt5GhECEkemiF0UApK0KJZucezA7EOiLC2AOx+ech190C K1eoR8sbEaqc3wrAFTMkPQ4V2ALNtmMugousljv7tVVwyg+oT4rRhCBotsvdMeDmvmBsuRs/Pxi7r vp2+J85xQYnQyCOpZKVFAka5Qg5Etd/jIdFNQSNEl/8LlclUdN6jW9I9a1w8px0AyRRTW7FKMm1bM XTE0PYKDBtVVGo7gDY3IYMil6mq+O9asaBDaSJBEnj8RJ9aRC/+jgQd/02L/kxwgWTNjcEZZQz/Kz BZj7vAfYaYQJbZBwex5w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o1wGy-004Bja-Ve; Thu, 16 Jun 2022 20:39:25 +0000 Received: from mail-pj1-x1034.google.com ([2607:f8b0:4864:20::1034]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o1wGv-004BhS-Fn for linux-arm-kernel@lists.infradead.org; Thu, 16 Jun 2022 20:39:22 +0000 Received: by mail-pj1-x1034.google.com with SMTP id o7-20020a17090a0a0700b001ebad897457so1367430pjo.0 for ; Thu, 16 Jun 2022 13:39:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=pkTlqBCv4kkUBzXfdE69AlbwDzWnDXPmq1X/ctwZ1RI=; b=ROZn+y/7o3WKT8p5stMPNJszpKJne4D3/Za9voE4D9qs7VwnFgZTseD6+HxsBnKHov rlTxbyYs4W0Iquvo4qHE70ivqOFlD9BOvwBoC+2PAKOw5Li1rI5SuWzQIMoZoQdgMPQQ xeKSWDr237Bfr3p2GiCiYStFm/NkPc/o4cp4Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=pkTlqBCv4kkUBzXfdE69AlbwDzWnDXPmq1X/ctwZ1RI=; b=sKG+JTyxhw1h/J7I84zXL7NYGpodBAZY7x6rvURLjpN1fvRE0FDWouhZh5bVCZmrsp pazbXLKJiwQ98z+FrhALSltdUhEuT/Eq0i1JlRrK+iIgoCbq5ZWunPOTAHgI7BBscflB zWsu60NenfEJes7cHAyVPIA2zNkFMagvCHaiO/YK7EVeUAFZyDuX25yMKYy/hLtQj4Jl iiRGj6rgI9zbpQT4fA1HJ4ceZpKuRU2LcilFEcFd+NE8yZYPWJUQ6MHGpEoZG6C8vep+ rMJxDcyiD79u+i6SrgMeKCZJ6h9C//Bg/Go1lmz1kJsmWOv5+LBPRp49OBL4KURCTo3u Svrw== X-Gm-Message-State: AJIora90VyTc3aspBUK5v/vYr1iPYb6rP6yz4nYz7XV1y/ICUUdYXcD6 v0ExVdXNuILOctDjP/uRGwGejg== X-Google-Smtp-Source: AGRyM1uRzdYi2h3WMgzsyG09F2s9/Uo4CiVLNg4n/tohSEwV59gL8BG6VgxVEBMNWkC3PEFczoXGPA== X-Received: by 2002:a17:902:a609:b0:169:a8b:7c3c with SMTP id u9-20020a170902a60900b001690a8b7c3cmr3281133plq.67.1655411957916; Thu, 16 Jun 2022 13:39:17 -0700 (PDT) Received: from google.com ([2620:15c:202:201:4709:a407:1ca6:24ea]) by smtp.gmail.com with ESMTPSA id jh17-20020a170903329100b00168b9093a06sm2038204plb.243.2022.06.16.13.39.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jun 2022 13:39:16 -0700 (PDT) Date: Thu, 16 Jun 2022 13:39:14 -0700 From: Brian Norris To: Judy Hsiao Cc: Heiko Stuebner , Liam Girdwood , Rob Herring , Mark Brown , Jaroslav Kysela , Chen-Yu Tsai , alsa-devel@alsa-project.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/3] ASoC: dt-bindings: rockchip: Document pinctrl-names for i2s Message-ID: References: <20220616155836.3401420-1-judyhsiao@chromium.org> <20220616155836.3401420-4-judyhsiao@chromium.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220616155836.3401420-4-judyhsiao@chromium.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220616_133921_604202_11660163 X-CRM114-Status: GOOD ( 17.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jun 16, 2022 at 03:58:36PM +0000, Judy Hsiao wrote: > This patch documents pinctrl-names for i2s. > > Signed-off-by: Judy Hsiao > --- > Documentation/devicetree/bindings/sound/rockchip-i2s.yaml | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/sound/rockchip-i2s.yaml b/Documentation/devicetree/bindings/sound/rockchip-i2s.yaml > index 5ea16b8ef93f..af1069278623 100644 > --- a/Documentation/devicetree/bindings/sound/rockchip-i2s.yaml > +++ b/Documentation/devicetree/bindings/sound/rockchip-i2s.yaml > @@ -61,6 +61,13 @@ properties: > - const: tx > - const: rx > > + pinctrl-names: > + oneOf: > + - const: default > + - items: I'm far from a YAML expert, but I think you have the indentation wrong? You want the "const: default" and the "items:" schema to be on the same level of indentation, right? If you haven't already, you might run through the 'make dt_binding_check' process. Brian > + - const: bclk_on > + - const: bclk_off > + > power-domains: > maxItems: 1 > > -- > 2.36.1.476.g0c4daa206d-goog > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 607FDC43334 for ; Thu, 16 Jun 2022 20:39:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378223AbiFPUjW (ORCPT ); Thu, 16 Jun 2022 16:39:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53778 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1378465AbiFPUjT (ORCPT ); Thu, 16 Jun 2022 16:39:19 -0400 Received: from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com [IPv6:2607:f8b0:4864:20::1029]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6DB3F5DD12 for ; Thu, 16 Jun 2022 13:39:18 -0700 (PDT) Received: by mail-pj1-x1029.google.com with SMTP id g10-20020a17090a708a00b001ea8aadd42bso2501911pjk.0 for ; Thu, 16 Jun 2022 13:39:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=pkTlqBCv4kkUBzXfdE69AlbwDzWnDXPmq1X/ctwZ1RI=; b=ROZn+y/7o3WKT8p5stMPNJszpKJne4D3/Za9voE4D9qs7VwnFgZTseD6+HxsBnKHov rlTxbyYs4W0Iquvo4qHE70ivqOFlD9BOvwBoC+2PAKOw5Li1rI5SuWzQIMoZoQdgMPQQ xeKSWDr237Bfr3p2GiCiYStFm/NkPc/o4cp4Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=pkTlqBCv4kkUBzXfdE69AlbwDzWnDXPmq1X/ctwZ1RI=; b=leVyaMbJjB6Z/0k/Hhkffu0Qit4JNU3yVMXY17tmQyj74KIpDs+uQ2fi6nsdifhcod gUmDu81XJnlzh9ISeZ0nI/yXzZmww+ZO7r2gmqrMR88jEnCnT+hpTEXDRmU+nQPDr6vQ 1D/1ypt9WFOjnUq+20U10xGF2d9XW8XGRmp4n021SI5w1l+xru3FvWGjrqkAG5JohsW4 YE5uqkfAmtGF7mUIMEQiLj2JNZ/0lRa0ZhJ6T/WQgBav6KzbFxJMd6atFKTpiwCVamQ/ oisT5jRvfU57mWg5tvBYSjfRgQyWMYsC7VvTrRF89ArR2sXmooohTM43OTdy5VJXoIOO /rDg== X-Gm-Message-State: AJIora+yzE2ykYX7fOEGhEv1u0cdoGWWda7/WFNeohN24vhHBnadN9As tWqQOgyZinUZLQw4gKHBl/QrFQ== X-Google-Smtp-Source: AGRyM1uRzdYi2h3WMgzsyG09F2s9/Uo4CiVLNg4n/tohSEwV59gL8BG6VgxVEBMNWkC3PEFczoXGPA== X-Received: by 2002:a17:902:a609:b0:169:a8b:7c3c with SMTP id u9-20020a170902a60900b001690a8b7c3cmr3281133plq.67.1655411957916; Thu, 16 Jun 2022 13:39:17 -0700 (PDT) Received: from google.com ([2620:15c:202:201:4709:a407:1ca6:24ea]) by smtp.gmail.com with ESMTPSA id jh17-20020a170903329100b00168b9093a06sm2038204plb.243.2022.06.16.13.39.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jun 2022 13:39:16 -0700 (PDT) Date: Thu, 16 Jun 2022 13:39:14 -0700 From: Brian Norris To: Judy Hsiao Cc: Heiko Stuebner , Liam Girdwood , Rob Herring , Mark Brown , Jaroslav Kysela , Chen-Yu Tsai , alsa-devel@alsa-project.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/3] ASoC: dt-bindings: rockchip: Document pinctrl-names for i2s Message-ID: References: <20220616155836.3401420-1-judyhsiao@chromium.org> <20220616155836.3401420-4-judyhsiao@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220616155836.3401420-4-judyhsiao@chromium.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 16, 2022 at 03:58:36PM +0000, Judy Hsiao wrote: > This patch documents pinctrl-names for i2s. > > Signed-off-by: Judy Hsiao > --- > Documentation/devicetree/bindings/sound/rockchip-i2s.yaml | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/sound/rockchip-i2s.yaml b/Documentation/devicetree/bindings/sound/rockchip-i2s.yaml > index 5ea16b8ef93f..af1069278623 100644 > --- a/Documentation/devicetree/bindings/sound/rockchip-i2s.yaml > +++ b/Documentation/devicetree/bindings/sound/rockchip-i2s.yaml > @@ -61,6 +61,13 @@ properties: > - const: tx > - const: rx > > + pinctrl-names: > + oneOf: > + - const: default > + - items: I'm far from a YAML expert, but I think you have the indentation wrong? You want the "const: default" and the "items:" schema to be on the same level of indentation, right? If you haven't already, you might run through the 'make dt_binding_check' process. Brian > + - const: bclk_on > + - const: bclk_off > + > power-domains: > maxItems: 1 > > -- > 2.36.1.476.g0c4daa206d-goog >