From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Sibi Sankar <quic_sibis@quicinc.com>
Cc: dmitry.baryshkov@linaro.org, agross@kernel.org,
mathieu.poirier@linaro.org, linux-arm-msm@vger.kernel.org,
linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] remoteproc: qcom: pas: Add decrypt shutdown support for modem
Date: Thu, 30 Jun 2022 14:29:27 -0500 [thread overview]
Message-ID: <Yr35lyyX+u76m/Tu@builder.lan> (raw)
In-Reply-To: <1653031684-14771-1-git-send-email-quic_sibis@quicinc.com>
On Fri 20 May 02:28 CDT 2022, Sibi Sankar wrote:
> +static int adsp_decrypt_shutdown(struct qcom_adsp *adsp)
Forgot to write down one comment, how about naming this
adsp_shutdown_poll_decrypt() to make it slightly more clear from the
name what's going on here?
Thanks,
Bjorn
> +{
> + int retry_num = 50;
> + int ret = -EINVAL;
> +
> + while (retry_num && ret) {
> + msleep(ADSP_DECRYPT_SHUTDOWN_DELAY_MS);
> + ret = qcom_scm_pas_shutdown(adsp->pas_id);
> + retry_num--;
> + }
> +
> + return ret;
> +}
> +
prev parent reply other threads:[~2022-06-30 19:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-20 7:28 [PATCH] remoteproc: qcom: pas: Add decrypt shutdown support for modem Sibi Sankar
2022-06-30 19:28 ` Bjorn Andersson
2022-07-05 11:53 ` Sibi Sankar
2022-06-30 19:29 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yr35lyyX+u76m/Tu@builder.lan \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=quic_sibis@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.