From: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
To: Magnus Karlsson <magnus.karlsson@gmail.com>
Cc: "Lukas Bulwahn" <lukas.bulwahn@gmail.com>,
"Andrii Nakryiko" <andrii@kernel.org>,
"Alexei Starovoitov" <ast@kernel.org>,
"Björn Töpel" <bjorn@kernel.org>,
"Magnus Karlsson" <magnus.karlsson@intel.com>,
"Network Development" <netdev@vger.kernel.org>,
bpf <bpf@vger.kernel.org>,
kernel-janitors@vger.kernel.org,
"open list" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] MAINTAINERS: adjust XDP SOCKETS after file movement
Date: Fri, 1 Jul 2022 15:52:49 +0200 [thread overview]
Message-ID: <Yr78Md1Nqpj+peO0@boxer> (raw)
In-Reply-To: <CAJ8uoz16yGJqYX2xOcczTGKFnG4joh8+f1uPGMAP4rmm3feYDQ@mail.gmail.com>
On Fri, Jul 01, 2022 at 03:13:36PM +0200, Magnus Karlsson wrote:
> On Fri, Jul 1, 2022 at 2:38 PM Maciej Fijalkowski
> <maciej.fijalkowski@intel.com> wrote:
> >
> > On Fri, Jul 01, 2022 at 06:28:10AM +0200, Lukas Bulwahn wrote:
> > > Commit f36600634282 ("libbpf: move xsk.{c,h} into selftests/bpf") moves
> > > files tools/{lib => testing/selftests}/bpf/xsk.[ch], but misses to adjust
> > > the XDP SOCKETS (AF_XDP) section in MAINTAINERS.
> > >
> > > Adjust the file entry after this file movement.
> > >
> > > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> > > ---
> > > Andrii, please ack.
> > >
> > > Alexei, please pick this minor non-urgent clean-up on top of the commit above.
> > >
> > > MAINTAINERS | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > index fa4bfa3d10bf..27d9e65b9a85 100644
> > > --- a/MAINTAINERS
> > > +++ b/MAINTAINERS
> > > @@ -22042,7 +22042,7 @@ F: include/uapi/linux/xdp_diag.h
> > > F: include/net/netns/xdp.h
> > > F: net/xdp/
> > > F: samples/bpf/xdpsock*
> > > -F: tools/lib/bpf/xsk*
> > > +F: tools/testing/selftests/bpf/xsk*
> >
> > Magnus, this doesn't cover xdpxceiver.
> > How about we move the lib part and xdpxceiver part to a dedicated
> > directory? Or would it be too nested from main dir POV?
>
> Or we can just call everything we add xsk* something?
No strong feelings. test_xsk.sh probably also needs to be addressed.
That's why I proposed dedicated dir.
>
> > >
> > > XEN BLOCK SUBSYSTEM
> > > M: Roger Pau Monné <roger.pau@citrix.com>
> > > --
> > > 2.17.1
> > >
next prev parent reply other threads:[~2022-07-01 13:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-01 4:28 [PATCH] MAINTAINERS: adjust XDP SOCKETS after file movement Lukas Bulwahn
2022-07-01 12:20 ` Maciej Fijalkowski
2022-07-01 13:13 ` Magnus Karlsson
2022-07-01 13:52 ` Maciej Fijalkowski [this message]
2022-07-05 12:01 ` Daniel Borkmann
2022-07-05 12:27 ` Maciej Fijalkowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yr78Md1Nqpj+peO0@boxer \
--to=maciej.fijalkowski@intel.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bjorn@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=magnus.karlsson@gmail.com \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.