From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 18F74C433EF for ; Fri, 1 Jul 2022 16:53:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7+hBTqXrfXCMV1rM+Tx3TpT1y5riUV1ptKuBVCPi49E=; b=b38zBvMjmG7qCW JcJtj+vMAA1FBmaV8SbiMl7iZF7DLq5EkQxfjC82SKfKiTGVEiivJR//vb93rkr/9Sfww+LwT08ai O+IB46Ivwz13657J3nnEzetWkHcZBBDbOji1VoNvmsMwsZ1/6+1mEQdlhW8DWqqjz6qP2kGTUNPtj 1mU+y5SUhiBg3cMpw4mWAQiKeiimlK6pY8bvYkraXt814ke0EqxHXF/Az4sE4lP4M19x8TdXwkf6U m26tQvsms8P6VFhROk2xPsMNpEPSS/X3m8jULNFoyCx21MDFUNps314A3lf8na+WSWXkm6FspCrq+ FiX5enIIb2nwDKnlQpJA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o7JsY-0066Un-Nr; Fri, 01 Jul 2022 16:52:26 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o7JsR-0066SK-3U for linux-arm-kernel@lists.infradead.org; Fri, 01 Jul 2022 16:52:24 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B8B61625F1; Fri, 1 Jul 2022 16:52:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B3C2EC341C7; Fri, 1 Jul 2022 16:52:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1656694337; bh=6OactPBHIuIvcRfwvl3VE1bL+DJCL/krYJF3tLZoebI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LCVg8pYO5wkSe1vpbel9rO1skNXGT9bVjJ2wDdH9jo61swL4UlsfLH4z0nx93eqc3 P9ZgNQ13gfYN1RgTgs9PSnwj92VF2SV3+8sAtZzgkKudeR+kZDqnjp8LjFG+TnhKt+ HB/BJSFsMuiD1I/qodudY3i9eWoOXZ4TeuI5+mUokOW7+WyC2/9qd3aNZBulD+XeX2 MkemKvfgWCTvYfjC/EgLPxVVVMgqkU67Zb12VxsXeroNhBMp6LqOi9iT1jq9B16ybX vNsXpUJy9lr7dXqGBpstSKYoHtRIBx4Jla4UbTrCBP9t5uejswUwFc5gykYM392pAx cBeJmzPvhU3lw== Date: Fri, 1 Jul 2022 19:51:58 +0300 From: Mike Rapoport To: "guanghui.fgh" Cc: baolin.wang@linux.alibaba.com, catalin.marinas@arm.com, will@kernel.org, akpm@linux-foundation.org, david@redhat.com, jianyong.wu@arm.com, james.morse@arm.com, quic_qiancai@quicinc.com, christophe.leroy@csgroup.eu, jonathan@marek.ca, mark.rutland@arm.com, thunder.leizhen@huawei.com, anshuman.khandual@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, geert+renesas@glider.be, ardb@kernel.org, linux-mm@kvack.org, yaohongbo@linux.alibaba.com, alikernel-developer@linux.alibaba.com Subject: Re: [PATCH v3] arm64: mm: fix linear mapping mem access performance degradation Message-ID: References: <1656586222-98555-1-git-send-email-guanghuifeng@linux.alibaba.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220701_095219_296268_4C950732 X-CRM114-Status: GOOD ( 40.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gRnJpLCBKdWwgMDEsIDIwMjIgYXQgMTI6MzY6MDBQTSArMDgwMCwgZ3VhbmdodWkuZmdoIHdy b3RlOgo+IFRoYW5rcy4KPiAKPiDlnKggMjAyMi82LzMwIDIxOjQ2LCBNaWtlIFJhcG9wb3J0IOWG memBkzoKPiA+IEhpLAo+ID4gCj4gPiBPbiBUaHUsIEp1biAzMCwgMjAyMiBhdCAwNjo1MDoyMlBN ICswODAwLCBHdWFuZ2h1aSBGZW5nIHdyb3RlOgo+ID4gPiBUaGUgYXJtNjQgY2FuIGJ1aWxkIDJN LzFHIGJsb2NrL3NlY3RpaW9uIG1hcHBpbmcuIFdoZW4gdXNpbmcgRE1BL0RNQTMyIHpvbmUKPiA+ ID4gKGVuYWJsZSBjcmFzaGtlcm5lbCwgZGlzYWJsZSByb2RhdGEgZnVsbCwgZGlzYWJsZSBrZmVu Y2UpLCB0aGUgbWVtX21hcCB3aWxsCj4gPiA+IHVzZSBub24gYmxvY2svc2VjdGlvbiBtYXBwaW5n KGZvciBjcmFzaGtlcm5lbCByZXF1aXJlcyB0byBzaHJpbmsgdGhlIHJlZ2lvbgo+ID4gPiBpbiBw YWdlIGdyYW51bGFyaXR5KS4gQnV0IGl0IHdpbGwgZGVncmFkZSBwZXJmb3JtYW5jZSB3aGVuIGRv aW5nIGxhcmdpbmcKPiA+ID4gY29udGludW91cyBtZW0gYWNjZXNzIGluIGtlcm5lbChtZW1jcHkv bWVtbW92ZSwgZXRjKS4KPiA+ID4gCj4gPiA+IFRoZXJlIGFyZSBtYW55IGNoYW5nZXMgYW5kIGRp c2N1c3Npb25zOgo+ID4gPiBjb21taXQgMDMxNDk1NjM1YjQ2ICgiYXJtNjQ6IERvIG5vdCBkZWZl ciByZXNlcnZlX2NyYXNoa2VybmVsKCkgZm9yCj4gPiA+IHBsYXRmb3JtcyB3aXRoIG5vIERNQSBt ZW1vcnkgem9uZXMiKQo+ID4gPiBjb21taXQgMGEzMGM1MzU3M2IwICgiYXJtNjQ6IG1tOiBNb3Zl IHJlc2VydmVfY3Jhc2hrZXJuZWwoKSBpbnRvCj4gPiA+IG1lbV9pbml0KCkiKQo+ID4gPiBjb21t aXQgMjY4NzI3NWE1ODQzICgiYXJtNjQ6IEZvcmNlIE5PX0JMT0NLX01BUFBJTkdTIGlmIGNyYXNo a2VybmVsCj4gPiA+IHJlc2VydmF0aW9uIGlzIHJlcXVpcmVkIikKPiA+ID4gCj4gPiA+IFRoaXMg cGF0Y2ggY2hhbmdlcyBtZW1fbWFwIHRvIHVzZSBibG9jay9zZWN0aW9uIG1hcHBpbmcgd2l0aCBj cmFzaGtlcm5lbC4KPiA+ID4gRmlyc3RseSwgZG8gYmxvY2svc2VjdGlvbiBtYXBwaW5nKG5vcm1h bGx5IDJNIG9yIDFHKSBmb3IgYWxsIGF2YWlsIG1lbSBhdAo+ID4gPiBtZW1fbWFwLCByZXNlcnZl IGNyYXNoa2VybmVsIG1lbW9yeS4gQW5kIHRoZW4gd2Fsa2luZyBwYWdldGFibGUgdG8gc3BsaXQK PiA+ID4gYmxvY2svc2VjdGlvbiBtYXBwaW5nIHRvIG5vbiBibG9jay9zZWN0aW9uIG1hcHBpbmco bm9ybWFsbHkgNEspIFtbW29ubHldXV0KPiA+ID4gZm9yIGNyYXNoa2VybmVsIG1lbS4gU28gdGhl IGxpbmVhciBtZW0gbWFwcGluZyB1c2UgYmxvY2svc2VjdGlvbiBtYXBwaW5nCj4gPiA+IGFzIG1v cmUgYXMgcG9zc2libGUuIFdlIHdpbGwgcmVkdWNlIHRoZSBjcHUgZFRMQiBtaXNzIGNvbnNwaWN1 b3VzbHksIGFuZAo+ID4gPiBhY2NlbGVyYXRlIG1lbSBhY2Nlc3MgYWJvdXQgMTAtMjAlIHBlcmZv cm1hbmNlIGltcHJvdmVtZW50Lgo+ID4gCj4gPiAuLi4KPiA+ID4gU2lnbmVkLW9mZi1ieTogR3Vh bmdodWkgRmVuZyA8Z3VhbmdodWlmZW5nQGxpbnV4LmFsaWJhYmEuY29tPgo+ID4gPiAtLS0KPiA+ ID4gICBhcmNoL2FybTY0L2luY2x1ZGUvYXNtL21tdS5oIHwgICAxICsKPiA+ID4gICBhcmNoL2Fy bTY0L21tL2luaXQuYyAgICAgICAgIHwgICA4ICstCj4gPiA+ICAgYXJjaC9hcm02NC9tbS9tbXUu YyAgICAgICAgICB8IDIzMSArKysrKysrKysrKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0t LS0tCj4gPiA+ICAgMyBmaWxlcyBjaGFuZ2VkLCAxNjggaW5zZXJ0aW9ucygrKSwgNzIgZGVsZXRp b25zKC0pCj4gPiAKPiA+IC4uLgo+ID4gCj4gPiA+IGRpZmYgLS1naXQgYS9hcmNoL2FybTY0L21t L21tdS5jIGIvYXJjaC9hcm02NC9tbS9tbXUuYwo+ID4gPiBpbmRleCA2MjZlYzMyLi40Yjc3OWNm IDEwMDY0NAo+ID4gPiAtLS0gYS9hcmNoL2FybTY0L21tL21tdS5jCj4gPiA+ICsrKyBiL2FyY2gv YXJtNjQvbW0vbW11LmMKPiA+ID4gQEAgLTQyLDYgKzQyLDcgQEAKPiA+ID4gICAjZGVmaW5lIE5P X0JMT0NLX01BUFBJTkdTCUJJVCgwKQo+ID4gPiAgICNkZWZpbmUgTk9fQ09OVF9NQVBQSU5HUwlC SVQoMSkKPiA+ID4gICAjZGVmaW5lIE5PX0VYRUNfTUFQUElOR1MJQklUKDIpCS8qIGFzc3VtZXMg RkVBVF9IUERTIGlzIG5vdCB1c2VkICovCj4gPiA+ICsjZGVmaW5lIE5PX1NFQ19SRU1BUFBJTkdT CUJJVCgzKQkvKiByZWJ1aWxkIHdpdGggbm9uIGJsb2NrL3NlYyBtYXBwaW5nKi8KPiA+ID4gICB1 NjQgaWRtYXBfdDBzeiA9IFRDUl9UMFNaKFZBX0JJVFNfTUlOKTsKPiA+ID4gICB1NjQgaWRtYXBf cHRyc19wZXJfcGdkID0gUFRSU19QRVJfUEdEOwo+ID4gPiBAQCAtMTU2LDExICsxNTcsMTIgQEAg c3RhdGljIGJvb2wgcGdhdHRyX2NoYW5nZV9pc19zYWZlKHU2NCBvbGQsIHU2NCBuZXcpCj4gPiA+ ICAgfQo+ID4gPiAgIHN0YXRpYyB2b2lkIGluaXRfcHRlKHBtZF90ICpwbWRwLCB1bnNpZ25lZCBs b25nIGFkZHIsIHVuc2lnbmVkIGxvbmcgZW5kLAo+ID4gPiAtCQkgICAgIHBoeXNfYWRkcl90IHBo eXMsIHBncHJvdF90IHByb3QpCj4gPiA+ICsJCSAgICAgcGh5c19hZGRyX3QgcGh5cywgcGdwcm90 X3QgcHJvdCwgaW50IGZsYWdzKQo+ID4gPiAgIHsKPiA+ID4gICAJcHRlX3QgKnB0ZXA7Cj4gPiA+ IC0JcHRlcCA9IHB0ZV9zZXRfZml4bWFwX29mZnNldChwbWRwLCBhZGRyKTsKPiA+ID4gKwlwdGVw ID0gKGZsYWdzICYgTk9fU0VDX1JFTUFQUElOR1MpID8gcHRlX29mZnNldF9rZXJuZWwocG1kcCwg YWRkcikgOgo+ID4gPiArCQlwdGVfc2V0X2ZpeG1hcF9vZmZzZXQocG1kcCwgYWRkcik7Cj4gPiA+ ICAgCWRvIHsKPiA+ID4gICAJCXB0ZV90IG9sZF9wdGUgPSBSRUFEX09OQ0UoKnB0ZXApOwo+ID4g PiBAQCAtMTc2LDcgKzE3OCw4IEBAIHN0YXRpYyB2b2lkIGluaXRfcHRlKHBtZF90ICpwbWRwLCB1 bnNpZ25lZCBsb25nIGFkZHIsIHVuc2lnbmVkIGxvbmcgZW5kLAo+ID4gPiAgIAkJcGh5cyArPSBQ QUdFX1NJWkU7Cj4gPiA+ICAgCX0gd2hpbGUgKHB0ZXArKywgYWRkciArPSBQQUdFX1NJWkUsIGFk ZHIgIT0gZW5kKTsKPiA+ID4gLQlwdGVfY2xlYXJfZml4bWFwKCk7Cj4gPiA+ICsJaWYgKCEoZmxh Z3MgJiBOT19TRUNfUkVNQVBQSU5HUykpCj4gPiA+ICsJCXB0ZV9jbGVhcl9maXhtYXAoKTsKPiA+ ID4gICB9Cj4gPiA+ICAgc3RhdGljIHZvaWQgYWxsb2NfaW5pdF9jb250X3B0ZShwbWRfdCAqcG1k cCwgdW5zaWduZWQgbG9uZyBhZGRyLAo+ID4gPiBAQCAtMjA4LDE2ICsyMTEsNTkgQEAgc3RhdGlj IHZvaWQgYWxsb2NfaW5pdF9jb250X3B0ZShwbWRfdCAqcG1kcCwgdW5zaWduZWQgbG9uZyBhZGRy LAo+ID4gPiAgIAkJbmV4dCA9IHB0ZV9jb250X2FkZHJfZW5kKGFkZHIsIGVuZCk7Cj4gPiA+ICAg CQkvKiB1c2UgYSBjb250aWd1b3VzIG1hcHBpbmcgaWYgdGhlIHJhbmdlIGlzIHN1aXRhYmx5IGFs aWduZWQgKi8KPiA+ID4gLQkJaWYgKCgoKGFkZHIgfCBuZXh0IHwgcGh5cykgJiB+Q09OVF9QVEVf TUFTSykgPT0gMCkgJiYKPiA+ID4gKwkJaWYgKCEoZmxhZ3MgJiBOT19TRUNfUkVNQVBQSU5HUykg JiYKPiA+ID4gKwkJICAgKCgoYWRkciB8IG5leHQgfCBwaHlzKSAmIH5DT05UX1BURV9NQVNLKSA9 PSAwKSAmJgo+ID4gPiAgIAkJICAgIChmbGFncyAmIE5PX0NPTlRfTUFQUElOR1MpID09IDApCj4g PiA+ICAgCQkJX19wcm90ID0gX19wZ3Byb3QocGdwcm90X3ZhbChwcm90KSB8IFBURV9DT05UKTsK PiA+ID4gLQkJaW5pdF9wdGUocG1kcCwgYWRkciwgbmV4dCwgcGh5cywgX19wcm90KTsKPiA+ID4g KwkJaW5pdF9wdGUocG1kcCwgYWRkciwgbmV4dCwgcGh5cywgX19wcm90LCBmbGFncyk7Cj4gPiA+ ICAgCQlwaHlzICs9IG5leHQgLSBhZGRyOwo+ID4gPiAgIAl9IHdoaWxlIChhZGRyID0gbmV4dCwg YWRkciAhPSBlbmQpOwo+ID4gPiAgIH0KPiA+ID4gK3N0YXRpYyB2b2lkIGluaXRfcG1kX3JlbWFw KHB1ZF90ICpwdWRwLCB1bnNpZ25lZCBsb25nIGFkZHIsIHVuc2lnbmVkIGxvbmcgZW5kLAo+ID4g PiArCQkJICAgcGh5c19hZGRyX3QgcGh5cywgcGdwcm90X3QgcHJvdCwKPiA+ID4gKwkJCSAgIHBo eXNfYWRkcl90ICgqcGd0YWJsZV9hbGxvYykoaW50KSwgaW50IGZsYWdzKQo+ID4gPiArewo+ID4g PiArCXVuc2lnbmVkIGxvbmcgbmV4dDsKPiA+ID4gKwlwbWRfdCAqcG1kcDsKPiA+ID4gKwlwaHlz X2FkZHJfdCBtYXBfb2Zmc2V0Owo+ID4gPiArCXBtZHZhbF90IHBtZHZhbDsKPiA+ID4gKwo+ID4g PiArCXBtZHAgPSBwbWRfb2Zmc2V0KHB1ZHAsIGFkZHIpOwo+ID4gPiArCWRvIHsKPiA+ID4gKwkJ bmV4dCA9IHBtZF9hZGRyX2VuZChhZGRyLCBlbmQpOwo+ID4gPiArCj4gPiA+ICsJCWlmICghcG1k X25vbmUoKnBtZHApICYmIHBtZF9zZWN0KCpwbWRwKSkgewo+ID4gPiArCQkJcGh5c19hZGRyX3Qg cHRlX3BoeXMgPSBwZ3RhYmxlX2FsbG9jKFBBR0VfU0hJRlQpOwo+ID4gPiArCQkJcG1kX2NsZWFy KHBtZHApOwo+ID4gPiArCQkJcG1kdmFsID0gUE1EX1RZUEVfVEFCTEUgfCBQTURfVEFCTEVfVVhO Owo+ID4gPiArCQkJaWYgKGZsYWdzICYgTk9fRVhFQ19NQVBQSU5HUykKPiA+ID4gKwkJCQlwbWR2 YWwgfD0gUE1EX1RBQkxFX1BYTjsKPiA+ID4gKwkJCV9fcG1kX3BvcHVsYXRlKHBtZHAsIHB0ZV9w aHlzLCBwbWR2YWwpOwo+ID4gPiArCQkJZmx1c2hfdGxiX2tlcm5lbF9yYW5nZShhZGRyLCBhZGRy ICsgUEFHRV9TSVpFKTsKPiA+ID4gKwo+ID4gPiArCQkJbWFwX29mZnNldCA9IGFkZHIgLSAoYWRk ciAmIFBNRF9NQVNLKTsKPiA+ID4gKwkJCWlmIChtYXBfb2Zmc2V0KQo+ID4gPiArCQkJICAgIGFs bG9jX2luaXRfY29udF9wdGUocG1kcCwgYWRkciAmIFBNRF9NQVNLLCBhZGRyLAo+ID4gPiArCQkJ CQkJcGh5cyAtIG1hcF9vZmZzZXQsIHByb3QsCj4gPiA+ICsJCQkJCQlwZ3RhYmxlX2FsbG9jLAo+ ID4gPiArCQkJCQkJZmxhZ3MgJiAofk5PX1NFQ19SRU1BUFBJTkdTKSk7Cj4gPiA+ICsKPiA+ID4g KwkJCWlmIChuZXh0IDwgKGFkZHIgJiBQTURfTUFTSykgKyBQTURfU0laRSkKPiA+ID4gKwkJCSAg ICBhbGxvY19pbml0X2NvbnRfcHRlKHBtZHAsIG5leHQsCj4gPiA+ICsJCQkJCSAgICAgICAoYWRk ciAmIFBVRF9NQVNLKSArIFBVRF9TSVpFLAo+ID4gPiArCQkJCQkgICAgICAgIG5leHQgLSBhZGRy ICsgcGh5cywKPiA+ID4gKwkJCQkJCXByb3QsIHBndGFibGVfYWxsb2MsCj4gPiA+ICsJCQkJCQlm bGFncyAmICh+Tk9fU0VDX1JFTUFQUElOR1MpKTsKPiA+ID4gKwkJfQo+ID4gPiArCQlhbGxvY19p bml0X2NvbnRfcHRlKHBtZHAsIGFkZHIsIG5leHQsIHBoeXMsIHByb3QsCj4gPiA+ICsJCQkJICAg IHBndGFibGVfYWxsb2MsIGZsYWdzKTsKPiA+ID4gKwkJcGh5cyArPSBuZXh0IC0gYWRkcjsKPiA+ ID4gKwl9IHdoaWxlIChwbWRwKyssIGFkZHIgPSBuZXh0LCBhZGRyICE9IGVuZCk7Cj4gPiA+ICt9 Cj4gPiAKPiA+IFRoZXJlIGlzIHN0aWxsIHRvIG11Y2ggZHVwbGljYXRlZCBjb2RlIGhlcmUgYW5k IGluIGluaXRfcHVkX3JlbWFwKCkuCj4gPiAKPiA+IERpZCB5b3UgY29uc2lkZXIgc29tZXRoaW5n IGxpa2UgdGhpczoKPiA+IAo+ID4gdm9pZCBfX2luaXQgbWFwX2NyYXNoa2VybmVsKHZvaWQpCj4g PiB7Cj4gPiAJaW50IGZsYWdzID0gTk9fRVhFQ19NQVBQSU5HUyB8IE5PX0JMT0NLX01BUFBJTkdT IHwgTk9fQ09OVF9NQVBQSU5HUzsKPiA+IAl1NjQgc2l6ZTsKPiA+IAo+ID4gCS8qCj4gPiAJICog Y2hlY2sgaWYgY3Jhc2gga2VybmVsIHN1cHBvcnRlZCwgcmVzZXJ2ZWQgZXRjCj4gPiAJICovCj4g PiAKPiA+IAo+ID4gCXNpemUgPSBjcmFzaGtfcmVzLmVuZCArIDEgLSBjcmFzaGtfcmVzLnN0YXJ0 Owo+ID4gCj4gPiAJX19yZW1vdmVfcGdkX21hcHBpbmcoc3dhcHBlcl9wZ19kaXIsIF9fcGh5c190 b192aXJ0KHN0YXJ0KSwgc2l6ZSk7Cj4gPiAJX19jcmVhdGVfcGdkX21hcHBpbmcoc3dhcHBlcl9w Z19kaXIsIGNyYXNoa19yZXMuc3RhcnQsCj4gPiAJCQkgICAgIF9fcGh5c190b192aXJ0KGNyYXNo a19yZXMuc3RhcnQpLCBzaXplLAo+ID4gCQkJICAgICBQQUdFX0tFUk5FTCwgZWFybHlfcGd0YWJs ZV9hbGxvYywgZmxhZ3MpOwo+ID4gfQo+ID4gCj4gSSdtIHRyeWluZyBkbyB0aGlzLgo+IEJ1dCBJ IHRoaW5rIGl0J3MgdGhlIEludmVyc2UgUHJvY2VzcyBvZiBtZW0gbWFwcGluZyBhbmQgYWxzbyBn ZW5lcmF0ZXMKPiBkdXBsaWNhdGVkIGNvZGUoQm91bmRhcnkganVkZ21lbnQsIHBhZ2V0YWJsZSBt b2RpZnkpLgo+IAo+IFdoZW4gcmVtb3ZpbmcgdGhlIHBnZCBtYXBwaW5nLCBpdCBtYXkgc3BsaXQg cHVkL3BtZCBzZWN0aW9uIHdoaWNoIGFsc28gbmVlZHMKPiBbW1tyZWJ1aWxkIGFuZCBjbGVhcl1d XSBzb21lIHBhZ2V0YWJsZS4KCldlbGwsIF9fcmVtb3ZlX3BnZF9tYXBwaW5nKCkgaXMgcHJvYmFi bHkgYW4gb3ZlcmtpbGwsIGJ1dAp1bm1hcF9ob3RwbHVnX3BtZF9yYW5nZSgpIGFuZCB1bm1hcF9o b3RwbHVnX3B1ZF9yYW5nZSgpIHNob3VsZCBkbywgZGVwZW5kaW5nCm9uIHRoZSBzaXplIG9mIHRo ZSBjcmFzaCBrZXJuZWwuCgotLSAKU2luY2VyZWx5IHlvdXJzLApNaWtlLgoKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWls aW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0 cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AAEC3C43334 for ; Fri, 1 Jul 2022 16:52:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 39B0E6B0073; Fri, 1 Jul 2022 12:52:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3247C6B0074; Fri, 1 Jul 2022 12:52:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1C5006B0075; Fri, 1 Jul 2022 12:52:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 080AC6B0073 for ; Fri, 1 Jul 2022 12:52:20 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id D50D9358ED for ; Fri, 1 Jul 2022 16:52:19 +0000 (UTC) X-FDA: 79639123998.21.61ACBB1 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf21.hostedemail.com (Postfix) with ESMTP id B760B1C003F for ; Fri, 1 Jul 2022 16:52:18 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B8B61625F1; Fri, 1 Jul 2022 16:52:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B3C2EC341C7; Fri, 1 Jul 2022 16:52:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1656694337; bh=6OactPBHIuIvcRfwvl3VE1bL+DJCL/krYJF3tLZoebI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LCVg8pYO5wkSe1vpbel9rO1skNXGT9bVjJ2wDdH9jo61swL4UlsfLH4z0nx93eqc3 P9ZgNQ13gfYN1RgTgs9PSnwj92VF2SV3+8sAtZzgkKudeR+kZDqnjp8LjFG+TnhKt+ HB/BJSFsMuiD1I/qodudY3i9eWoOXZ4TeuI5+mUokOW7+WyC2/9qd3aNZBulD+XeX2 MkemKvfgWCTvYfjC/EgLPxVVVMgqkU67Zb12VxsXeroNhBMp6LqOi9iT1jq9B16ybX vNsXpUJy9lr7dXqGBpstSKYoHtRIBx4Jla4UbTrCBP9t5uejswUwFc5gykYM392pAx cBeJmzPvhU3lw== Date: Fri, 1 Jul 2022 19:51:58 +0300 From: Mike Rapoport To: "guanghui.fgh" Cc: baolin.wang@linux.alibaba.com, catalin.marinas@arm.com, will@kernel.org, akpm@linux-foundation.org, david@redhat.com, jianyong.wu@arm.com, james.morse@arm.com, quic_qiancai@quicinc.com, christophe.leroy@csgroup.eu, jonathan@marek.ca, mark.rutland@arm.com, thunder.leizhen@huawei.com, anshuman.khandual@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, geert+renesas@glider.be, ardb@kernel.org, linux-mm@kvack.org, yaohongbo@linux.alibaba.com, alikernel-developer@linux.alibaba.com Subject: Re: [PATCH v3] arm64: mm: fix linear mapping mem access performance degradation Message-ID: References: <1656586222-98555-1-git-send-email-guanghuifeng@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656694338; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aOnEMSRcOoMmtU7wHRd04QjRoz4Wjl+98EKgzQatXYI=; b=kBFDv5iXDR+svZ/OxdsHpHj7auwNi+ghQnnGK8YnuJx/tLZjkqpgVxWjkRj2XXijGMvO1O 5Au/6CE0aHcjYmh7750k/v35TwHZqhcrtZfsMuptPeCxySWyngskh/+ia5hPz16s6KogZg gb33BfukFoCoal0Abdj5nBn4kPRSdLc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656694338; a=rsa-sha256; cv=none; b=zaFSXfp9mDSh4bK5VM4ze+NnX5/RWEfoF9jfhNJiKoiB+ZCv2ZHP2OGBA6w/lRne5EUQD+ mArHhe78+KrlJUjbDXNP2DltaxvJXswFxIGak8Kg3EVl87v6yhn6GlpUtG6OfDHn+paMKX MveMj+G/FBvSfL3+0RbHw48l2l3hD8Y= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=LCVg8pYO; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf21.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org X-Stat-Signature: b1yhgt1sgisjk5mpw1cbfu9178ci7cz6 X-Rspam-User: Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=LCVg8pYO; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf21.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: B760B1C003F X-HE-Tag: 1656694338-663529 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jul 01, 2022 at 12:36:00PM +0800, guanghui.fgh wrote: > Thanks. > > 在 2022/6/30 21:46, Mike Rapoport 写道: > > Hi, > > > > On Thu, Jun 30, 2022 at 06:50:22PM +0800, Guanghui Feng wrote: > > > The arm64 can build 2M/1G block/sectiion mapping. When using DMA/DMA32 zone > > > (enable crashkernel, disable rodata full, disable kfence), the mem_map will > > > use non block/section mapping(for crashkernel requires to shrink the region > > > in page granularity). But it will degrade performance when doing larging > > > continuous mem access in kernel(memcpy/memmove, etc). > > > > > > There are many changes and discussions: > > > commit 031495635b46 ("arm64: Do not defer reserve_crashkernel() for > > > platforms with no DMA memory zones") > > > commit 0a30c53573b0 ("arm64: mm: Move reserve_crashkernel() into > > > mem_init()") > > > commit 2687275a5843 ("arm64: Force NO_BLOCK_MAPPINGS if crashkernel > > > reservation is required") > > > > > > This patch changes mem_map to use block/section mapping with crashkernel. > > > Firstly, do block/section mapping(normally 2M or 1G) for all avail mem at > > > mem_map, reserve crashkernel memory. And then walking pagetable to split > > > block/section mapping to non block/section mapping(normally 4K) [[[only]]] > > > for crashkernel mem. So the linear mem mapping use block/section mapping > > > as more as possible. We will reduce the cpu dTLB miss conspicuously, and > > > accelerate mem access about 10-20% performance improvement. > > > > ... > > > Signed-off-by: Guanghui Feng > > > --- > > > arch/arm64/include/asm/mmu.h | 1 + > > > arch/arm64/mm/init.c | 8 +- > > > arch/arm64/mm/mmu.c | 231 ++++++++++++++++++++++++++++++------------- > > > 3 files changed, 168 insertions(+), 72 deletions(-) > > > > ... > > > > > diff --git a/arch/arm64/mm/mmu.c b/arch/arm64/mm/mmu.c > > > index 626ec32..4b779cf 100644 > > > --- a/arch/arm64/mm/mmu.c > > > +++ b/arch/arm64/mm/mmu.c > > > @@ -42,6 +42,7 @@ > > > #define NO_BLOCK_MAPPINGS BIT(0) > > > #define NO_CONT_MAPPINGS BIT(1) > > > #define NO_EXEC_MAPPINGS BIT(2) /* assumes FEAT_HPDS is not used */ > > > +#define NO_SEC_REMAPPINGS BIT(3) /* rebuild with non block/sec mapping*/ > > > u64 idmap_t0sz = TCR_T0SZ(VA_BITS_MIN); > > > u64 idmap_ptrs_per_pgd = PTRS_PER_PGD; > > > @@ -156,11 +157,12 @@ static bool pgattr_change_is_safe(u64 old, u64 new) > > > } > > > static void init_pte(pmd_t *pmdp, unsigned long addr, unsigned long end, > > > - phys_addr_t phys, pgprot_t prot) > > > + phys_addr_t phys, pgprot_t prot, int flags) > > > { > > > pte_t *ptep; > > > - ptep = pte_set_fixmap_offset(pmdp, addr); > > > + ptep = (flags & NO_SEC_REMAPPINGS) ? pte_offset_kernel(pmdp, addr) : > > > + pte_set_fixmap_offset(pmdp, addr); > > > do { > > > pte_t old_pte = READ_ONCE(*ptep); > > > @@ -176,7 +178,8 @@ static void init_pte(pmd_t *pmdp, unsigned long addr, unsigned long end, > > > phys += PAGE_SIZE; > > > } while (ptep++, addr += PAGE_SIZE, addr != end); > > > - pte_clear_fixmap(); > > > + if (!(flags & NO_SEC_REMAPPINGS)) > > > + pte_clear_fixmap(); > > > } > > > static void alloc_init_cont_pte(pmd_t *pmdp, unsigned long addr, > > > @@ -208,16 +211,59 @@ static void alloc_init_cont_pte(pmd_t *pmdp, unsigned long addr, > > > next = pte_cont_addr_end(addr, end); > > > /* use a contiguous mapping if the range is suitably aligned */ > > > - if ((((addr | next | phys) & ~CONT_PTE_MASK) == 0) && > > > + if (!(flags & NO_SEC_REMAPPINGS) && > > > + (((addr | next | phys) & ~CONT_PTE_MASK) == 0) && > > > (flags & NO_CONT_MAPPINGS) == 0) > > > __prot = __pgprot(pgprot_val(prot) | PTE_CONT); > > > - init_pte(pmdp, addr, next, phys, __prot); > > > + init_pte(pmdp, addr, next, phys, __prot, flags); > > > phys += next - addr; > > > } while (addr = next, addr != end); > > > } > > > +static void init_pmd_remap(pud_t *pudp, unsigned long addr, unsigned long end, > > > + phys_addr_t phys, pgprot_t prot, > > > + phys_addr_t (*pgtable_alloc)(int), int flags) > > > +{ > > > + unsigned long next; > > > + pmd_t *pmdp; > > > + phys_addr_t map_offset; > > > + pmdval_t pmdval; > > > + > > > + pmdp = pmd_offset(pudp, addr); > > > + do { > > > + next = pmd_addr_end(addr, end); > > > + > > > + if (!pmd_none(*pmdp) && pmd_sect(*pmdp)) { > > > + phys_addr_t pte_phys = pgtable_alloc(PAGE_SHIFT); > > > + pmd_clear(pmdp); > > > + pmdval = PMD_TYPE_TABLE | PMD_TABLE_UXN; > > > + if (flags & NO_EXEC_MAPPINGS) > > > + pmdval |= PMD_TABLE_PXN; > > > + __pmd_populate(pmdp, pte_phys, pmdval); > > > + flush_tlb_kernel_range(addr, addr + PAGE_SIZE); > > > + > > > + map_offset = addr - (addr & PMD_MASK); > > > + if (map_offset) > > > + alloc_init_cont_pte(pmdp, addr & PMD_MASK, addr, > > > + phys - map_offset, prot, > > > + pgtable_alloc, > > > + flags & (~NO_SEC_REMAPPINGS)); > > > + > > > + if (next < (addr & PMD_MASK) + PMD_SIZE) > > > + alloc_init_cont_pte(pmdp, next, > > > + (addr & PUD_MASK) + PUD_SIZE, > > > + next - addr + phys, > > > + prot, pgtable_alloc, > > > + flags & (~NO_SEC_REMAPPINGS)); > > > + } > > > + alloc_init_cont_pte(pmdp, addr, next, phys, prot, > > > + pgtable_alloc, flags); > > > + phys += next - addr; > > > + } while (pmdp++, addr = next, addr != end); > > > +} > > > > There is still to much duplicated code here and in init_pud_remap(). > > > > Did you consider something like this: > > > > void __init map_crashkernel(void) > > { > > int flags = NO_EXEC_MAPPINGS | NO_BLOCK_MAPPINGS | NO_CONT_MAPPINGS; > > u64 size; > > > > /* > > * check if crash kernel supported, reserved etc > > */ > > > > > > size = crashk_res.end + 1 - crashk_res.start; > > > > __remove_pgd_mapping(swapper_pg_dir, __phys_to_virt(start), size); > > __create_pgd_mapping(swapper_pg_dir, crashk_res.start, > > __phys_to_virt(crashk_res.start), size, > > PAGE_KERNEL, early_pgtable_alloc, flags); > > } > > > I'm trying do this. > But I think it's the Inverse Process of mem mapping and also generates > duplicated code(Boundary judgment, pagetable modify). > > When removing the pgd mapping, it may split pud/pmd section which also needs > [[[rebuild and clear]]] some pagetable. Well, __remove_pgd_mapping() is probably an overkill, but unmap_hotplug_pmd_range() and unmap_hotplug_pud_range() should do, depending on the size of the crash kernel. -- Sincerely yours, Mike.