All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Bill Wendling <morbo@google.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 12/12] netfilter: conntrack: use correct format characters
Date: Mon, 20 Jun 2022 16:44:06 +0200	[thread overview]
Message-ID: <YrCHtmZlK384yiCo@salvia> (raw)
In-Reply-To: <20220609221702.347522-13-morbo@google.com>

On Thu, Jun 09, 2022 at 10:16:31PM +0000, Bill Wendling wrote:
> From: Bill Wendling <isanbard@gmail.com>
> 
> When compiling with -Wformat, clang emits the following warnings:
> 
> net/netfilter/nf_conntrack_helper.c:168:18: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security]
>                 request_module(mod_name);
>                                ^~~~~~~~
> 
> Use a string literal for the format string.

Should I handle this through the netfilter tree? Or you prefer a
different path?

Thanks

  reply	other threads:[~2022-06-20 15:07 UTC|newest]

Thread overview: 67+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-09 22:16 [PATCH 00/12] Clang -Wformat warning fixes Bill Wendling
2022-06-09 22:16 ` Bill Wendling
2022-06-09 22:16 ` [PATCH 01/12] x86/mce: use correct format characters Bill Wendling
2022-06-09 22:16   ` Bill Wendling
2022-06-09 23:14   ` Randy Dunlap
2022-06-09 23:14     ` Randy Dunlap
2022-06-09 23:18     ` Bill Wendling
2022-06-09 23:18       ` Bill Wendling
2022-06-09 22:16 ` [PATCH 02/12] x86/CPU/AMD: " Bill Wendling
2022-06-09 22:16   ` Bill Wendling
2022-06-09 22:16 ` [PATCH 03/12] x86/e820: " Bill Wendling
2022-06-09 22:16   ` Bill Wendling
2022-06-09 22:16 ` [PATCH 04/12] blk-cgroup: " Bill Wendling
2022-06-09 22:16   ` Bill Wendling
2022-06-10  8:10   ` Christoph Hellwig
2022-06-10  8:10     ` Christoph Hellwig
2022-06-09 22:16 ` [PATCH 05/12] fs: quota: " Bill Wendling
2022-06-09 22:16   ` Bill Wendling
2022-06-09 22:16 ` [PATCH 06/12] PNP: " Bill Wendling
2022-06-09 22:16   ` Bill Wendling
2022-06-09 22:16 ` [PATCH 07/12] driver/char: " Bill Wendling
2022-06-09 22:16   ` Bill Wendling
2022-06-10  5:18   ` Greg Kroah-Hartman
2022-06-10  5:18     ` Greg Kroah-Hartman
2022-06-13 18:40     ` Bill Wendling
2022-06-13 18:40       ` Bill Wendling
2022-06-09 22:16 ` [PATCH 08/12] cdrom: " Bill Wendling
2022-06-09 22:16   ` Bill Wendling
2022-06-12 16:23   ` Phillip Potter
2022-06-12 16:23     ` Phillip Potter
2022-06-13 18:47     ` Bill Wendling
2022-06-13 18:47       ` Bill Wendling
2022-06-09 22:16 ` [PATCH 09/12] ALSA: seq: " Bill Wendling
2022-06-09 22:16   ` Bill Wendling
2022-06-09 22:16 ` [PATCH 10/12] " Bill Wendling
2022-06-09 22:16   ` Bill Wendling
2022-06-09 22:16 ` [PATCH 11/12] ALSA: control: " Bill Wendling
2022-06-09 22:16   ` Bill Wendling
2022-06-09 22:16 ` [PATCH 12/12] netfilter: conntrack: " Bill Wendling
2022-06-09 22:16   ` Bill Wendling
2022-06-20 14:44   ` Pablo Neira Ayuso [this message]
2022-07-11 14:35   ` Pablo Neira Ayuso
2022-07-11 14:35     ` Pablo Neira Ayuso
2022-06-09 22:25 ` [PATCH 00/12] Clang -Wformat warning fixes Andrew Morton
2022-06-09 22:25   ` Andrew Morton
2022-06-09 22:49   ` Bill Wendling
2022-06-09 22:49     ` Bill Wendling
2022-06-09 23:03     ` Jan Engelhardt
2022-06-09 23:03       ` Jan Engelhardt
2022-06-09 23:16       ` Bill Wendling
2022-06-09 23:16         ` Bill Wendling
2022-06-10  1:19         ` Andrew Morton
2022-06-10  1:19           ` Andrew Morton
2022-06-10  5:20         ` Greg Kroah-Hartman
2022-06-10  5:20           ` Greg Kroah-Hartman
2022-06-10 12:44           ` Joe Perches
2022-06-10 12:44             ` Joe Perches
2022-06-10  8:17     ` David Laight
2022-06-10  8:17       ` David Laight
2022-06-10  8:32       ` Jan Engelhardt
2022-06-10  8:32         ` Jan Engelhardt
2022-06-10  9:14         ` David Laight
2022-06-10  9:14           ` David Laight
2022-06-10  9:22           ` Jan Engelhardt
2022-06-10  9:22             ` Jan Engelhardt
2022-06-10  0:32   ` Nick Desaulniers
2022-06-10  0:32     ` Nick Desaulniers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YrCHtmZlK384yiCo@salvia \
    --to=pablo@netfilter.org \
    --cc=morbo@google.com \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.