Re: [PATCH] drm/xlnx: Fix build failure due to missing include

["Ville Syrjälä" <ville.syrjala@linux.intel.com>]

On Tue, Jun 21, 2022 at 11:15:35AM +0300, Laurent Pinchart wrote:
> Hi Ville,
> 
> Thank you for the patch.
> 
> On Tue, Jun 21, 2022 at 10:56:48AM +0300, Ville Syrjala wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > 
> > Dropping drm_blend.h from drm_crtc.h broke the
> > xlnx driver. Make it build again by including
> > drm_blend.h from the driver directly.
> > 
> > My .config was missing some required dependencies so
> > I never build tested it :/
> > 
> > Cc: Hyun Kwon <hyun.kwon@xilinx.com>
> > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> > Fixes: 90bb087f6674 ("drm: Drop drm_blend.h from drm_crtc.h")
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Thanks. Pushed to drm-misc-next.

> 
> > ---
> >  drivers/gpu/drm/xlnx/zynqmp_disp.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/gpu/drm/xlnx/zynqmp_disp.c b/drivers/gpu/drm/xlnx/zynqmp_disp.c
> > index 11c409cbc88e..cc32aa89cf8f 100644
> > --- a/drivers/gpu/drm/xlnx/zynqmp_disp.c
> > +++ b/drivers/gpu/drm/xlnx/zynqmp_disp.c
> > @@ -12,6 +12,7 @@
> >  #include <drm/drm_atomic.h>
> >  #include <drm/drm_atomic_helper.h>
> >  #include <drm/drm_atomic_uapi.h>
> > +#include <drm/drm_blend.h>
> >  #include <drm/drm_crtc.h>
> >  #include <drm/drm_device.h>
> >  #include <drm/drm_fb_cma_helper.h>
> 
> -- 
> Regards,
> 
> Laurent Pinchart

-- 
Ville Syrjälä
Intel