From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Christopherson Date: Tue, 21 Jun 2022 14:54:18 +0000 Subject: [PATCH 0/3] KVM: selftests: Consolidate ucall code In-Reply-To: <19bba1a0-8fb7-2aae-a65a-1111e29b92d3@redhat.com> References: <20220618001618.1840806-1-seanjc@google.com> <19bba1a0-8fb7-2aae-a65a-1111e29b92d3@redhat.com> Message-ID: List-Id: To: kvm-riscv@lists.infradead.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Mon, Jun 20, 2022, Paolo Bonzini wrote: > On 6/18/22 02:16, Sean Christopherson wrote: > > Consolidate the code for making and getting ucalls. All architectures pass > > the ucall struct via memory, so filling and copying the struct is 100% > > generic. The only per-arch code is sending and receiving the address of > > said struct. > > > > Tested on x86 and arm, compile tested on s390 and RISC-V. > > I'm not sure about doing this yet. The SEV tests added multiple > implementations of the ucalls in one architecture. I have rebased those > recently (not the SEV part) to get more familiar with the new kvm_vcpu API > for selftests, and was going to look at your old review next... I had forgotten about that code. My idea of a per-VM list[*] would fit nicely on top, though maybe drop the last patch from this series. [*] https://lore.kernel.org/all/Yc4gcJdhxthBKUUd at google.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by smtp.lore.kernel.org (Postfix) with ESMTP id 614A1C43334 for ; Tue, 21 Jun 2022 14:54:28 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id D26F84B282; Tue, 21 Jun 2022 10:54:27 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@google.com Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id v6KuX4zPCMF2; Tue, 21 Jun 2022 10:54:26 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id BEA214B2B1; Tue, 21 Jun 2022 10:54:26 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id BB3AA4B283 for ; Tue, 21 Jun 2022 10:54:24 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jDD5hVDBwjoj for ; Tue, 21 Jun 2022 10:54:23 -0400 (EDT) Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 8DF794B248 for ; Tue, 21 Jun 2022 10:54:23 -0400 (EDT) Received: by mail-pj1-f41.google.com with SMTP id h9-20020a17090a648900b001ecb8596e43so4470132pjj.5 for ; Tue, 21 Jun 2022 07:54:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ePpQR91B1wy0uIyvmn3lmteXD4y16fGYbzlfAq99TJo=; b=coFv7I5Y78JhXoxS37XR9c+mZYbk7SXPwuO7aREgBr4Q4xY/8nD/BF5WkQBHENLFnR M2swZ0YHKkbeZ6TusTYTCyinn24BoObIO+T5wnAXl9f2sGVIP8rG2F0nAbxkmCVGoPfH dAA8jbBGQ+fJqAoZJEhloFcXw4ggDv8whrRonPLp5/G9ruQkcs3nglSNUwAkZ1SThAWs 1rcmQq3sdA0WobCN3wZET42yLYirfqnABm0YdtxHceX3EHLEBkMtv0LKHMPI3jgadxxF dsa+Azc2y1bTS9+0PGwluDhQy+WUsYOcrTtvwmmyLjgGWHBJwb4h86H6/giVMU3D/eNI BJew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ePpQR91B1wy0uIyvmn3lmteXD4y16fGYbzlfAq99TJo=; b=XFEgPlqqsoRVpT6fc1endDRc9moGSfyYfPPgMro9rgRR0x2sHH8wDwqR1UhyzexHpD 2GsTnFnQ+A3DBwk/gaYqe/hZgqwca+dxBWhSWXA2+R9UFEj/smc7onQUzijzHyJIvXBY 7SVSxABHWZ8Yqd9TByjyiPwsiReZkrqn39J4sEMfD0yoZgdn5hq+BZQEedUbDW7GAW8U UDiFF9iDe9DhHpd3Dsw/RMB9zrVX1tWSW3JzNmD10EkKmRrUV93VZnPBJ4qWP6uEh9P6 FKPUo9X9l/4R8DjgcDJlvdc0Wjvwjx2a6EetwGYfX7uInvG+uSJ6s5R1Je3LF5R5/6yK gxmg== X-Gm-Message-State: AJIora+iIcF/Q+p2arOZDJJvbQHMq3Qs7UoRkFV4SwU1y80xrHkh8I7q 0+QcRcBag1tscnB+mZlyFeYk7g== X-Google-Smtp-Source: AGRyM1vbuWPmzs8GSCKmhq+oi4jC8RW6CP9GBVkjErftz4qJu7wc14nAXYcvbe2B5lTWXF3n/kUg1Q== X-Received: by 2002:a17:90b:4a82:b0:1ec:bb6b:38d0 with SMTP id lp2-20020a17090b4a8200b001ecbb6b38d0mr7523665pjb.213.1655823262366; Tue, 21 Jun 2022 07:54:22 -0700 (PDT) Received: from google.com (123.65.230.35.bc.googleusercontent.com. [35.230.65.123]) by smtp.gmail.com with ESMTPSA id b21-20020aa78115000000b00518764d09cdsm11307136pfi.164.2022.06.21.07.54.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jun 2022 07:54:21 -0700 (PDT) Date: Tue, 21 Jun 2022 14:54:18 +0000 From: Sean Christopherson To: Paolo Bonzini Subject: Re: [PATCH 0/3] KVM: selftests: Consolidate ucall code Message-ID: References: <20220618001618.1840806-1-seanjc@google.com> <19bba1a0-8fb7-2aae-a65a-1111e29b92d3@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <19bba1a0-8fb7-2aae-a65a-1111e29b92d3@redhat.com> Cc: Albert Ou , Janosch Frank , kvm@vger.kernel.org, Claudio Imbrenda , Marc Zyngier , Atish Patra , David Hildenbrand , linux-kernel@vger.kernel.org, Colton Lewis , Palmer Dabbelt , kvm-riscv@lists.infradead.org, Paul Walmsley , linux-riscv@lists.infradead.org, Christian Borntraeger , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On Mon, Jun 20, 2022, Paolo Bonzini wrote: > On 6/18/22 02:16, Sean Christopherson wrote: > > Consolidate the code for making and getting ucalls. All architectures pass > > the ucall struct via memory, so filling and copying the struct is 100% > > generic. The only per-arch code is sending and receiving the address of > > said struct. > > > > Tested on x86 and arm, compile tested on s390 and RISC-V. > > I'm not sure about doing this yet. The SEV tests added multiple > implementations of the ucalls in one architecture. I have rebased those > recently (not the SEV part) to get more familiar with the new kvm_vcpu API > for selftests, and was going to look at your old review next... I had forgotten about that code. My idea of a per-VM list[*] would fit nicely on top, though maybe drop the last patch from this series. [*] https://lore.kernel.org/all/Yc4gcJdhxthBKUUd@google.com _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0CBB1C433EF for ; Tue, 21 Jun 2022 14:54:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=clxFg97erGk5kL/z9kvI32ixyIOJHv17/NUFtW6XukA=; b=CzCOMtrtq8qX/F gltoQuXCCWYfUOZ0F5tvuOh1GVTF5SXucp+ZMvnBNFufKhk6h/c+dPxG9OqizWZsOv0Pb9WOXAqvL Pr/jikA02xuhlwhbmCDP6VEokpXbPacFQy4DORXdfUsprIjDQyB+dTziKSLKir1+ToKK1XqkQ6D8o Pzzq1ZRFtRhJpwsoeHSsJFwb3DOOrctw/EE9N5Vmr8lOrorJ5g9ypO4UXCgXA/LvWPWEGlj52JWTw UmoYIA/Yigl7BiRsldRtK4YCsFZK/FEukpJPNA4YOt20r7pM+Al3cceVtIBnAI84DsiKgih9P2SHW 3jHuz0bQ3nnMCw6mS8LA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o3fH5-005zsM-3k; Tue, 21 Jun 2022 14:54:39 +0000 Received: from mail-pj1-x1036.google.com ([2607:f8b0:4864:20::1036]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o3fGr-005zmU-FE for linux-riscv@lists.infradead.org; Tue, 21 Jun 2022 14:54:27 +0000 Received: by mail-pj1-x1036.google.com with SMTP id g10-20020a17090a708a00b001ea8aadd42bso13682381pjk.0 for ; Tue, 21 Jun 2022 07:54:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ePpQR91B1wy0uIyvmn3lmteXD4y16fGYbzlfAq99TJo=; b=coFv7I5Y78JhXoxS37XR9c+mZYbk7SXPwuO7aREgBr4Q4xY/8nD/BF5WkQBHENLFnR M2swZ0YHKkbeZ6TusTYTCyinn24BoObIO+T5wnAXl9f2sGVIP8rG2F0nAbxkmCVGoPfH dAA8jbBGQ+fJqAoZJEhloFcXw4ggDv8whrRonPLp5/G9ruQkcs3nglSNUwAkZ1SThAWs 1rcmQq3sdA0WobCN3wZET42yLYirfqnABm0YdtxHceX3EHLEBkMtv0LKHMPI3jgadxxF dsa+Azc2y1bTS9+0PGwluDhQy+WUsYOcrTtvwmmyLjgGWHBJwb4h86H6/giVMU3D/eNI BJew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ePpQR91B1wy0uIyvmn3lmteXD4y16fGYbzlfAq99TJo=; b=IHEziZfIJtZW/fk6ifIW6f/LgCJshqKwxu4BwrEM0kZJGKk+TvcYmClANX0CyYZfim gVNq3LqFkq+wjwuUcyaVbPsCIZGcoDSviTrvKcwPVcIR5p55VHHiaFEudzsyea8+fw1b 4SeCj5WjE8fbWoZ74XLEPz5ZBD99h8unwSZvAlHdpkDUIn9eujEi84rwgGK5NcK2JiXv GdFAYNgwfxE3UYGgGQQ9EkbRK5jlefDD2x84LzNVt603dr2AavCoqSkHbLM7s4VgsHNt a6iEMCUO5BOY7OsEzZ4JLvp7WKoykBjrsB2qkpZII0FbKeSJtdOJjiJWrSw3X00zpUQP MilA== X-Gm-Message-State: AJIora83hv8xdUaYmZt+hQVDvOGEg3tWbv96FWE86A/itGs2Jmp2vukq ZZqRi6dZeakJki35GdgBy+15hQ== X-Google-Smtp-Source: AGRyM1vbuWPmzs8GSCKmhq+oi4jC8RW6CP9GBVkjErftz4qJu7wc14nAXYcvbe2B5lTWXF3n/kUg1Q== X-Received: by 2002:a17:90b:4a82:b0:1ec:bb6b:38d0 with SMTP id lp2-20020a17090b4a8200b001ecbb6b38d0mr7523665pjb.213.1655823262366; Tue, 21 Jun 2022 07:54:22 -0700 (PDT) Received: from google.com (123.65.230.35.bc.googleusercontent.com. [35.230.65.123]) by smtp.gmail.com with ESMTPSA id b21-20020aa78115000000b00518764d09cdsm11307136pfi.164.2022.06.21.07.54.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jun 2022 07:54:21 -0700 (PDT) Date: Tue, 21 Jun 2022 14:54:18 +0000 From: Sean Christopherson To: Paolo Bonzini Cc: Marc Zyngier , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , James Morse , Alexandru Elisei , Suzuki K Poulose , Atish Patra , David Hildenbrand , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Colton Lewis , Andrew Jones Subject: Re: [PATCH 0/3] KVM: selftests: Consolidate ucall code Message-ID: References: <20220618001618.1840806-1-seanjc@google.com> <19bba1a0-8fb7-2aae-a65a-1111e29b92d3@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <19bba1a0-8fb7-2aae-a65a-1111e29b92d3@redhat.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220621_075425_574487_6E867FA7 X-CRM114-Status: GOOD ( 13.72 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Mon, Jun 20, 2022, Paolo Bonzini wrote: > On 6/18/22 02:16, Sean Christopherson wrote: > > Consolidate the code for making and getting ucalls. All architectures pass > > the ucall struct via memory, so filling and copying the struct is 100% > > generic. The only per-arch code is sending and receiving the address of > > said struct. > > > > Tested on x86 and arm, compile tested on s390 and RISC-V. > > I'm not sure about doing this yet. The SEV tests added multiple > implementations of the ucalls in one architecture. I have rebased those > recently (not the SEV part) to get more familiar with the new kvm_vcpu API > for selftests, and was going to look at your old review next... I had forgotten about that code. My idea of a per-VM list[*] would fit nicely on top, though maybe drop the last patch from this series. [*] https://lore.kernel.org/all/Yc4gcJdhxthBKUUd@google.com _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 71DB3C433EF for ; Tue, 21 Jun 2022 14:55:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=N7sEVyKRSWhyWnhNJovkIpad4glyzD68A+JPanUk7R0=; b=Zsh8nSzUtTlku2 64uIpZ/x1/oSw5gvbw1irUlJCwafcVIOXtwaxAPsV9AmAqTD9K2wrP7pEu9yDNsDGimRwGmK3p4s0 VHy0/iR1jEmQgTIhW1ghD8neKMlAt4+MoifgH7NFzLv6/nEopCldK5eQB/9XGFlImNGmbnnfKYVTi vU2MC8RMcQGT4rNfH/Q2ZbkXTQMU/V5L/wUyC02UJpZTOhSBNYOYHub3sMbYD9mBJKlOf/buanyIb BkHcxpNGPYKse0YpGF6wG+263NODwSOfXrJKazYNxNdN9MRdRZPfz339sNZG9PPaiwU/Xped2SKzs yByht09ZmByEw7lYOY4g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o3fGs-005zo3-Rs; Tue, 21 Jun 2022 14:54:26 +0000 Received: from mail-pj1-x102f.google.com ([2607:f8b0:4864:20::102f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o3fGp-005zmT-82 for linux-arm-kernel@lists.infradead.org; Tue, 21 Jun 2022 14:54:24 +0000 Received: by mail-pj1-x102f.google.com with SMTP id t3-20020a17090a510300b001ea87ef9a3dso13636707pjh.4 for ; Tue, 21 Jun 2022 07:54:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ePpQR91B1wy0uIyvmn3lmteXD4y16fGYbzlfAq99TJo=; b=coFv7I5Y78JhXoxS37XR9c+mZYbk7SXPwuO7aREgBr4Q4xY/8nD/BF5WkQBHENLFnR M2swZ0YHKkbeZ6TusTYTCyinn24BoObIO+T5wnAXl9f2sGVIP8rG2F0nAbxkmCVGoPfH dAA8jbBGQ+fJqAoZJEhloFcXw4ggDv8whrRonPLp5/G9ruQkcs3nglSNUwAkZ1SThAWs 1rcmQq3sdA0WobCN3wZET42yLYirfqnABm0YdtxHceX3EHLEBkMtv0LKHMPI3jgadxxF dsa+Azc2y1bTS9+0PGwluDhQy+WUsYOcrTtvwmmyLjgGWHBJwb4h86H6/giVMU3D/eNI BJew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ePpQR91B1wy0uIyvmn3lmteXD4y16fGYbzlfAq99TJo=; b=h4bgb6l/knGu+n66EcjV2hdLk63AN43Dv/ARGKzA5RWSQ6RXfvowBq86shVpL68F0k tRwwbPbeAUTsuK31B/y26VmsKEthP2tdqwXy+bgLf6gr81ckyFPkv1ljxh88iHv2dKJO e3AOb5sUMJhw3C+XxKU1c8vTizRYnah3KVwYHFEfbervMQuTk9ZGsmdPLIeBqyEGZ4Qm jjp/PdRXf3v/ITCqS0hZ451Z2wvSMhimAIaz3XQuqU6IC0lV0JIC02pdhF6qVvRI2CJq BxfW2k9fAZuHXJeUS2X9uGhRShllwGvlo9fDKMzDwKFPac5Y3i+gfS1zAfF/A8Bt9nHJ 7msQ== X-Gm-Message-State: AJIora94DYtq5M/prQYy6rpgu4YaMa+EUD8rkDwJcRNgfgeWsqY3qHkP FmhEKOctVbcbnktitHUUriuo2g== X-Google-Smtp-Source: AGRyM1vbuWPmzs8GSCKmhq+oi4jC8RW6CP9GBVkjErftz4qJu7wc14nAXYcvbe2B5lTWXF3n/kUg1Q== X-Received: by 2002:a17:90b:4a82:b0:1ec:bb6b:38d0 with SMTP id lp2-20020a17090b4a8200b001ecbb6b38d0mr7523665pjb.213.1655823262366; Tue, 21 Jun 2022 07:54:22 -0700 (PDT) Received: from google.com (123.65.230.35.bc.googleusercontent.com. [35.230.65.123]) by smtp.gmail.com with ESMTPSA id b21-20020aa78115000000b00518764d09cdsm11307136pfi.164.2022.06.21.07.54.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jun 2022 07:54:21 -0700 (PDT) Date: Tue, 21 Jun 2022 14:54:18 +0000 From: Sean Christopherson To: Paolo Bonzini Cc: Marc Zyngier , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , James Morse , Alexandru Elisei , Suzuki K Poulose , Atish Patra , David Hildenbrand , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Colton Lewis , Andrew Jones Subject: Re: [PATCH 0/3] KVM: selftests: Consolidate ucall code Message-ID: References: <20220618001618.1840806-1-seanjc@google.com> <19bba1a0-8fb7-2aae-a65a-1111e29b92d3@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <19bba1a0-8fb7-2aae-a65a-1111e29b92d3@redhat.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220621_075423_306585_DA9D23F1 X-CRM114-Status: GOOD ( 15.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jun 20, 2022, Paolo Bonzini wrote: > On 6/18/22 02:16, Sean Christopherson wrote: > > Consolidate the code for making and getting ucalls. All architectures pass > > the ucall struct via memory, so filling and copying the struct is 100% > > generic. The only per-arch code is sending and receiving the address of > > said struct. > > > > Tested on x86 and arm, compile tested on s390 and RISC-V. > > I'm not sure about doing this yet. The SEV tests added multiple > implementations of the ucalls in one architecture. I have rebased those > recently (not the SEV part) to get more familiar with the new kvm_vcpu API > for selftests, and was going to look at your old review next... I had forgotten about that code. My idea of a per-VM list[*] would fit nicely on top, though maybe drop the last patch from this series. [*] https://lore.kernel.org/all/Yc4gcJdhxthBKUUd@google.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86395C433EF for ; Tue, 21 Jun 2022 14:54:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351916AbiFUOyZ (ORCPT ); Tue, 21 Jun 2022 10:54:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32940 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233104AbiFUOyX (ORCPT ); Tue, 21 Jun 2022 10:54:23 -0400 Received: from mail-pj1-x102a.google.com (mail-pj1-x102a.google.com [IPv6:2607:f8b0:4864:20::102a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0186D237F6 for ; Tue, 21 Jun 2022 07:54:23 -0700 (PDT) Received: by mail-pj1-x102a.google.com with SMTP id g10-20020a17090a708a00b001ea8aadd42bso13682380pjk.0 for ; Tue, 21 Jun 2022 07:54:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ePpQR91B1wy0uIyvmn3lmteXD4y16fGYbzlfAq99TJo=; b=coFv7I5Y78JhXoxS37XR9c+mZYbk7SXPwuO7aREgBr4Q4xY/8nD/BF5WkQBHENLFnR M2swZ0YHKkbeZ6TusTYTCyinn24BoObIO+T5wnAXl9f2sGVIP8rG2F0nAbxkmCVGoPfH dAA8jbBGQ+fJqAoZJEhloFcXw4ggDv8whrRonPLp5/G9ruQkcs3nglSNUwAkZ1SThAWs 1rcmQq3sdA0WobCN3wZET42yLYirfqnABm0YdtxHceX3EHLEBkMtv0LKHMPI3jgadxxF dsa+Azc2y1bTS9+0PGwluDhQy+WUsYOcrTtvwmmyLjgGWHBJwb4h86H6/giVMU3D/eNI BJew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ePpQR91B1wy0uIyvmn3lmteXD4y16fGYbzlfAq99TJo=; b=UpTzrzZ7dGM9nY+64MCR4qTcp1kowIgk/ox+ifwxOYZnu8iImyClkclJS+jWR6mfkL qp7tCVSYHvAwKkYlXhC2Y1IDzETmW6js1rgGdDIwuVAIVMwQby8L8cwIdKORkqk/Bowc cPIH9Cnjpkvp+4RmUuku0o5LrXPmDPxyYweHDSMxzBdRfJsSQQ/CYwEUw/VeXxex61u2 WDy/71laBQ8NrxRQq3MSX8v2jx0bb5HZ1pdoOiOQ21NdOn+vPzHXm+KyizPFigWLyTi3 BT+QAIX4AKcvzvinTvSYRAlrtG7ntMHnj4ATXAPGeiTcdRRGR7+8B43HI3/CwEzwUHkW rMXg== X-Gm-Message-State: AJIora+0z9u0qt27ygbJmec+QGCuJ80KcTd49GfY3T6D7eUCdRgDXnCZ iwlvAyOS6bpz34cvub9wgfMWqg== X-Google-Smtp-Source: AGRyM1vbuWPmzs8GSCKmhq+oi4jC8RW6CP9GBVkjErftz4qJu7wc14nAXYcvbe2B5lTWXF3n/kUg1Q== X-Received: by 2002:a17:90b:4a82:b0:1ec:bb6b:38d0 with SMTP id lp2-20020a17090b4a8200b001ecbb6b38d0mr7523665pjb.213.1655823262366; Tue, 21 Jun 2022 07:54:22 -0700 (PDT) Received: from google.com (123.65.230.35.bc.googleusercontent.com. [35.230.65.123]) by smtp.gmail.com with ESMTPSA id b21-20020aa78115000000b00518764d09cdsm11307136pfi.164.2022.06.21.07.54.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jun 2022 07:54:21 -0700 (PDT) Date: Tue, 21 Jun 2022 14:54:18 +0000 From: Sean Christopherson To: Paolo Bonzini Cc: Marc Zyngier , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , James Morse , Alexandru Elisei , Suzuki K Poulose , Atish Patra , David Hildenbrand , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Colton Lewis , Andrew Jones Subject: Re: [PATCH 0/3] KVM: selftests: Consolidate ucall code Message-ID: References: <20220618001618.1840806-1-seanjc@google.com> <19bba1a0-8fb7-2aae-a65a-1111e29b92d3@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <19bba1a0-8fb7-2aae-a65a-1111e29b92d3@redhat.com> Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Mon, Jun 20, 2022, Paolo Bonzini wrote: > On 6/18/22 02:16, Sean Christopherson wrote: > > Consolidate the code for making and getting ucalls. All architectures pass > > the ucall struct via memory, so filling and copying the struct is 100% > > generic. The only per-arch code is sending and receiving the address of > > said struct. > > > > Tested on x86 and arm, compile tested on s390 and RISC-V. > > I'm not sure about doing this yet. The SEV tests added multiple > implementations of the ucalls in one architecture. I have rebased those > recently (not the SEV part) to get more familiar with the new kvm_vcpu API > for selftests, and was going to look at your old review next... I had forgotten about that code. My idea of a per-VM list[*] would fit nicely on top, though maybe drop the last patch from this series. [*] https://lore.kernel.org/all/Yc4gcJdhxthBKUUd@google.com