All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oscar Salvador <osalvador@suse.de>
To: David Hildenbrand <david@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Michal Hocko <mhocko@kernel.org>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] mm/page_alloc: Do not calculate node's total pages and memmap pages when empty
Date: Wed, 22 Jun 2022 05:47:22 +0200	[thread overview]
Message-ID: <YrKQyhwDwMvueOUc@localhost.localdomain> (raw)
In-Reply-To: <506203e3-1de0-1187-5234-7afc66d4ddfe@redhat.com>

On Tue, Jun 21, 2022 at 09:44:47AM +0200, David Hildenbrand wrote:
> 
> 
> It's worth noting that the check in pgdat_is_empty() is slightly
> different. I *think* it doesn't matter in practice, yet I wonder if we
> should simply fixup (currently unused) pgdat_is_empty().

I guess we could change it to

 static inline bool pgdat_is_empty(pg_data_t *pgdat)
 {
	 return node_start_pfn(pgdat->node_id) == node_end_pfn(pgdat->node_id)
 }

? And maybe even rename it to to node_is_empty (not sure why but I tend to like
that more than pgdat) 

I could squeeze a "fixup" patch for that before this one. 

> 
> Anyhow
> 
> Reviewed-by: David Hildenbrand <david@redhat.com>

Thanks!


-- 
Oscar Salvador
SUSE Labs


  reply	other threads:[~2022-06-22  3:47 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-21  4:17 [PATCH v2 0/2] Minor memoryhotplug refactoring Oscar Salvador
2022-06-21  4:17 ` [PATCH v2 1/2] mm/page_alloc: Do not calculate node's total pages and memmap pages when empty Oscar Salvador
2022-06-21  7:44   ` David Hildenbrand
2022-06-22  3:47     ` Oscar Salvador [this message]
2022-06-22  3:56       ` Muchun Song
2022-06-22  8:31         ` David Hildenbrand
2022-06-22  8:54           ` Muchun Song
2022-06-22 10:49             ` David Hildenbrand
2022-06-21  4:17 ` [PATCH v2 2/2] mm/memory_hotplug: Reset node's state when empty during offline Oscar Salvador
2022-06-21  7:59   ` David Hildenbrand
2022-06-22  4:25     ` Oscar Salvador
2022-06-22  8:44       ` David Hildenbrand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YrKQyhwDwMvueOUc@localhost.localdomain \
    --to=osalvador@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=david@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.