From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E6074C433EF for ; Wed, 22 Jun 2022 11:22:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PRChxwPGyf1EsKg3DFH27k1b36xevPuxNvBwR1gcHEs=; b=eWHZW9hL1VhCqj nIwmYoGhGyaIgo/HVcLj2R/h/nKpiyZByIgpvQ3U0CPWELuptLxZLrbfy1+o4j/3lOQSM1NPsT3tx HpLHeL0qrAPZ8H0tRHRvK/2dZOPH5JBXuajZlaiMqSPQEVoaPQ934fKl+TCLr7rlTo2yN7S/wp3e7 R4y63rSkLnQTB2ycqTWG7KydLeGHnwldbvjRj3uhaPltVUgWQ5GWOjslYCHOZDYeMcvQMHlrd3+6r VmXBJkmI8DRzuvsMlR9hGw7DXviAwjoi82c/z1+QDjloPmP+VcG6bhzrbWA2eymFNjYBhIJh3JAnQ BPxS1stIo3Eav8VUC78w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o3yQL-00A7MO-Qy; Wed, 22 Jun 2022 11:21:29 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o3yQJ-00A7LE-7d for linux-arm-kernel@lists.infradead.org; Wed, 22 Jun 2022 11:21:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=3PSaIfRzJISZsO0VEI6XQXwgCB4DT0qytDuqsciBimk=; b=uAnOZLdQ0Y1vfpR1o2AfyrXmnS Hy6+YWGSkQPXZeiiqK0yHniTAFTDEDImcVW2mAbAVbNoVaX1lDBHZkRG7YGB+l7FaiITvdM5WCEMR o5BQRTMk8eEXAqqxJtIcF4sCfyBYFCiqXJwfRXv/ujdtqKw+EsPGfaTkFCgh0ibtDBVHb+Ww+TDC6 gdmOwZW/CeWkfulvlMEa2XOOHXx22zMaju+XEM+ZP1bAjlVMzTo36P+X8iaiHzCgquFJkJKFvuLld /sNs/83k6Ph3VkyvgYfBBinzTCuoQR5r+IjxEAMlLqP9SDO3nfXwpErD81bmvXA7I/r+4MN/sKxW8 y1iFl7Fw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:32978) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1o3yQB-0003So-Na; Wed, 22 Jun 2022 12:21:19 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1o3yQ8-0007Nl-NU; Wed, 22 Jun 2022 12:21:16 +0100 Date: Wed, 22 Jun 2022 12:21:16 +0100 From: "Russell King (Oracle)" To: Tetsuo Handa Cc: Tony Lindgren , LKML , Linux ARM Subject: Re: [PATCH] ARM: spectre-v2: fix smp_processor_id() warning Message-ID: References: <795c9463-452e-bf64-1cc0-c318ccecb1da@I-love.SAKURA.ne.jp> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <795c9463-452e-bf64-1cc0-c318ccecb1da@I-love.SAKURA.ne.jp> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220622_042127_308421_B7EC2C12 X-CRM114-Status: GOOD ( 19.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jun 22, 2022 at 03:49:21PM +0900, Tetsuo Handa wrote: > syzbot complains smp_processor_id() from harden_branch_predictor() > from page fault path [1]. Explicitly disable preemption and use > raw_smp_processor_id(). > > Link: https://syzkaller.appspot.com/bug?extid=a7ee43e564223f195c84 [1] > Reported-by: syzbot > Fixes: f5fe12b1eaee220c ("ARM: spectre-v2: harden user aborts in kernel space") > Signed-off-by: Tetsuo Handa This may "fix" the warning, but... > --- > This patch is completely untested. > > arch/arm/include/asm/system_misc.h | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/include/asm/system_misc.h b/arch/arm/include/asm/system_misc.h > index 98b37340376b..a92446769acd 100644 > --- a/arch/arm/include/asm/system_misc.h > +++ b/arch/arm/include/asm/system_misc.h > @@ -20,8 +20,11 @@ typedef void (*harden_branch_predictor_fn_t)(void); > DECLARE_PER_CPU(harden_branch_predictor_fn_t, harden_branch_predictor_fn); > static inline void harden_branch_predictor(void) > { > - harden_branch_predictor_fn_t fn = per_cpu(harden_branch_predictor_fn, > - smp_processor_id()); > + harden_branch_predictor_fn_t fn; > + > + preempt_disable_notrace(); > + fn = per_cpu(harden_branch_predictor_fn, raw_smp_processor_id()); > + preempt_enable_no_resched_notrace(); > if (fn) > fn(); The idea is to get the function for the specific CPU, and then to run it _on_ that CPU, and in theory the CPU that took the fault. However, I seem to remember there are issues trying to achieve that, and I don't have a solution for it. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D064C433EF for ; Wed, 22 Jun 2022 11:23:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236577AbiFVLXA (ORCPT ); Wed, 22 Jun 2022 07:23:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37498 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1357718AbiFVLWr (ORCPT ); Wed, 22 Jun 2022 07:22:47 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1DC283EF16 for ; Wed, 22 Jun 2022 04:21:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=3PSaIfRzJISZsO0VEI6XQXwgCB4DT0qytDuqsciBimk=; b=uAnOZLdQ0Y1vfpR1o2AfyrXmnS Hy6+YWGSkQPXZeiiqK0yHniTAFTDEDImcVW2mAbAVbNoVaX1lDBHZkRG7YGB+l7FaiITvdM5WCEMR o5BQRTMk8eEXAqqxJtIcF4sCfyBYFCiqXJwfRXv/ujdtqKw+EsPGfaTkFCgh0ibtDBVHb+Ww+TDC6 gdmOwZW/CeWkfulvlMEa2XOOHXx22zMaju+XEM+ZP1bAjlVMzTo36P+X8iaiHzCgquFJkJKFvuLld /sNs/83k6Ph3VkyvgYfBBinzTCuoQR5r+IjxEAMlLqP9SDO3nfXwpErD81bmvXA7I/r+4MN/sKxW8 y1iFl7Fw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:32978) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1o3yQB-0003So-Na; Wed, 22 Jun 2022 12:21:19 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1o3yQ8-0007Nl-NU; Wed, 22 Jun 2022 12:21:16 +0100 Date: Wed, 22 Jun 2022 12:21:16 +0100 From: "Russell King (Oracle)" To: Tetsuo Handa Cc: Tony Lindgren , LKML , Linux ARM Subject: Re: [PATCH] ARM: spectre-v2: fix smp_processor_id() warning Message-ID: References: <795c9463-452e-bf64-1cc0-c318ccecb1da@I-love.SAKURA.ne.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <795c9463-452e-bf64-1cc0-c318ccecb1da@I-love.SAKURA.ne.jp> Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 22, 2022 at 03:49:21PM +0900, Tetsuo Handa wrote: > syzbot complains smp_processor_id() from harden_branch_predictor() > from page fault path [1]. Explicitly disable preemption and use > raw_smp_processor_id(). > > Link: https://syzkaller.appspot.com/bug?extid=a7ee43e564223f195c84 [1] > Reported-by: syzbot > Fixes: f5fe12b1eaee220c ("ARM: spectre-v2: harden user aborts in kernel space") > Signed-off-by: Tetsuo Handa This may "fix" the warning, but... > --- > This patch is completely untested. > > arch/arm/include/asm/system_misc.h | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/include/asm/system_misc.h b/arch/arm/include/asm/system_misc.h > index 98b37340376b..a92446769acd 100644 > --- a/arch/arm/include/asm/system_misc.h > +++ b/arch/arm/include/asm/system_misc.h > @@ -20,8 +20,11 @@ typedef void (*harden_branch_predictor_fn_t)(void); > DECLARE_PER_CPU(harden_branch_predictor_fn_t, harden_branch_predictor_fn); > static inline void harden_branch_predictor(void) > { > - harden_branch_predictor_fn_t fn = per_cpu(harden_branch_predictor_fn, > - smp_processor_id()); > + harden_branch_predictor_fn_t fn; > + > + preempt_disable_notrace(); > + fn = per_cpu(harden_branch_predictor_fn, raw_smp_processor_id()); > + preempt_enable_no_resched_notrace(); > if (fn) > fn(); The idea is to get the function for the specific CPU, and then to run it _on_ that CPU, and in theory the CPU that took the fault. However, I seem to remember there are issues trying to achieve that, and I don't have a solution for it. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!