From: Cyril Hrubis <chrubis@suse.cz>
To: Joerg Vehlow <lkml@jv-coder.de>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v2] Fix mountns01/02/03/04 final umounts using more peculiar dir names
Date: Wed, 22 Jun 2022 10:35:22 +0200 [thread overview]
Message-ID: <YrLUSjGS4Ld2ibG2@yuki> (raw)
In-Reply-To: <7605268f-8c8b-fe95-3c58-a29544256dee@jv-coder.de>
Hi!
> >> --- a/testcases/kernel/containers/mountns/mountns.h
> >> +++ b/testcases/kernel/containers/mountns/mountns.h
> >> @@ -10,8 +10,8 @@
> >> #include "tst_test.h"
> >> #include "lapi/namespaces_constants.h"
> >>
> >> -#define DIRA "A"
> >> -#define DIRB "B"
> >> +#define DIRA "__DIR_A"
> >> +#define DIRB "__DIR_B"
> > This is the only non-comment change. How does renaming the directories
> > change anything? Am I missing something?
> Nevermind, now after I read the v1-thread, I get it..
We tend to prefix globally visible objects with LTP_ in order to make
them unique enough and that makes them clearly recognizable as being
created by LTP as well. So maybe we should put the LTP string somewhere
in the names too.
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2022-06-22 8:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-20 13:37 [LTP] [PATCH v2] Fix mountns01/02/03/04 final umounts using more peculiar dir names Cristian Marussi
2022-06-21 1:43 ` xuyang2018.jy
2022-06-21 6:51 ` Joerg Vehlow
2022-06-21 6:55 ` Joerg Vehlow
2022-06-22 8:35 ` Cyril Hrubis [this message]
2022-06-22 8:49 ` Cristian Marussi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YrLUSjGS4Ld2ibG2@yuki \
--to=chrubis@suse.cz \
--cc=lkml@jv-coder.de \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.