From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6FB9C433EF for ; Wed, 22 Jun 2022 16:12:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1358561AbiFVQMt (ORCPT ); Wed, 22 Jun 2022 12:12:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48526 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235461AbiFVQMt (ORCPT ); Wed, 22 Jun 2022 12:12:49 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 083923C71A; Wed, 22 Jun 2022 09:12:48 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 986BB61A0D; Wed, 22 Jun 2022 16:12:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C743BC34114; Wed, 22 Jun 2022 16:12:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1655914367; bh=PCgP866NI3UvwGJGkteVd/VryH9Qe+1ogwHzwOkGjbo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YntJBVHOMYYGl74h02wD97NMioNXX2hQ/LMrwHYkMezUw9ODnOqtVm+NeCVCdWJNs j1JXiALO8TWn/L4DgYz0EzTcUBW2d0WHtWWRrSD6y3m8rJfLH0YosJ//kRtKyvGdPA 0h1qiW6iUm8LjK6ZIbsv9qdQx/j8lcq+SOQfoOTN942ePvU3NDZqkmM7QI3vBYoZhA NVguUeIBxhvwhogFE48r/sQ8fL1SVzo8Mm0tu3Lz8Q8KUmZUpdMIwZodKIV2p5xNw6 HHpJ3CWOFrWJEt7MLv88xC7WxKSBayU0AMBF0LRcUbxXi0gRoI2UAS/gbEYwFNkcGv +j/XmFAHCcACg== Date: Wed, 22 Jun 2022 12:12:45 -0400 From: Sasha Levin To: Greg KH Cc: Guenter Roeck , Julian Haller , linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH 5.4 1/2] hwmon: Introduce hwmon_device_register_for_thermal Message-ID: References: <20220622150234.GC1861763@roeck-us.net> <20220622153950.3001449-1-jhaller@bbl.ms.philips.com> <20220622154454.GA1864037@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Wed, Jun 22, 2022 at 06:09:39PM +0200, Greg KH wrote: >On Wed, Jun 22, 2022 at 08:44:54AM -0700, Guenter Roeck wrote: >> On Wed, Jun 22, 2022 at 05:39:50PM +0200, Julian Haller wrote: >> > > On Wed, Jun 22, 2022 at 04:49:01PM +0200, Julian Haller wrote: >> > > > From: Guenter Roeck >> > > > >> > > > [ upstream commit e5d21072054fbadf41cd56062a3a14e447e8c22b ] >> > > > >> > > > The thermal subsystem registers a hwmon driver without providing >> > > > chip or sysfs group information. This is for legacy reasons and >> > > > would be difficult to change. At the same time, we want to enforce >> > > > that chip information is provided when registering a hwmon device >> > > > using hwmon_device_register_with_info(). To enable this, introduce >> > > > a special API for use only by the thermal subsystem. >> > > > >> > > > Acked-by: Rafael J . Wysocki >> > > > Signed-off-by: Guenter Roeck >> > > >> > > What is the point of applying those patches to the 5.4 kernel ? >> > > This was intended for use with new code, not for stable releases. >> > > >> > > Guenter >> > >> > The upstream commit ddaefa209c4ac791c1262e97c9b2d0440c8ef1d5 ("hwmon: Make chip >> > parameter for with_info API mandatory") was backported to the 5.4 kernel as >> > part of v5.4.198, see commit 1ec0bc72f5dab3ab367ae5230cf6f212d805a225. This >> > breaks the hwmon device registration in the thermal drivers as these two >> > patches here have been left out. We either need to include them as well or >> > revert the original commit. >> > >> > I'm also not sure why the original commit found its way into the 5.4 stable >> > branch. >> > >> >> I had complained about this backport to other branches before. That patch >> was not a bug fix, it was neither intended nor marked for stable releases, >> and it should be reverted from all stable branches. > >Yes, that's not right, let me go revert that. Odd that it only went >into 4.19 and 5.4, I think Sasha's scripts went wonky there... Yes, I definitely remember dropping it - not sure how it ended up on those two kernels. I'll dig into what happened here. sorry :( -- Thanks, Sasha