Re: [PULL 00/25] Migration 20220621 patches

["Dr. David Alan Gilbert" <dgilbert@redhat.com>]

* Richard Henderson (richard.henderson@linaro.org) wrote:
> On 6/21/22 17:25, Juan Quintela wrote:
> > The following changes since commit c8b2d413761af732a0798d8df45ce968732083fe:
> > 
> >    Merge tag 'bsd-user-syscall-2022q2-pull-request' of ssh://github.com/qemu-bsd-user/qemu-bsd-user into staging (2022-06-19 13:56:13 -0700)
> > 
> > are available in the Git repository at:
> > 
> >    https://gitlab.com/juan.quintela/qemu.git tags/migration-20220621-pull-request
> > 
> > for you to fetch changes up to 720eceaa316f2a75a7930085bb305850831a065f:
> > 
> >    migration: remove the QEMUFileOps abstraction (2022-06-21 18:06:55 +0200)
> > 
> > ----------------------------------------------------------------
> > Migration Pull request
> > 
> > Hi
> > 
> > In this today migration PULL request:
> > - dainiel Berrangé qemufileops cleanup
> > - Leonardo Brass cleanups for zero copy
> > - RDMA cleanups (me)
> 
> Build failures:

Hmm, I'll fix these up

> https://gitlab.com/qemu-project/qemu/-/jobs/2622407867
> https://gitlab.com/qemu-project/qemu/-/jobs/2622407794
> https://gitlab.com/qemu-project/qemu/-/jobs/2622407791
> 
> ../migration/migration.c:166:5: error: 'MIGRATION_CAPABILITY_ZERO_COPY_SEND'
> undeclared here (not in a function); did you mean
> 'MIGRATION_CAPABILITY_ZERO_BLOCKS'?
>   166 |     MIGRATION_CAPABILITY_ZERO_COPY_SEND);
>       |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../migration/migration.c:145:35: note: in definition of macro 'INITIALIZE_MIGRATE_CAPS_SET'
>   145 |         .size = sizeof((int []) { __VA_ARGS__ }) / sizeof(int), \
>       |                                   ^~~~~~~~~~~
> [1118/1665] Compiling C object libcommon.fa.p/migration_multifd.c.obj

So these are non-Linux's; so I guess that constant is guardded;
> 
> https://gitlab.com/qemu-project/qemu/-/jobs/2622407863
> https://gitlab.com/qemu-project/qemu/-/jobs/2622407862
> https://gitlab.com/qemu-project/qemu/-/jobs/2622407860
> https://gitlab.com/qemu-project/qemu/-/jobs/2622407811
> 
> ../io/channel-socket.c:589:9: error: implicit declaration of function
> 'g_assert_unreachable' is invalid in C99
> [-Werror,-Wimplicit-function-declaration]
>         g_assert_unreachable();
>         ^

Again, non Linux; and should be g_assert_not_reached

I'll fix this up.

Dave

> 
> r~
> 
-- 
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK