From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75AECC433EF for ; Wed, 22 Jun 2022 16:51:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1377023AbiFVQvN (ORCPT ); Wed, 22 Jun 2022 12:51:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58372 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1376887AbiFVQu5 (ORCPT ); Wed, 22 Jun 2022 12:50:57 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 497CC40E73 for ; Wed, 22 Jun 2022 09:48:57 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DC4A961B1F for ; Wed, 22 Jun 2022 16:48:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CF452C3411B; Wed, 22 Jun 2022 16:48:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1655916536; bh=HKAwj6WqHsFCizeY3YQTqEfxSzWhZ074BWZUt4AykcE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gn07NX4XJW2TBPErhOJSQPWok8YUaMQHmpcwfee9PC84zM1ypWc/JkQCdfgXozvp8 1MrKfvqHUQRBW9kKHDbCIHoGblR9udb43LNsl1jgkF5A6onQVZLgMQdPk8L4xaFXf9 nZLW8BrU7y3bCxwDpYoUG8WmTttKiDgqeBNYJsHnfX5oLG3UI3MTdr3V2TmpChaEx/ Ek1YnHHx8FFM4ijCaBFSEDCOcQQqRCwluL7T9wizMdN9rzAZH1m4bm39Op3lE7TwFw kBTqJ5E9n5Qqku5LaB9ujVZc77vKdKsyWZ1QmJRD8nmvP7sfrxWSxplUKwfHZZOT8E lczUlS74UadJQ== Date: Wed, 22 Jun 2022 17:48:51 +0100 From: Mark Brown To: Dong Aisheng Cc: Aisheng Dong , "linux-kernel@vger.kernel.org" , "l.stach@pengutronix.de" , Peng Fan , "shawnguo@kernel.org" Subject: Re: [PATCH RFC 1/2] regmap: add option to disable debugfs Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="xDUxxgqnT7sUsrLu" Content-Disposition: inline In-Reply-To: X-Cookie: Truckers welcome. Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --xDUxxgqnT7sUsrLu Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Jun 23, 2022 at 12:42:51AM +0800, Dong Aisheng wrote: > On Thu, Jun 23, 2022 at 12:27 AM Mark Brown wrote: > > cache_bypass is only going to be true if something enabled bypass, why > > would a device that doesn't use a cache enable bypass? It does get > > turned on transiently by things like patching but those only make sense > > if the device can be accessed so caceh_only shouldn't be on then. > It was enabled by default according to the code: > __regmap_init -> regcache_init Ah, right. That makes sense - we should relax the check to only apply if there is actually a cache. --xDUxxgqnT7sUsrLu Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmKzR/IACgkQJNaLcl1U h9DGaQf/ZCq9VWO3ofHpZRx0yp3FDK4aUd7qAalJ1T73pWVSk7oN0B7WFLEEZUjp psfGcIzztckSoJIL7vxfGayS32ZsOXsetjkKDlRaitE2pHOx5nriGV3b888D1ysA 6jJk43hzFnEjU17YONVOmlSMPrNs8PV0YvIedT9V2WofKY+YWIRCnLgS4Gc0GvgK 4utsH9r12dYIQDtUkMcLWgrw/Sy7dw9SApe8NcbphkVKY2HVyf8ZFRjaIAIu3phI Q5sGhkVjAwrqOMocr+TEu+1tycGS53JpqrPSiIJJ/gITYfstLCd4hfZ4ciD0/xmF vnwAoLGLmg1EYxvvUYgm+C9meNyIQg== =Ke7G -----END PGP SIGNATURE----- --xDUxxgqnT7sUsrLu--