From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1105CCA47D for ; Wed, 22 Jun 2022 17:08:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1377036AbiFVRIq (ORCPT ); Wed, 22 Jun 2022 13:08:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42654 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1377306AbiFVRIY (ORCPT ); Wed, 22 Jun 2022 13:08:24 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4639142496 for ; Wed, 22 Jun 2022 10:07:22 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 242F661B89 for ; Wed, 22 Jun 2022 17:07:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2992AC34114; Wed, 22 Jun 2022 17:07:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1655917639; bh=jgUJecCzFXvnTsqrwru1uRnoQwtYzOYNC/yDvPGBGoU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IhZwI4Q6iVlC+S04Q/J29TcboiwU+MljMXhoIKGg/AarqIIaTjhvPWG8Z5naLox1B n9KzIptntxltqPY1UQX7h6+eshcKX5oThDpAfbbkf+5lPHZNJDhE22vQrk6ovDr6oN 6Y17fZSrph0Xy4r8ZUdj4pEGcqUwbIhTfj8ATiOakPESMDJzko75CuWYd/Zhi8KQpt 6VBVVsuA1I+MzepLJnoupAngeGMWvT1Jz8keDZX/TCuwguPcCsaBPRgu7Kgxak/iez Grfx6FYsk6nAPs/Mx6RdBLf4M9kYE6s+/BCOLQj4HZkBCOSKpStEzvhVWHDEibsMvn /cE+zahQqxROw== Date: Wed, 22 Jun 2022 18:07:15 +0100 From: Mark Brown To: Dong Aisheng Cc: Aisheng Dong , "linux-kernel@vger.kernel.org" , "l.stach@pengutronix.de" , Peng Fan , "shawnguo@kernel.org" Subject: Re: [PATCH RFC 1/2] regmap: add option to disable debugfs Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="8qqGhfl8w2IBtgLF" Content-Disposition: inline In-Reply-To: X-Cookie: Truckers welcome. Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --8qqGhfl8w2IBtgLF Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Jun 23, 2022 at 01:01:12AM +0800, Dong Aisheng wrote: > On Thu, Jun 23, 2022 at 12:48 AM Mark Brown wrote: > > Ah, right. That makes sense - we should relax the check to only apply > > if there is actually a cache. > If we don't remove the WARN_ON in regcache_cache_only(), how > would you suggest the fix? In exactly the manner I suggested above. --8qqGhfl8w2IBtgLF Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmKzTEIACgkQJNaLcl1U h9Diqwf+Nz4r4ln8IKyQtWv2S6rFk5jVlzqo7clQkJiexuryvvBKMzraOfs4olcX a5kjTZUEH3b5yW8+xvIaTt2AXOxnNwqnWc0Z//7FrL3+SUv4JlRJUQQwzSZ7UE7v 30Syy4I74zSePHlCMvXFz5Ji1lyAPuJgzLYKCh14+zj48JIfxCuY+Bbm+CRXqS84 XuQFwTq90Re41/8i9Q7tKMnNHwWT4CMlxXt7zBpCEvuiYfWnIzOYWIHuok0BO5Fm cRSMsQ9N4xeFPicCu59mEd101vxejcC3lrtjKtGdVGFzoG9nFUnxze9ErMESG0LN 08DQYKM4mPPMPNxGchA2Bqh001F/Dw== =NXAf -----END PGP SIGNATURE----- --8qqGhfl8w2IBtgLF--