From: Sam Ravnborg <sam@ravnborg.org>
To: Kevin Brace <kevinbrace@gmx.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: How do I gather up new code to be converted as patches?
Date: Wed, 22 Jun 2022 20:06:28 +0200 [thread overview]
Message-ID: <YrNaJBiAEKaoreGw@ravnborg.org> (raw)
In-Reply-To: <trinity-356e941b-2ee3-4974-944b-5495ba4d00b8-1655918337996@3c-app-mailcom-bs16>
Hi Kevin,
On Wed, Jun 22, 2022 at 07:18:58PM +0200, Kevin Brace wrote:
> Hi,
>
> How to I use git to gather up new code to be converted to patches?
> Specifically, I have 20+ new files in one location (drivers/gpu/drm/via)
> and a small change to DRM main make file (drivers/gpu/drm/Makefile).
One simple way to do this is to start with a clean tree, and then add
files step by step.
20+ files in one patch is too much to review, so decide for a
reasonable split between the files.
Maybe something like (as inspiration find your own split):
0) Documentation - or add this in you cover letter. Enough info to give
the reader a rough understanding of the HW and the driver structure.
1) Driver files
2) Util files
3) Files for the memory handling
4) Files for irq handling
5) HW specific files
6) A the final patch - the Kconfig, and Makefile adjustments.
It is important that the final patch is final as you would otherwise
break the build.
I look forward to see the patches!
Sam
next prev parent reply other threads:[~2022-06-22 18:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-22 17:18 How do I gather up new code to be converted as patches? Kevin Brace
2022-06-22 17:33 ` Jeffrey Hugo
2022-06-23 19:29 ` Kevin Brace
2022-06-23 20:04 ` Thomas Zimmermann
2022-06-22 18:06 ` Sam Ravnborg [this message]
2022-06-23 23:17 ` Kevin Brace
2022-06-24 5:16 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YrNaJBiAEKaoreGw@ravnborg.org \
--to=sam@ravnborg.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=kevinbrace@gmx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.