From: Johan Hovold <johan@kernel.org>
To: Vinod Koul <vkoul@kernel.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Manivannan Sadhasivam <mani@kernel.org>,
Jassi Brar <jassisinghbrar@gmail.com>,
Johan Hovold <johan+linaro@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] arm64: dts: qcom: add SC8280XP platform
Date: Thu, 23 Jun 2022 08:42:48 +0200 [thread overview]
Message-ID: <YrQLaGcB9NoCDQQM@hovoldconsulting.com> (raw)
In-Reply-To: <YrP4qs+GIlaS7Wzy@matsya>
On Thu, Jun 23, 2022 at 10:52:50AM +0530, Vinod Koul wrote:
> On 07-06-22, 14:41, Bjorn Andersson wrote:
> > + aggre1_noc: interconncet-aggre1-noc {
> s/interconncet/interconnect
Note that you're reviewing v1 and that this has since been fixed.
> Hmmm I thought it was required that node name should be interconnect@x
> > + usb_0_hsphy: phy@88e5000 {
> > + compatible = "qcom,sc8280xp-usb-hs-phy",
> > + "qcom,usb-snps-hs-5nm-phy";
> > + reg = <0 0x088e5000 0 0x400>;
>
> this doesn't match with node address above (I think W=1 would warn you
> of such mismatches, useful to run on new dts
This unit address is actually correct, but there were some other
mismatches that were also fixed in v2.
Johan
next prev parent reply other threads:[~2022-06-23 6:42 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-07 21:41 [PATCH 0/4] arm64: dts: qcom: Introduce SC8280XP Bjorn Andersson
2022-06-07 21:41 ` [PATCH 1/4] dt-bindings: mailbox: qcom-ipcc: Add NSP1 client Bjorn Andersson
2022-06-08 7:59 ` Krzysztof Kozlowski
2022-08-02 3:28 ` Jassi Brar
2022-06-07 21:41 ` [PATCH 2/4] arm64: dts: qcom: add SC8280XP platform Bjorn Andersson
2022-06-08 8:18 ` Krzysztof Kozlowski
2022-06-21 3:37 ` Bjorn Andersson
2022-06-21 6:53 ` Krzysztof Kozlowski
2022-06-22 3:32 ` Bjorn Andersson
2022-06-22 14:44 ` Krzysztof Kozlowski
2022-06-08 16:00 ` Johan Hovold
2022-06-23 5:22 ` Vinod Koul
2022-06-23 6:42 ` Johan Hovold [this message]
2022-06-07 21:41 ` [PATCH 3/4] arm64: dts: qcom: sc8280x: Add reference device Bjorn Andersson
2022-06-08 8:24 ` Krzysztof Kozlowski
2022-06-08 16:17 ` Johan Hovold
2022-06-21 3:39 ` Bjorn Andersson
2022-06-07 21:41 ` [PATCH 4/4] arm64: dts: qcom: add SA8540P and ADP Bjorn Andersson
2022-06-08 8:26 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YrQLaGcB9NoCDQQM@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jassisinghbrar@gmail.com \
--cc=johan+linaro@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mani@kernel.org \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.