From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D3AFBC433EF for ; Thu, 23 Jun 2022 08:42:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1/FyysZbnuFIk9tvFkyYqPo+nLkxtU6IuOaWk5A2r44=; b=zCVnDqiL4shkKu dhpT2znSqAWriWjuoS968TYdQCBRo0SVqE0nl7LFzriPhqSqe2swcu0tAdA4kpFpVU+OLBJAu2U9y HW4zgwCVq0Gh434IZvKuip5PEqswLpUEuQJ70wcBqRZKHvHfjB+bhXIap4HftlTyhCCSWp+diKkTK 7JRAJSc+0UYqmKj11SOimZxZs9hitAQQhd9chAmylNgz3mtZXVSYNsyf4V24JsYeRU9jPCCiwxA8V q0bffIYmvd6LStGEdj0jd/C0SAhaxZcegeLaBE2JIz4a/1Ru5Ger0Mcz2O+0xOQtWjofBPfAr+bua AMdGu6bnyyiOyYCkDSTg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o4IOq-00E8R6-NX; Thu, 23 Jun 2022 08:41:16 +0000 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o4IOn-00E8Pa-18 for linux-arm-kernel@lists.infradead.org; Thu, 23 Jun 2022 08:41:14 +0000 Received: by mail-wm1-x332.google.com with SMTP id p6-20020a05600c1d8600b003a035657950so68824wms.4 for ; Thu, 23 Jun 2022 01:41:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=rWVj9cB0VWQwjl49hmnp6oq16s8Sg76Jvrdztki9ovM=; b=TYc8r7HaGQx1/TUZa3jH6IVaFolGey0NfGvOCSZdEDOARhutqNlNJUc3liJnJcYumH ZkYm+sTb2L2OnCHijIBvgOU4D+x2JhZRFl3K/Yici+jRdhXnvz3UfXeeOYgpexIJgYAU 3bthev/JdtCDS80Pf9F97B7Z2Bi86VgfDL5RYs3sOANbHtR48pow9IIo09TohSm4o2t9 mFalStiy0QPi4KBHNmMXgQDIs3AkDDRBf1RomrTs+1O5ctB6/lHzs4diNmrI7aa9iwHR h5/QreRLF9Lkh3TomhDMoGv1yRSYNkhfJ17bfc6Zo0WeCPGOg0s6fA4ILv1gyHt7kWKr rVVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=rWVj9cB0VWQwjl49hmnp6oq16s8Sg76Jvrdztki9ovM=; b=YGRxR2lVawFu70c94sS1P02glRFRc9wcCmJuwi2pQJ55FsP/Qso+/StwZQvUsE695W mduntyNk3EqzeH97+nOchGMUEx5T2k00Z46t3BhOsgOuMtEMLJgGny5X1CJ3Nwod4l1E MhlE3LnX8LsbGTZNjgjkwWbJ0NEK+rjpHRzk+fw2SZ5A5F8bl3bjvZpJkohkhrVadIVr A76pfaul/00uZ2+tPJsXnIU12ie8Fy3Cxe24iVXLFdb5EK63H8Aqvqx7oLX9Aa0gqdVx pMwzGZHDW5mijG33kye6pkWk4e1aNYEJVVT3r38LyKEX0YOouBIh5vWrKR5IybGPXc+t 8SSg== X-Gm-Message-State: AJIora/K78ciQO3nV3wI8JD+RNZMDUNbhmdYZOupr0wyjpAmwpk3AQAR Mp5FXlbB0CrGmn8QnOdrLHNJOw== X-Google-Smtp-Source: AGRyM1v/Spw0q05cJy85iL1hTEZd/YVlAHKxhTynQaSAvhRK2q++zdYTesnBjzDNEIXAnOn8ANPOIg== X-Received: by 2002:a05:600c:3847:b0:39c:6a85:d20c with SMTP id s7-20020a05600c384700b0039c6a85d20cmr2905464wmr.129.1655973671000; Thu, 23 Jun 2022 01:41:11 -0700 (PDT) Received: from google.com (cpc155339-bagu17-2-0-cust87.1-3.cable.virginm.net. [86.27.177.88]) by smtp.gmail.com with ESMTPSA id g13-20020a5d488d000000b0021b86dbad37sm15645315wrq.68.2022.06.23.01.41.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jun 2022 01:41:10 -0700 (PDT) Date: Thu, 23 Jun 2022 09:41:08 +0100 From: Lee Jones To: Stefan Wahren Cc: Florian Fainelli , Ray Jui , Scott Branden , Peter Robinson , Melissa Wen , Phil Elwell , bcm-kernel-feedback-list@broadcom.com, Maxime Ripard , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH V3 07/11] mfd: bcm2835-pm: Add support for BCM2711 Message-ID: References: <20220607204226.8703-1-stefan.wahren@i2se.com> <20220607204226.8703-8-stefan.wahren@i2se.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220607204226.8703-8-stefan.wahren@i2se.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220623_014113_101862_8937F60A X-CRM114-Status: GOOD ( 32.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCAwNyBKdW4gMjAyMiwgU3RlZmFuIFdhaHJlbiB3cm90ZToKCj4gSW4gQkNNMjcxMSB0 aGUgbmV3IFJQaVZpZCBBU0IgdG9vayBvdmVyIFYzRC4gVGhlIG9sZCBBU0IgaXMgc3RpbGwgcHJl c2VudAo+IHdpdGggdGhlIElTUCBhbmQgSDI2NCBiaXRzLCBhbmQgVjNEIGlzIGluIHRoZSBzYW1l IHBsYWNlIGluIHRoZSBuZXcgQVNCCj4gYXMgdGhlIG9sZCBvbmUuCj4gCj4gQXMgcGVyIHRoZSBk ZXZpY2V0cmVlIGJpbmRpbmdzLCBCQ00yNzExIHdpbGwgcHJvdmlkZSBib3RoIHRoZSBvbGQgYW5k Cj4gbmV3IEFTQiByZXNvdXJjZXMsIHNvIGdldCBib3RoIG9mIHRoZW0gYW5kIHBhc3MgdGhlbSBp bnRvCj4gJ2JjbTI4MzUtcG93ZXIsJyB3aGljaCB3aWxsIHRha2UgY2FyZSBvZiBzZWxlY3Rpbmcg d2hpY2ggb25lIHRvIHVzZQo+IGFjY29yZGluZ2x5Lgo+IAo+IFNpbmNlIHRoZSBSUGlWaWQgQVNC J3MgcmVzb3VyY2VzIHdlcmUgYmVpbmcgcHJvdmlkZWQgcHJpb3IgdG8gZm9ybWFsaXppbmcKPiB0 aGUgYmluZGluZ3NbMV0sIGFsc28gc3VwcG9ydCB0aGUgb2xkIERUIGZpbGVzIHRoYXQgZGlkbid0 IHVzZQo+ICdyZWctbmFtZXMuJwo+IAo+IFNpZ25lZC1vZmYtYnk6IFN0ZWZhbiBXYWhyZW4gPHN0 ZWZhbi53YWhyZW5AaTJzZS5jb20+Cj4gUmV2aWV3ZWQtYnk6IFBldGVyIFJvYmluc29uIDxwYnJv Ymluc29uQGdtYWlsLmNvbT4KPiAKPiBbMV0gU2VlOiA3ZGJlOGM2MmNlZWIgKCJBUk06IGR0czog QWRkIG1pbmltYWwgUmFzcGJlcnJ5IFBpIDQgc3VwcG9ydCIpCj4gLS0tCj4gIGRyaXZlcnMvbWZk L2JjbTI4MzUtcG0uYyAgICAgICB8IDIxICsrKysrKysrKysrKysrKysrKysrKwo+ICBpbmNsdWRl L2xpbnV4L21mZC9iY20yODM1LXBtLmggfCAgMSArCj4gIDIgZmlsZXMgY2hhbmdlZCwgMjIgaW5z ZXJ0aW9ucygrKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL21mZC9iY20yODM1LXBtLmMgYi9k cml2ZXJzL21mZC9iY20yODM1LXBtLmMKPiBpbmRleCBmZjBkYWU1YTAyNmQuLjRhMmJlNjY5Njc0 YSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL21mZC9iY20yODM1LXBtLmMKPiArKysgYi9kcml2ZXJz L21mZC9iY20yODM1LXBtLmMKPiBAQCAtMjgsNiArMjgsOCBAQCBzdGF0aWMgY29uc3Qgc3RydWN0 IG1mZF9jZWxsIGJjbTI4MzVfcG93ZXJfZGV2c1tdID0gewo+ICBzdGF0aWMgaW50IGJjbTI4MzVf cG1fZ2V0X3BkYXRhKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYsCj4gIAkJCQlzdHJ1Y3Qg YmNtMjgzNV9wbSAqcG0pCj4gIHsKPiArCWJvb2wgaXNfYmNtMjcxMSA9IG9mX2RldmljZV9pc19j b21wYXRpYmxlKHBtLT5kZXYtPm9mX25vZGUsICJicmNtLGJjbTI3MTEtcG0iKTsKPiArCgpTaW5j ZSB0aGlzIGlzIG9ubHkgdXNlZCBvbmNlLCBwcm9iYWJseSBiZXR0ZXIgdG8gY2FsbApvZl9kZXZp Y2VfaXNfY29tcGF0aWJsZSgpIGluLXBsYWNlLgoKPiAgCS8qIElmIG5vICdyZWctbmFtZXMnIHBy b3BlcnR5IGlzIGZvdW5kIHdlIGNhbiBhc3N1bWUgd2UncmUgdXNpbmcgb2xkCj4gIAkgKiBmaXJt d2FyZS4KPiAgCSAqLwo+IEBAIC0zOSw2ICs0MSw3IEBAIHN0YXRpYyBpbnQgYmNtMjgzNV9wbV9n ZXRfcGRhdGEoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldiwKPiAgCQkJcmV0dXJuIFBUUl9F UlIocG0tPmJhc2UpOwo+ICAKPiAgCQlwbS0+YXNiID0gZGV2bV9wbGF0Zm9ybV9pb3JlbWFwX3Jl c291cmNlKHBkZXYsIDEpOwo+ICsJCXBtLT5ycGl2aWRfYXNiID0gZGV2bV9wbGF0Zm9ybV9pb3Jl bWFwX3Jlc291cmNlKHBkZXYsIDIpOwo+ICAJfSBlbHNlIHsKPiAgCQlzdHJ1Y3QgcmVzb3VyY2Ug KnJlczsKPiAgCj4gQEAgLTUwLDExICs1MywyOCBAQCBzdGF0aWMgaW50IGJjbTI4MzVfcG1fZ2V0 X3BkYXRhKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYsCj4gIAkJCQkJCSAgICAiYXNiIik7 Cj4gIAkJaWYgKHJlcykKPiAgCQkJcG0tPmFzYiA9IGRldm1faW9yZW1hcF9yZXNvdXJjZSgmcGRl di0+ZGV2LCByZXMpOwo+ICsKPiArCQlyZXMgPSBwbGF0Zm9ybV9nZXRfcmVzb3VyY2VfYnluYW1l KHBkZXYsIElPUkVTT1VSQ0VfTUVNLAo+ICsJCQkJCQkgICAgInJwaXZpZF9hc2IiKTsKPiArCQlp ZiAocmVzKQo+ICsJCQlwbS0+cnBpdmlkX2FzYiA9IGRldm1faW9yZW1hcF9yZXNvdXJjZSgmcGRl di0+ZGV2LAo+ICsJCQkJCQkJCXJlcyk7Cj4gIAl9Cj4gIAo+ICAJaWYgKElTX0VSUihwbS0+YXNi KSkKPiAgCQlwbS0+YXNiID0gTlVMTDsKPiAgCj4gKwlpZiAoSVNfRVJSKHBtLT5ycGl2aWRfYXNi KSkKPiArCQlwbS0+cnBpdmlkX2FzYiA9IE5VTEw7Cj4gKwo+ICsJLyogRW5zdXJlIHRoYXQgcnBp dmlkX2FzYiBpcyBzZXQgb25seSBmb3IgQkNNMjcxMSwgc28gc3Vic2VxdWVudAo+ICsJICogZHJp dmVyIGNhbiByZWx5IG9uIHRoaXMgYW5kIGRvbid0IGdldCBjb25mdXNlZCBieSBicm9rZW4gRFRC Lgo+ICsJICovCgpQbGVhc2UgdXNlIHByb3BlciBmb3JtYXR0aW5nLgoKPiArCWlmIChwbS0+cnBp dmlkX2FzYiAmJiAhaXNfYmNtMjcxMSkgewo+ICsJCWRldl9lcnIocG0tPmRldiwgIlVuZXhwZWN0 ZWQgcnBpdmlkX2FzYiByZWdpc3RlciwgcGxlYXNlIGZpeCB5b3VyIERUQi5cbiIpOwoKTm90IHN1 cmUgd2Ugc2hvdWxkIGJlIHZhbGlkYXRpbmcgdmFsdWVzIGZyb20gRFQgbGlrZSB0aGlzLgoKSWYg aW5jb3JyZWN0IGhhcmR3YXJlIGluZm9ybWF0aW9uIGlzIHBsYWNlZCBpbnRvIERULCB1bmV4cGVj dGVkCmJlaGF2aW91ciB3aWxsIG9jY3VyLiAgVGhpcyBpcyBrbm93bi4gIFBlcmhhcHMgYSBtZW50 aW9uIG9mIHRoaXMKc2hvdWxkIGJlIHBsYWNlZCBpbnRvIHRoZSBEVCBiaW5kaW5nIGRvY3VtZW50 YXRpb24sIGJ1dCBjaGVja2luZyBmb3IKaXQgaGVyZSBzZWVtcyBvZGQuCgpTYW1lIGdvZXMgZm9y IHRoZSBwcmV2aW91cyBwYXRjaCBjb21lIHRvIHRoaW5rIG9mIGl0LiAgUGxlYXNlIHJlbW92ZQp0 aGUgInVwZGF0ZSB5b3VyIERUQiIgd2FybmluZyBmcm9tIHRoZXJlIHRvby4KCj4gKwkJcmV0dXJu IC1FSU5WQUw7Cj4gKwl9Cj4gKwo+ICAJcmV0dXJuIDA7Cj4gIH0KPiAgCj4gQEAgLTk1LDYgKzEx NSw3IEBAIHN0YXRpYyBpbnQgYmNtMjgzNV9wbV9wcm9iZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNl ICpwZGV2KQo+ICBzdGF0aWMgY29uc3Qgc3RydWN0IG9mX2RldmljZV9pZCBiY20yODM1X3BtX29m X21hdGNoW10gPSB7Cj4gIAl7IC5jb21wYXRpYmxlID0gImJyY20sYmNtMjgzNS1wbS13ZHQiLCB9 LAo+ICAJeyAuY29tcGF0aWJsZSA9ICJicmNtLGJjbTI4MzUtcG0iLCB9LAo+ICsJeyAuY29tcGF0 aWJsZSA9ICJicmNtLGJjbTI3MTEtcG0iLCB9LAo+ICAJe30sCj4gIH07Cj4gIE1PRFVMRV9ERVZJ Q0VfVEFCTEUob2YsIGJjbTI4MzVfcG1fb2ZfbWF0Y2gpOwo+IGRpZmYgLS1naXQgYS9pbmNsdWRl L2xpbnV4L21mZC9iY20yODM1LXBtLmggYi9pbmNsdWRlL2xpbnV4L21mZC9iY20yODM1LXBtLmgK PiBpbmRleCBlZDM3ZGM0MGU4MmEuLmY3MGE4MTBjNTVmNyAxMDA2NDQKPiAtLS0gYS9pbmNsdWRl L2xpbnV4L21mZC9iY20yODM1LXBtLmgKPiArKysgYi9pbmNsdWRlL2xpbnV4L21mZC9iY20yODM1 LXBtLmgKPiBAQCAtOSw2ICs5LDcgQEAgc3RydWN0IGJjbTI4MzVfcG0gewo+ICAJc3RydWN0IGRl dmljZSAqZGV2Owo+ICAJdm9pZCBfX2lvbWVtICpiYXNlOwo+ICAJdm9pZCBfX2lvbWVtICphc2I7 Cj4gKwl2b2lkIF9faW9tZW0gKnJwaXZpZF9hc2I7Cj4gIH07Cj4gIAo+ICAjZW5kaWYgLyogQkNN MjgzNV9NRkRfUE1fSCAqLwoKLS0gCkxlZSBKb25lcyBb5p2O55C85pavXQpQcmluY2lwYWwgVGVj aG5pY2FsIExlYWQgLSBEZXZlbG9wZXIgU2VydmljZXMKTGluYXJvLm9yZyDilIIgT3BlbiBzb3Vy Y2Ugc29mdHdhcmUgZm9yIEFybSBTb0NzCkZvbGxvdyBMaW5hcm86IEZhY2Vib29rIHwgVHdpdHRl ciB8IEJsb2cKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5m cmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xp bnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2166C43334 for ; Thu, 23 Jun 2022 08:41:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229841AbiFWIlO (ORCPT ); Thu, 23 Jun 2022 04:41:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51582 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230172AbiFWIlN (ORCPT ); Thu, 23 Jun 2022 04:41:13 -0400 Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 95C2549249 for ; Thu, 23 Jun 2022 01:41:12 -0700 (PDT) Received: by mail-wm1-x332.google.com with SMTP id e5so10602625wma.0 for ; Thu, 23 Jun 2022 01:41:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=rWVj9cB0VWQwjl49hmnp6oq16s8Sg76Jvrdztki9ovM=; b=TYc8r7HaGQx1/TUZa3jH6IVaFolGey0NfGvOCSZdEDOARhutqNlNJUc3liJnJcYumH ZkYm+sTb2L2OnCHijIBvgOU4D+x2JhZRFl3K/Yici+jRdhXnvz3UfXeeOYgpexIJgYAU 3bthev/JdtCDS80Pf9F97B7Z2Bi86VgfDL5RYs3sOANbHtR48pow9IIo09TohSm4o2t9 mFalStiy0QPi4KBHNmMXgQDIs3AkDDRBf1RomrTs+1O5ctB6/lHzs4diNmrI7aa9iwHR h5/QreRLF9Lkh3TomhDMoGv1yRSYNkhfJ17bfc6Zo0WeCPGOg0s6fA4ILv1gyHt7kWKr rVVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=rWVj9cB0VWQwjl49hmnp6oq16s8Sg76Jvrdztki9ovM=; b=jGwYr3Gvml9JUIDbYm81scrDwkZOq6cN8kht0UuxCNX99ToLMmZyv+lkn/cEu36f0v o2dTewcsXq6Ckqat5U4BFyPCbiT/Va41ZpjGnSJbpZjiJE9kkkebEG0V2fmv3RN2u9Ux JqMXUxvBucCpedT8JlLP3XXiUaEn/nNIN9UOJ3yvAeOZ8cL77XEUkNvPuKVTx04ppxJE FdpB+gDpyyTA2cg0pV2L2mpY8vvOLJbtgYCrOs3RU/weDt4vZKUdXtCk1MLiIn7ESy52 frmV81ocDjQBXnylqkb5llmliSCILS1epYT0nL7wNZVu+mJZZOcbb5aod6BH+Vx51UlW gq1A== X-Gm-Message-State: AJIora85LFs36uGP2syd1wWcG9Q1GASltQJUgKHHofLpBCnN6kbuz9s/ TJ0fBA+j90y3VVrhRcQ3zuH4RA== X-Google-Smtp-Source: AGRyM1v/Spw0q05cJy85iL1hTEZd/YVlAHKxhTynQaSAvhRK2q++zdYTesnBjzDNEIXAnOn8ANPOIg== X-Received: by 2002:a05:600c:3847:b0:39c:6a85:d20c with SMTP id s7-20020a05600c384700b0039c6a85d20cmr2905464wmr.129.1655973671000; Thu, 23 Jun 2022 01:41:11 -0700 (PDT) Received: from google.com (cpc155339-bagu17-2-0-cust87.1-3.cable.virginm.net. [86.27.177.88]) by smtp.gmail.com with ESMTPSA id g13-20020a5d488d000000b0021b86dbad37sm15645315wrq.68.2022.06.23.01.41.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jun 2022 01:41:10 -0700 (PDT) Date: Thu, 23 Jun 2022 09:41:08 +0100 From: Lee Jones To: Stefan Wahren Cc: Florian Fainelli , Ray Jui , Scott Branden , Peter Robinson , Melissa Wen , Phil Elwell , bcm-kernel-feedback-list@broadcom.com, Maxime Ripard , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH V3 07/11] mfd: bcm2835-pm: Add support for BCM2711 Message-ID: References: <20220607204226.8703-1-stefan.wahren@i2se.com> <20220607204226.8703-8-stefan.wahren@i2se.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220607204226.8703-8-stefan.wahren@i2se.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, 07 Jun 2022, Stefan Wahren wrote: > In BCM2711 the new RPiVid ASB took over V3D. The old ASB is still present > with the ISP and H264 bits, and V3D is in the same place in the new ASB > as the old one. > > As per the devicetree bindings, BCM2711 will provide both the old and > new ASB resources, so get both of them and pass them into > 'bcm2835-power,' which will take care of selecting which one to use > accordingly. > > Since the RPiVid ASB's resources were being provided prior to formalizing > the bindings[1], also support the old DT files that didn't use > 'reg-names.' > > Signed-off-by: Stefan Wahren > Reviewed-by: Peter Robinson > > [1] See: 7dbe8c62ceeb ("ARM: dts: Add minimal Raspberry Pi 4 support") > --- > drivers/mfd/bcm2835-pm.c | 21 +++++++++++++++++++++ > include/linux/mfd/bcm2835-pm.h | 1 + > 2 files changed, 22 insertions(+) > > diff --git a/drivers/mfd/bcm2835-pm.c b/drivers/mfd/bcm2835-pm.c > index ff0dae5a026d..4a2be669674a 100644 > --- a/drivers/mfd/bcm2835-pm.c > +++ b/drivers/mfd/bcm2835-pm.c > @@ -28,6 +28,8 @@ static const struct mfd_cell bcm2835_power_devs[] = { > static int bcm2835_pm_get_pdata(struct platform_device *pdev, > struct bcm2835_pm *pm) > { > + bool is_bcm2711 = of_device_is_compatible(pm->dev->of_node, "brcm,bcm2711-pm"); > + Since this is only used once, probably better to call of_device_is_compatible() in-place. > /* If no 'reg-names' property is found we can assume we're using old > * firmware. > */ > @@ -39,6 +41,7 @@ static int bcm2835_pm_get_pdata(struct platform_device *pdev, > return PTR_ERR(pm->base); > > pm->asb = devm_platform_ioremap_resource(pdev, 1); > + pm->rpivid_asb = devm_platform_ioremap_resource(pdev, 2); > } else { > struct resource *res; > > @@ -50,11 +53,28 @@ static int bcm2835_pm_get_pdata(struct platform_device *pdev, > "asb"); > if (res) > pm->asb = devm_ioremap_resource(&pdev->dev, res); > + > + res = platform_get_resource_byname(pdev, IORESOURCE_MEM, > + "rpivid_asb"); > + if (res) > + pm->rpivid_asb = devm_ioremap_resource(&pdev->dev, > + res); > } > > if (IS_ERR(pm->asb)) > pm->asb = NULL; > > + if (IS_ERR(pm->rpivid_asb)) > + pm->rpivid_asb = NULL; > + > + /* Ensure that rpivid_asb is set only for BCM2711, so subsequent > + * driver can rely on this and don't get confused by broken DTB. > + */ Please use proper formatting. > + if (pm->rpivid_asb && !is_bcm2711) { > + dev_err(pm->dev, "Unexpected rpivid_asb register, please fix your DTB.\n"); Not sure we should be validating values from DT like this. If incorrect hardware information is placed into DT, unexpected behaviour will occur. This is known. Perhaps a mention of this should be placed into the DT binding documentation, but checking for it here seems odd. Same goes for the previous patch come to think of it. Please remove the "update your DTB" warning from there too. > + return -EINVAL; > + } > + > return 0; > } > > @@ -95,6 +115,7 @@ static int bcm2835_pm_probe(struct platform_device *pdev) > static const struct of_device_id bcm2835_pm_of_match[] = { > { .compatible = "brcm,bcm2835-pm-wdt", }, > { .compatible = "brcm,bcm2835-pm", }, > + { .compatible = "brcm,bcm2711-pm", }, > {}, > }; > MODULE_DEVICE_TABLE(of, bcm2835_pm_of_match); > diff --git a/include/linux/mfd/bcm2835-pm.h b/include/linux/mfd/bcm2835-pm.h > index ed37dc40e82a..f70a810c55f7 100644 > --- a/include/linux/mfd/bcm2835-pm.h > +++ b/include/linux/mfd/bcm2835-pm.h > @@ -9,6 +9,7 @@ struct bcm2835_pm { > struct device *dev; > void __iomem *base; > void __iomem *asb; > + void __iomem *rpivid_asb; > }; > > #endif /* BCM2835_MFD_PM_H */ -- Lee Jones [李琼斯] Principal Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog