From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8D80C433EF for ; Thu, 23 Jun 2022 19:40:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231195AbiFWTkW (ORCPT ); Thu, 23 Jun 2022 15:40:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36858 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229661AbiFWTkH (ORCPT ); Thu, 23 Jun 2022 15:40:07 -0400 Received: from mail.netfilter.org (mail.netfilter.org [217.70.188.207]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id DCD96794D0 for ; Thu, 23 Jun 2022 12:29:43 -0700 (PDT) Date: Thu, 23 Jun 2022 21:29:41 +0200 From: Pablo Neira Ayuso To: Mikhail Sennikovsky Cc: netfilter-devel@vger.kernel.org, mikhail.sennikovsky@gmail.com Subject: Re: [PATCH 3/6] tests/conntrack: invalid protocol values Message-ID: References: <20220623175000.49259-1-mikhail.sennikovskii@ionos.com> <20220623175000.49259-4-mikhail.sennikovskii@ionos.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220623175000.49259-4-mikhail.sennikovskii@ionos.com> Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On Thu, Jun 23, 2022 at 07:49:57PM +0200, Mikhail Sennikovsky wrote: > Testcases covering passing invalid protocol values via -p parameter. > * -p 256 should fail > * -p foo should fail > which does not work properly at the moment. > Fix included in the next commit. Please, collapse this to next patch 4/6 in v2. > Signed-off-by: Mikhail Sennikovsky > --- > tests/conntrack/testsuite/00create | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/tests/conntrack/testsuite/00create b/tests/conntrack/testsuite/00create > index 9962e23..9fb3a0b 100644 > --- a/tests/conntrack/testsuite/00create > +++ b/tests/conntrack/testsuite/00create > @@ -61,3 +61,8 @@ > -D -s 0.0.0.0 -d 224.0.0.22 -r 224.0.0.22 -q 0.0.0.0 -p 200 ; OK > # delete again > -D -s 0.0.0.0 -d 224.0.0.22 -r 224.0.0.22 -q 0.0.0.0 -p 200 ; BAD > +# Invalid protocol values > +# 256 should fail > +-I -t 10 -s 1.1.1.1 -d 2.2.2.2 -r 2.2.2.2 -q 1.1.1.1 -p 256 ; BAD > +# take some invalid protocol name > +-I -t 10 -s 0.0.0.0 -d 224.0.0.22 -r 224.0.0.22 -q 0.0.0.0 -p foo ; BAD > -- > 2.25.1 >