From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1o4cch-0002Yo-V0 for mharc-grub-devel@gnu.org; Fri, 24 Jun 2022 02:16:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60712) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o4ccb-0002Wc-TK for grub-devel@gnu.org; Fri, 24 Jun 2022 02:16:51 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:44047) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o4ccZ-0007vg-Hy for grub-devel@gnu.org; Fri, 24 Jun 2022 02:16:49 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id A3D5D5C010E; Fri, 24 Jun 2022 02:16:44 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Fri, 24 Jun 2022 02:16:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pks.im; h=cc:cc :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1656051404; x=1656137804; bh=TpgZV5SemT KtnYGNLJyn4tDs6a11RACUZY1gj/RpUAY=; b=OsvKdHmDUwFRPXVX/taaps+54u LkXB48X2x6/barkWL0iPXbWJW/taS7Km3Prp5prZnsGTB85KEsAhqyWobhFk9oz3 AapExWHc2vMYHwi24ihJ2vHNyJWUi8IyMTd0QoGUYaMsUQuRp2sNEiXJ15VezvlG TT696DSFShV6pBx5ONaz8kKia6MwwFqUztKdFf0WwAVTXhOXAjYAL63BYzmK/cnn Z595dvwhYiK9kM1MznOV+K6EzZlcGmBAAJc5pQSpMwz1Ik32p4DzTonMbNohL0ZN VA3rlzErra8eQCYrFcJopfU4FpqAyltUBCUyNmNJWyIJ5yR7yglva5l3R/3A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1656051404; x=1656137804; bh=TpgZV5SemTKtnYGNLJyn4tDs6a11 RACUZY1gj/RpUAY=; b=oPB6bdzkOmHlAN2vAa1TkPW+aiWMwyu2IWhYf2gQ4h+p KF6JsVkx1kTdnC5vOH3hJ6FYb2jDeZiIeruPV9vjfjuHjwuY3GyiIo0aHlR5LRht lYLAMQQekJFvHrCvRHztUsi3+Cv+v59Xuu22Dy5iWM3u4uUyZkbQplbR5DOuw1gx gErgZWh/029PIW4z36SnON04lQlh8eEk/KYeRTHampgmY6YSmJqNr2qMRsVFhFgq A2lgOtTjw8X0z+2wNjUY2hQz/xq5Z9wdMCgkAevh0eb1c9bX/1RwSj7658dyKL7s 5qpIEf7m+0pCXwe8qv5lANSiPBWEf1PMLNCOJEGOZg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudefkedguddtjecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvvefukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpefrrght rhhitghkucfuthgvihhnhhgrrhguthcuoehpshesphhkshdrihhmqeenucggtffrrghtth gvrhhnpefhieeiuedvffevieegjeejffekkedtheelkedvkeehieelgfekfedvgedtkeef ieenucffohhmrghinhepghhnuhdrohhrghenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpehpshesphhkshdrihhm X-ME-Proxy: Feedback-ID: i197146af:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 24 Jun 2022 02:16:43 -0400 (EDT) Received: from localhost (xps [10.192.0.12]) by vm-mail.pks.im (OpenSMTPD) with ESMTPSA id 16a9fe57 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Fri, 24 Jun 2022 06:16:40 +0000 (UTC) Date: Fri, 24 Jun 2022 08:16:40 +0200 From: Patrick Steinhardt To: The development of GNU GRUB Cc: Stefan Berger , Daniel Axtens , leif@nuviainc.com Subject: Re: [PATCH v2 00/15] Dynamic allocation of memory regions and IBM vTPM v2 Message-ID: References: <20220328062240.878781-1-dja@axtens.net> <20220407144104.oau5itt3nk7fycfj@tomti.i.net-space.pl> <20220414153018.7ojgxpwpgq4ii6ej@tomti.i.net-space.pl> <33330aa2-abfd-d26d-7f33-800adbcce6ae@linux.ibm.com> <20220519163448.inz5r7ybpyasc5y5@tomti.i.net-space.pl> <20220623171604.reemwtpfl4h5wuvy@tomti.i.net-space.pl> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="vtjMAhFFl/WMRnj/" Content-Disposition: inline In-Reply-To: <20220623171604.reemwtpfl4h5wuvy@tomti.i.net-space.pl> Received-SPF: pass client-ip=66.111.4.27; envelope-from=ps@pks.im; helo=out3-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Jun 2022 06:16:53 -0000 --vtjMAhFFl/WMRnj/ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jun 23, 2022 at 07:16:04PM +0200, Daniel Kiper wrote: > Huh! For some reason I missed this email... Sorry folks about that! >=20 > On Sun, May 29, 2022 at 07:55:00AM +0200, Patrick Steinhardt wrote: > > On Thu, May 19, 2022 at 06:34:48PM +0200, Daniel Kiper wrote: > > > On Wed, May 18, 2022 at 11:24:48AM -0400, Stefan Berger wrote: > > > > On 4/14/22 11:30, Daniel Kiper wrote: > > > > > On Thu, Apr 07, 2022 at 04:41:04PM +0200, Daniel Kiper wrote: > > > > > > On Mon, Mar 28, 2022 at 05:22:25PM +1100, Daniel Axtens wrote: > > > > > > > Hi all, > > > > > > > > > > > > > > This is, at long last, an updated version of my series extend= ing Patrick's > > > > > > > dynamic memory regions to ieee1275. > > > > > > > > > > > > > > Noteworthy changes: > > > > > > > > > > > > > > - reworked debug prints as grub_dprintfs. Folded the ieee12= 75 ones into the > > > > > > > ieee1275 patches. > > > > > > > > > > > > > > - reworked the ieee1275 runtime memory claiming to be more = resilient and better > > > > > > > documented. > > > > > > > > > > > > > > - fixed comment style and hopefully addressed all other cha= nge requests. > > > > > > > > > > > > > > - grub will now try asking for contiguous memory and then, = if that fails, for > > > > > > > discontiguous memory - in case region merging with the di= scontiguous memory > > > > > > > is sufficient to allow the eventual allocation to succeed. > > > > > > > > > > > > Patrick, all mm and EFI code got my RB. Could you test it with = your > > > > > > Argon changes? If these changes pass your tests I will merge th= em. > > > > > > > > > > Patrick, ping? > > > > > > > > > > To be more precise, I am thinking about the patches up to #10. > > > > > > > > > > Daniel > > > > > > > > Any way we can make progress with this series before it gets all fo= rgotten > > > > about? > > > > > > It is not and it will not be forgotten. I am waiting for some allocat= or > > > tests reports. When I get them I will merge allocator stuff and review > > > the rest of the code from this patch series. Sadly folks who are going > > > to test the code are busy with other stuff. Though I am pinging them.= =2E. > > > > > > Anyway, sorry for delay... > > > > > > Daniel > > > > Sorry for the delay here, and thanks for the nudge. I've found a few > > quiet moments this morning to rebase my Argon2 patch series for LUKS2 on > > top of this series and found everything to work as expected. Decrypting > > a volume with a memory hardness of 2GB RAM worked just fine on an EFI > > x64 system. So this series is: > > > > Tested-by: Patrick Steinhardt >=20 > Patrick, thanks a lot for doing tests! >=20 > Here I would like to thank Patrick, Stefan, Daniel, Glenn and other > folks who were working on this feature! It is very important and long > awaited improvement for the GRUB memory manager (everyone who was > looking at it knows it is one of the most complicated parts of the > GRUB). This patch set unblocks and makes possible work on Argon2, > appended signature secure boot support, IBM vTPM, etc. >=20 > If I do not hear any objections by the end of this week I will be > pushing into master v3 of this patch set [1] (Patrick, I hope you are OK > with me adding your Tested-by there) together with the other patches > which got my RB up until now. Yes, I am. I noticed at a later point that I accidentally tested v2 and already re-did the tests on v3 with the same results. Patrick > I will be reviewing appended signature secure boot support, IBM vTPM, > etc. patches in the following weeks. >=20 > > I'm going to revive my own patch series and send it in for review > > soonish. The nice thing of having waited so long is that Argon2 support > > has meanwhile landed in libgcrypt, so that should make it easier to > > integrate it into GRUB. >=20 > Nice to hear that. >=20 > Daniel >=20 > [1] https://lists.gnu.org/archive/html/grub-devel/2022-04/msg00064.html >=20 > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel --vtjMAhFFl/WMRnj/ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEF9hrgiFbCdvenl/rVbJhu7ckPpQFAmK1VscACgkQVbJhu7ck PpQD2w//ea48RzoquVJlFsxDMveettHI03FZh6LDa/LAuAU4oC/kJSV9yqb112Ez wLP3zJ01UhHTLZwnvM7FXAOSOyR2G9eABr4irk7TdGERdN6vO2TTmjj4KMR6hnrU swVq69xMyqCK/0fNULqwHPnXgB19eQBVB4vqZrhJpvNieEAC2cyEsMzMqwRIWTiF YZCdvPgIY3Xe8HRAuPQMc9imguxC9L3pDyQpM6FK8VdTJzH+3xY5bqAC/perbhuL qmLqHYJWRxvbr/r1YY0489eZJKAhqSXhoMKYN2ovUiR6dRfbNpUFj+32Q87wQoIb k2B5+x/reWKIj9pd3wGx0+Y2yiWLXtRVhUnlO96YPdDe3pJlN7yjZxHPm+ILVOOC wavDe9G4hEkFUR7dc+SkX5e54TanljRZnCRJdrziueRtoOK67758n7qGW0jRy6E9 FSVrwHxt+5Qy+eFrBOh8Go/SHPEXt78b4rswt4RS83YSixb3zuCKnsqPU6yN8wRv BGx2TMbmEckJna+RNrKRfHC8yC0eXj0XIWrqrQPAsYvW8X6ZktwjaERe8qzBuWhn IIfxpnTnnpnTmSv+xzrmwrcajJ4mpzOSHyw4nsSS2YLnlK0kOHahoWo5Mmk4TzSE WkhbcVyxO0ZbBkNdQ9bFfag4+tHUB2rBq2kqTzSIbGul6Nuygu8= =3DQ4 -----END PGP SIGNATURE----- --vtjMAhFFl/WMRnj/--