From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Date: Fri, 24 Jun 2022 13:42:02 +0200 Subject: [PATCH] usb: gadget: Fix unsigned comparison with less than zero In-Reply-To: <20220623084347.38207-1-jiapeng.chong@linux.alibaba.com> References: <20220623084347.38207-1-jiapeng.chong@linux.alibaba.com> Message-ID: List-Id: To: linux-aspeed@lists.ozlabs.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Thu, Jun 23, 2022 at 04:43:47PM +0800, Jiapeng Chong wrote: > This was found by coccicheck: > > ./drivers/usb/gadget/udc/aspeed_udc.c:496:8-13: WARNING: Unsigned expression compared with zero: chunk >= 0. What does this mean? Where is the error? Please explain the reason for changes, not just the output of a random tool that you ran on the code. > Signed-off-by: Jiapeng Chong What commit does this fix? thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10AB2CCA473 for ; Fri, 24 Jun 2022 11:45:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231737AbiFXLpL (ORCPT ); Fri, 24 Jun 2022 07:45:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36882 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231713AbiFXLpH (ORCPT ); Fri, 24 Jun 2022 07:45:07 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 016967B36C; Fri, 24 Jun 2022 04:45:07 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 889376222A; Fri, 24 Jun 2022 11:45:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 627FBC34114; Fri, 24 Jun 2022 11:45:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1656071105; bh=/2OHaS3MR1kb2k5L74fvco5RgmKK7foP/ilWbPMO+Es=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lGpUqG7MHtWZJ87v8qMZ8ChuH6aRq0Gij61Z4bVzYhrhQQ75WsPx7c69tzhoaYEa/ aE7zP6Dl4KJISHZSD46fhRnKFzXrLYqEaopQSxpqsXrgsHRUcnpFJ70meLA4RJo6rq 9ak1wnwEgWOwgHNYSlzSXlnmIkBDzsReYMuNiYRs= Date: Fri, 24 Jun 2022 13:42:02 +0200 From: Greg KH To: Jiapeng Chong Cc: neal_liu@aspeedtech.com, balbi@kernel.org, joel@jms.id.au, andrew@aj.id.au, sumit.semwal@linaro.org, christian.koenig@amd.com, linux-aspeed@lists.ozlabs.org, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org Subject: Re: [PATCH] usb: gadget: Fix unsigned comparison with less than zero Message-ID: References: <20220623084347.38207-1-jiapeng.chong@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220623084347.38207-1-jiapeng.chong@linux.alibaba.com> Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Thu, Jun 23, 2022 at 04:43:47PM +0800, Jiapeng Chong wrote: > This was found by coccicheck: > > ./drivers/usb/gadget/udc/aspeed_udc.c:496:8-13: WARNING: Unsigned expression compared with zero: chunk >= 0. What does this mean? Where is the error? Please explain the reason for changes, not just the output of a random tool that you ran on the code. > Signed-off-by: Jiapeng Chong What commit does this fix? thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3D001C433EF for ; Fri, 24 Jun 2022 11:46:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=v90chI7igxUutIEb3tvK//of1BIgz8LPuB8iPiO+068=; b=FxKexeSE+78GEL v2g1WMKc0RfOXuyhzo+/VX2bQM4jnK+QX5VzWk/eXd8SGPRVNcKMjiMaqqT16lXCoPs2qV4NUZNI6 s31MpRZcKmcH7i1MjU7D+z0nfFrQAnj6YPYRLIXEychGI2CGgu0ojB0islAiHW7at4cFcOb3rqFe5 awllCiRxLkKgFvJoykzlf4Z6P54RzwG9pmeNQTn+Fc9ftIu8a0gp/EtUIfCQ7Y2YWewwu2HrC/BWN 2NsymTvaBFnxdVjlD3z2dp/c5AlZ86R+S7KLyFOXbu7xQb1Dl0GWtfL0IbJh/g8/sl1aVsq28PeXN xz/lG9HdB+wufbPHndRw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o4hkq-001zYz-8I; Fri, 24 Jun 2022 11:45:40 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o4hkK-001zJB-V9 for linux-arm-kernel@lists.infradead.org; Fri, 24 Jun 2022 11:45:10 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 4AC89B82843; Fri, 24 Jun 2022 11:45:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 627FBC34114; Fri, 24 Jun 2022 11:45:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1656071105; bh=/2OHaS3MR1kb2k5L74fvco5RgmKK7foP/ilWbPMO+Es=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lGpUqG7MHtWZJ87v8qMZ8ChuH6aRq0Gij61Z4bVzYhrhQQ75WsPx7c69tzhoaYEa/ aE7zP6Dl4KJISHZSD46fhRnKFzXrLYqEaopQSxpqsXrgsHRUcnpFJ70meLA4RJo6rq 9ak1wnwEgWOwgHNYSlzSXlnmIkBDzsReYMuNiYRs= Date: Fri, 24 Jun 2022 13:42:02 +0200 From: Greg KH To: Jiapeng Chong Cc: neal_liu@aspeedtech.com, balbi@kernel.org, joel@jms.id.au, andrew@aj.id.au, sumit.semwal@linaro.org, christian.koenig@amd.com, linux-aspeed@lists.ozlabs.org, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org Subject: Re: [PATCH] usb: gadget: Fix unsigned comparison with less than zero Message-ID: References: <20220623084347.38207-1-jiapeng.chong@linux.alibaba.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220623084347.38207-1-jiapeng.chong@linux.alibaba.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220624_044509_269677_E386AEC7 X-CRM114-Status: GOOD ( 10.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jun 23, 2022 at 04:43:47PM +0800, Jiapeng Chong wrote: > This was found by coccicheck: > > ./drivers/usb/gadget/udc/aspeed_udc.c:496:8-13: WARNING: Unsigned expression compared with zero: chunk >= 0. What does this mean? Where is the error? Please explain the reason for changes, not just the output of a random tool that you ran on the code. > Signed-off-by: Jiapeng Chong What commit does this fix? thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F1F41C433EF for ; Fri, 24 Jun 2022 11:45:14 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 453E110EE75; Fri, 24 Jun 2022 11:45:14 +0000 (UTC) Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by gabe.freedesktop.org (Postfix) with ESMTPS id 509D910EE6F for ; Fri, 24 Jun 2022 11:45:12 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 4AC89B82843; Fri, 24 Jun 2022 11:45:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 627FBC34114; Fri, 24 Jun 2022 11:45:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1656071105; bh=/2OHaS3MR1kb2k5L74fvco5RgmKK7foP/ilWbPMO+Es=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lGpUqG7MHtWZJ87v8qMZ8ChuH6aRq0Gij61Z4bVzYhrhQQ75WsPx7c69tzhoaYEa/ aE7zP6Dl4KJISHZSD46fhRnKFzXrLYqEaopQSxpqsXrgsHRUcnpFJ70meLA4RJo6rq 9ak1wnwEgWOwgHNYSlzSXlnmIkBDzsReYMuNiYRs= Date: Fri, 24 Jun 2022 13:42:02 +0200 From: Greg KH To: Jiapeng Chong Subject: Re: [PATCH] usb: gadget: Fix unsigned comparison with less than zero Message-ID: References: <20220623084347.38207-1-jiapeng.chong@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220623084347.38207-1-jiapeng.chong@linux.alibaba.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: balbi@kernel.org, linux-aspeed@lists.ozlabs.org, andrew@aj.id.au, neal_liu@aspeedtech.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, sumit.semwal@linaro.org, linaro-mm-sig@lists.linaro.org, joel@jms.id.au, christian.koenig@amd.com, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, Jun 23, 2022 at 04:43:47PM +0800, Jiapeng Chong wrote: > This was found by coccicheck: > > ./drivers/usb/gadget/udc/aspeed_udc.c:496:8-13: WARNING: Unsigned expression compared with zero: chunk >= 0. What does this mean? Where is the error? Please explain the reason for changes, not just the output of a random tool that you ran on the code. > Signed-off-by: Jiapeng Chong What commit does this fix? thanks, greg k-h