From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 27BC3C433EF for ; Fri, 24 Jun 2022 15:01:01 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4C0B410E1B2; Fri, 24 Jun 2022 15:01:00 +0000 (UTC) Received: from relay12.mail.gandi.net (relay12.mail.gandi.net [IPv6:2001:4b98:dc4:8::232]) by gabe.freedesktop.org (Postfix) with ESMTPS id 20F9310E1B2 for ; Fri, 24 Jun 2022 15:00:57 +0000 (UTC) Received: (Authenticated sender: paul.kocialkowski@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 074A720000F; Fri, 24 Jun 2022 15:00:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1656082855; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2qXzzJoUbs4d2QN18DeeUOD79uKu2pCH/VKOYe0ryJU=; b=AdugIn5IrOuegRe1MgJXvlpSkfmQeoFzYPsWm/Es3Pas0v/xU3CPJ6FNRpYajhiCbnbNrc jBAYXShmAT94eI3n0JnS9nUCidQbFzj9MpmasgvEoZENyVkJmdP/Ruqwf9BYzy2A3TWAzc c8gEzP6wGu9vTzov5/vxd3R0yf6l6eYNUdvI2iB9eX4ehz3JI87eSavJY/I+Kta1n6yisO Y1/jovWvDOJuGY1lpPVBZkaAni/6rOUpknlQiTBEfZNI+fjmVM+Xnp9E/29TsPRdRaUxli aQGB5L5HL5HCH58CziTaZ63MeTIaekGkqX9g4pJvjJ0LqZBi0Og8sm/ugpD58A== Date: Fri, 24 Jun 2022 17:00:54 +0200 From: Paul Kocialkowski To: Yang Li Subject: Re: [PATCH -next] drm: Remove unnecessary print function dev_err() Message-ID: References: <20220613012658.85814-1-yang.lee@linux.alibaba.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="veaIlB3NsqQJBjp+" Content-Disposition: inline In-Reply-To: <20220613012658.85814-1-yang.lee@linux.alibaba.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: airlied@linux.ie, Abaci Robot , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" --veaIlB3NsqQJBjp+ Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Yang, On Mon 13 Jun 22, 09:26, Yang Li wrote: > The print function dev_err() is redundant because platform_get_irq() > already prints an error. >=20 > Eliminate the follow coccicheck warning: > ./drivers/gpu/drm/logicvc/logicvc_drm.c:352:2-9: line 352 is redundant > because platform_get_irq() already prints an error >=20 > Reported-by: Abaci Robot > Signed-off-by: Yang Li Thanks for the patch! Acked-by: Paul Kocialkowski Paul > --- > drivers/gpu/drm/logicvc/logicvc_drm.c | 1 - > 1 file changed, 1 deletion(-) >=20 > diff --git a/drivers/gpu/drm/logicvc/logicvc_drm.c b/drivers/gpu/drm/logi= cvc/logicvc_drm.c > index df1805cf0f95..437b3011ae1e 100644 > --- a/drivers/gpu/drm/logicvc/logicvc_drm.c > +++ b/drivers/gpu/drm/logicvc/logicvc_drm.c > @@ -349,7 +349,6 @@ static int logicvc_drm_probe(struct platform_device *= pdev) > =20 > irq =3D platform_get_irq(pdev, 0); > if (irq < 0) { > - dev_err(dev, "Failed to get IRQ\n"); > ret =3D -ENODEV; > goto error_reserved_mem; > } > --=20 > 2.20.1.7.g153144c >=20 --=20 Paul Kocialkowski, Bootlin Embedded Linux and kernel engineering https://bootlin.com --veaIlB3NsqQJBjp+ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEJZpWjZeIetVBefti3cLmz3+fv9EFAmK10aYACgkQ3cLmz3+f v9EGeQf/Q01Lx/F9D+C2pQeGKz3ffuzTDhSn3Tm7+EUUsYblieed+d8NDOXdDSWF dkkdvlubJP2VOLFRioFp6JbCmPW5ul7CdTE8sYtefj8Kdt/ghau8j5KI6kN4CM+L SvCfuS8dc7Av3mfSWW/7vURJO3oLs1MnAEKZAdK+yYhBRoih8200mo8AC0leuVz/ 5f/zmyQ5C2COwQ/vkG8YMoGpDJIk65jvxlBqbRv80bfLCoNY4gLEG4m/3TpSZNk9 FtXolEz03RckdXsuT3tqXUmHQ7WTWgjfk7v+xuKJ83nj10Xgw9ImGoyVjBVkef3O lyYYhtTL4IkrQ86COfhQijTeByJe3A== =7pE3 -----END PGP SIGNATURE----- --veaIlB3NsqQJBjp+-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93DABC43334 for ; Fri, 24 Jun 2022 15:01:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232463AbiFXPBv (ORCPT ); Fri, 24 Jun 2022 11:01:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43498 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232852AbiFXPBg (ORCPT ); Fri, 24 Jun 2022 11:01:36 -0400 Received: from relay12.mail.gandi.net (relay12.mail.gandi.net [IPv6:2001:4b98:dc4:8::232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 734EA7E037 for ; Fri, 24 Jun 2022 08:00:58 -0700 (PDT) Received: (Authenticated sender: paul.kocialkowski@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 074A720000F; Fri, 24 Jun 2022 15:00:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1656082855; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2qXzzJoUbs4d2QN18DeeUOD79uKu2pCH/VKOYe0ryJU=; b=AdugIn5IrOuegRe1MgJXvlpSkfmQeoFzYPsWm/Es3Pas0v/xU3CPJ6FNRpYajhiCbnbNrc jBAYXShmAT94eI3n0JnS9nUCidQbFzj9MpmasgvEoZENyVkJmdP/Ruqwf9BYzy2A3TWAzc c8gEzP6wGu9vTzov5/vxd3R0yf6l6eYNUdvI2iB9eX4ehz3JI87eSavJY/I+Kta1n6yisO Y1/jovWvDOJuGY1lpPVBZkaAni/6rOUpknlQiTBEfZNI+fjmVM+Xnp9E/29TsPRdRaUxli aQGB5L5HL5HCH58CziTaZ63MeTIaekGkqX9g4pJvjJ0LqZBi0Og8sm/ugpD58A== Date: Fri, 24 Jun 2022 17:00:54 +0200 From: Paul Kocialkowski To: Yang Li Cc: airlied@linux.ie, daniel@ffwll.ch, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Abaci Robot Subject: Re: [PATCH -next] drm: Remove unnecessary print function dev_err() Message-ID: References: <20220613012658.85814-1-yang.lee@linux.alibaba.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="veaIlB3NsqQJBjp+" Content-Disposition: inline In-Reply-To: <20220613012658.85814-1-yang.lee@linux.alibaba.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --veaIlB3NsqQJBjp+ Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Yang, On Mon 13 Jun 22, 09:26, Yang Li wrote: > The print function dev_err() is redundant because platform_get_irq() > already prints an error. >=20 > Eliminate the follow coccicheck warning: > ./drivers/gpu/drm/logicvc/logicvc_drm.c:352:2-9: line 352 is redundant > because platform_get_irq() already prints an error >=20 > Reported-by: Abaci Robot > Signed-off-by: Yang Li Thanks for the patch! Acked-by: Paul Kocialkowski Paul > --- > drivers/gpu/drm/logicvc/logicvc_drm.c | 1 - > 1 file changed, 1 deletion(-) >=20 > diff --git a/drivers/gpu/drm/logicvc/logicvc_drm.c b/drivers/gpu/drm/logi= cvc/logicvc_drm.c > index df1805cf0f95..437b3011ae1e 100644 > --- a/drivers/gpu/drm/logicvc/logicvc_drm.c > +++ b/drivers/gpu/drm/logicvc/logicvc_drm.c > @@ -349,7 +349,6 @@ static int logicvc_drm_probe(struct platform_device *= pdev) > =20 > irq =3D platform_get_irq(pdev, 0); > if (irq < 0) { > - dev_err(dev, "Failed to get IRQ\n"); > ret =3D -ENODEV; > goto error_reserved_mem; > } > --=20 > 2.20.1.7.g153144c >=20 --=20 Paul Kocialkowski, Bootlin Embedded Linux and kernel engineering https://bootlin.com --veaIlB3NsqQJBjp+ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEJZpWjZeIetVBefti3cLmz3+fv9EFAmK10aYACgkQ3cLmz3+f v9EGeQf/Q01Lx/F9D+C2pQeGKz3ffuzTDhSn3Tm7+EUUsYblieed+d8NDOXdDSWF dkkdvlubJP2VOLFRioFp6JbCmPW5ul7CdTE8sYtefj8Kdt/ghau8j5KI6kN4CM+L SvCfuS8dc7Av3mfSWW/7vURJO3oLs1MnAEKZAdK+yYhBRoih8200mo8AC0leuVz/ 5f/zmyQ5C2COwQ/vkG8YMoGpDJIk65jvxlBqbRv80bfLCoNY4gLEG4m/3TpSZNk9 FtXolEz03RckdXsuT3tqXUmHQ7WTWgjfk7v+xuKJ83nj10Xgw9ImGoyVjBVkef3O lyYYhtTL4IkrQ86COfhQijTeByJe3A== =7pE3 -----END PGP SIGNATURE----- --veaIlB3NsqQJBjp+--