From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8879AC43334 for ; Fri, 24 Jun 2022 15:20:08 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 751D910E099; Fri, 24 Jun 2022 15:20:07 +0000 (UTC) Received: from mailrelay3-1.pub.mailoutpod1-cph3.one.com (mailrelay3-1.pub.mailoutpod1-cph3.one.com [46.30.210.184]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4CB2610E0AB for ; Fri, 24 Jun 2022 15:20:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ravnborg.org; s=rsa1; h=in-reply-to:content-type:mime-version:references:message-id:subject:cc:to: from:date:from; bh=7C9om+I+NrguXJkyfDjb3usH2nDZbeYzg3Ij5DWZ8PE=; b=enkPuvVq9cxeak4xvbnLzPDtpwYYeLlQY+XCO9nkEHva9i0GHJmTYBtQvRdkfzbo8qX/TcFHMKSrh DxVVnB5eq+K9y3klNx9LBU5ho8yjqCW29X2UsTM644sxM0+eoeuYulYZbwgrV/6TT3iveTIRpWH3TT GVbkg8BuPncEAOR4dU7Ac/XmzlVlICv4riTUTBGAkq36XgIcBLCV+tUwIm3U+tKM2sloQ5RNMYj1A7 8Eg7JPPIpylbUKZVtsTLqrdj/m8RtgoSG6AIGQKRhUEYjbm6GdRvlVIGVOWrS8Z6izO10eeDTH0lj3 z0ndmK0zK4ZpzCCOyzg1vG3XIdI+s0w== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ravnborg.org; s=ed1; h=in-reply-to:content-type:mime-version:references:message-id:subject:cc:to: from:date:from; bh=7C9om+I+NrguXJkyfDjb3usH2nDZbeYzg3Ij5DWZ8PE=; b=2kLU4Ts7UAvd1RJBZ9aDOh7pa1IwpwCGgT4QufeEpjpKKIhJKCPZMDbu9IoyplI2gEP31l0qbVfyy D59UN+OAg== X-HalOne-Cookie: 9f7a75cd0428a0af88a75a96aa819a7f9526c1bb X-HalOne-ID: 1e02ca40-f3d1-11ec-be7c-d0431ea8bb03 Received: from mailproxy3.cst.dirpod3-cph3.one.com (80-162-45-141-cable.dk.customer.tdc.net [80.162.45.141]) by mailrelay3.pub.mailoutpod1-cph3.one.com (Halon) with ESMTPSA id 1e02ca40-f3d1-11ec-be7c-d0431ea8bb03; Fri, 24 Jun 2022 15:20:02 +0000 (UTC) Date: Fri, 24 Jun 2022 17:20:00 +0200 From: Sam Ravnborg To: Lucas Stach Subject: Re: [PATCH v5 2/2] drm: lcdif: Add support for i.MX8MP LCDIF variant Message-ID: References: <20220613213124.617021-1-marex@denx.de> <20220613213124.617021-2-marex@denx.de> <7b3850665f7fd699ff7d0a013e5652159d4b5055.camel@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7b3850665f7fd699ff7d0a013e5652159d4b5055.camel@pengutronix.de> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marek Vasut , Peng Fan , Alexander Stein , robert.foss@linaro.org, Martyn Welch , dri-devel@lists.freedesktop.org, Robby Cai , Laurent Pinchart Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" > > + > > +static int lcdif_rpm_resume(struct device *dev) > > +{ > > + struct drm_device *drm = dev_get_drvdata(dev); > > + struct lcdif_drm_private *lcdif = drm->dev_private; > > + > > + /* These clock supply the Control Bus, APB, APBH Ctrl Registers */ > > + clk_prepare_enable(lcdif->clk_axi); > > + /* These clock supply the System Bus, AXI, Write Path, LFIFO */ > > + clk_prepare_enable(lcdif->clk_disp_axi); > > + /* These clock supply the DISPLAY CLOCK Domain */ > > + clk_prepare_enable(lcdif->clk); > > + > > + return 0; > > +} > > + > > To avoid unused function warnings, suspend and resume should be under > #ifdef CONFIG_PM_SLEEP If SET_RUNTIME_PM_OPS is used then it is good practice to annotate the functions __maybe_unused and no #ifdef - then they see build coverage also without PM_SLEEP but they are discarded so do not consume memory if not used. Sam