From: Hongren Zheng <i@zenithal.me>
To: MkfsSion <mkfssion@mkfssion.com>
Cc: qemu-devel@nongnu.org, "Canokeys.org" <contact@canokeys.org>
Subject: Re: [PATCH v3 2/2] docs/system/devices/canokey: Document limitations on usb-ehci
Date: Sat, 25 Jun 2022 00:11:05 +0800 [thread overview]
Message-ID: <YrXiGXY8lo3zpVZ6@Sun> (raw)
In-Reply-To: <20220624152940.11756-2-mkfssion@mkfssion.com>
On Fri, Jun 24, 2022 at 11:29:40PM +0800, MkfsSion wrote:
>
> -Another limitation is that this device is not compatible with ``qemu-xhci``,
> -in that this device would hang when there are FIDO2 packets (traffic on
> -interrupt endpoints). If you do not use FIDO2 then it works as intended,
> -but for full functionality you should use old uhci/ehci bus and attach canokey
> -to it, for example
> -
> -.. parsed-literal::
> -
> - |qemu_system| -device piix3-usb-uhci,id=uhci -device canokey,bus=uhci.0
Hi, the fix for the limitation on qemu-xhci has not been landed and should not
be removed by this patch.
> +Another limitation is that this device is not compatible with ``usb-ehci``
> +since we removed high-speed mode support. When a full-speed device attach
> +to a high-speed port, ``usb-ehci`` would complain about speed mismatch.
I think we could rephrase the limitation here. Instead of saying "we
removed the high-speed mode", how about saying "this device only
provides the full-speed mode".
Also you should list the changes between two PATCH versions
below the --- line just after your commit message
so the mailing list can track what happened.
Regards,
Hongren
prev parent reply other threads:[~2022-06-24 16:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-24 15:29 [PATCH v3 1/2] hw: canokey: Remove HS support as not compliant to the spec MkfsSion
2022-06-24 15:29 ` [PATCH v3 2/2] docs/system/devices/canokey: Document limitations on usb-ehci MkfsSion
2022-06-24 16:11 ` Hongren Zheng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YrXiGXY8lo3zpVZ6@Sun \
--to=i@zenithal.me \
--cc=contact@canokeys.org \
--cc=mkfssion@mkfssion.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.