From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64170C433EF for ; Fri, 24 Jun 2022 23:41:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231510AbiFXXlm (ORCPT ); Fri, 24 Jun 2022 19:41:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37562 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229840AbiFXXll (ORCPT ); Fri, 24 Jun 2022 19:41:41 -0400 Received: from mail-pl1-x62f.google.com (mail-pl1-x62f.google.com [IPv6:2607:f8b0:4864:20::62f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A2E3A89D32 for ; Fri, 24 Jun 2022 16:41:40 -0700 (PDT) Received: by mail-pl1-x62f.google.com with SMTP id o18so3362760plg.2 for ; Fri, 24 Jun 2022 16:41:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=3xnBvzrRmX/ejhmjRn6AoNfZ6p3RCpkOG+Vy08xprps=; b=AS3DaGG61PYQBaU/p+BC2EOrkBhfu3MaqbJkNmutFIQKb6hE58NVV2T2HN5MPwWFKa cRf7njThcQFyvGXySMvrsvwCo02+qfboGW1pVKbYwZ24zTxDlM4SdkOlaaDFVJvDXPIL OetXbsRtBoPDnOt5HdCQ3Q5JqWpf8ZVwSOnb3+xYio8ZK4/NjtBacXonZ1fqjV8WXYXl WU3NZOiVBo3AsoXU3X5dmZemrU+NDtUm4b9Yn4FBO/V9W87+Q3OJ5LZc/Nwe2iFLrDsE ZinA615CpiS5kp60zPU5bVWNiOI19/qMTyJP5t7KTw/k98Pz4cOoPF8LyMsswOMQr1cy oMiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=3xnBvzrRmX/ejhmjRn6AoNfZ6p3RCpkOG+Vy08xprps=; b=VC56c5n7R+lYMFZ3w3iYGvW1DSe3CzMMfIaChX6vWIjdsjMLLcLqw3/zOmazJFour2 z32KwP9V4wO57NKkPFzsGeAVSmS7RHVmt3nn/dJ4JvuqjfzBb+kuU/C3BYjfC6gF+hwh 1/pv89x9QMoQRt5GegC0dUw/iz1M96A72k4jdsOoeiuP9SddqLl+7AjRL/No1WkNDbeu I/YH9zpSGt2LQxlzdKCW+IsJFQ9NgItwKtPrzCDR1Ik6cmwOJvlACLVjq3J2VvGODKjE kkYGitSa2tUEvXpJ/5p/TiESUV7CNjnyNvuJq5L1VS1RTA+RPlYBaJ3O29zTsMIzrnO2 ix9g== X-Gm-Message-State: AJIora8aB852kAfXy28G+XuZCjcxU5MMU2inXJLc4gnHFRW82nd8J9at 5ufLvIfB98tP7UOeVdebpe694w== X-Google-Smtp-Source: AGRyM1uzvJMxrnVztGfw3Vxr8c4HN/RJBw6KcIENR+surAs1biy9lt0CP8HFqlurE+rRWKy50934fQ== X-Received: by 2002:a17:902:d712:b0:167:757c:a6f4 with SMTP id w18-20020a170902d71200b00167757ca6f4mr1476590ply.5.1656114100011; Fri, 24 Jun 2022 16:41:40 -0700 (PDT) Received: from google.com (223.103.125.34.bc.googleusercontent.com. [34.125.103.223]) by smtp.gmail.com with ESMTPSA id 2-20020a170902c24200b0016a6130128bsm2352299plg.211.2022.06.24.16.41.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jun 2022 16:41:39 -0700 (PDT) Date: Fri, 24 Jun 2022 23:41:34 +0000 From: David Matlack To: Sean Christopherson Cc: Paolo Bonzini , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/4] KVM: x86/mmu: Add optimized helper to retrieve an SPTE's index Message-ID: References: <20220624213039.2872507-1-seanjc@google.com> <20220624213039.2872507-2-seanjc@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220624213039.2872507-2-seanjc@google.com> Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Fri, Jun 24, 2022 at 09:30:36PM +0000, Sean Christopherson wrote: > Add spte_index() to dedup all the code that calculates a SPTE's index > into its parent's page table and/or spt array. Opportunistically tweak > the calculation to avoid pointer arithmetic, which is subtle (subtract in > 8-byte chunks) and less performant (requires the compiler to generate the > subtraction). > > Suggested-by: David Matlack > Signed-off-by: Sean Christopherson Thanks for the cleanup. I did a git-grep to look for any other users to convert to spte_index() and didn't find any. Reviewed-by: David Matlack