From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 35211C43334 for ; Sat, 25 Jun 2022 06:51:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LSWqp0ufQDuhwaltYhEmQxcGCsq9qPk876Pg61bdajQ=; b=qtystFVeUFYzim Y4siB0AAU/OsjmM3WeKqQofFjhF0XVrSyHUdsCLEaVsbMp+jfLn1l+tk414+3sBf8D7mX2ZRZrfHj UbhWmpO+YdCfTbaJWyKxSmUQZSjnW2ET42rOAqS/Mc9eVl+qNMtPaW0rrpqCaEjHNWu8AitHHKeKb 9wmATsCfyhPtBANihguMgSfFJca372crU0gayqg6rn5YZ80hVA/3YTMGZW3UASF8NLDdzMQEWOJ4U zhKCWtJ/6klAvYt3jJ9P//Wt6F7xmau2etOXgUL/NjVMfWWVPY627a7HvtG2ngGyRjl//UqFULsHA qCAQeYoBIwIGsFE5w+7g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o4zdc-004uWX-QV; Sat, 25 Jun 2022 06:51:24 +0000 Received: from vps0.lunn.ch ([185.16.172.187]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o4zda-004uVC-C3; Sat, 25 Jun 2022 06:51:23 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=DpRcewL0IJOgcup/joXmgDicwFFYm/SKIQKzwXVWCV0=; b=S17dD0BnFVszDueqzqzCO7RBSt L8S1H8njwdNi0KtUNa68tSCRzXhWS+0i/kpyzIF2vo00VrkjZ0Tzt02jQFC3IzLKPPaO6OB7fdH5j UolqLyN+Rbjdv0TyiyzlIKYcWObsFlZvE7uZKigOIOOstQuSclpBhlMIVNyXeYjE60BE=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1o4zdB-008AWB-Sz; Sat, 25 Jun 2022 08:50:57 +0200 Date: Sat, 25 Jun 2022 08:50:57 +0200 From: Andrew Lunn To: Peter Geis Cc: Sebastian Reichel , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Linux Kernel Network Developers , "open list:ARM/Rockchip SoC..." , arm-mail-list , devicetree , David Wu , kernel@collabora.com Subject: Re: [PATCH 1/3] net: ethernet: stmmac: dwmac-rk: Disable delayline if it is invalid Message-ID: References: <20220623162850.245608-1-sebastian.reichel@collabora.com> <20220623162850.245608-2-sebastian.reichel@collabora.com> <20220624162956.vn4b3va5cz2agvrb@mercury.elektranox.org> <20220624173547.ccads2mikb4np5wz@mercury.elektranox.org> <20220624201537.l7p6aoquvvadmpei@mercury.elektranox.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220624_235122_449109_C3021DD9 X-CRM114-Status: UNSURE ( 9.78 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org > The driver already sets the delays to 0 in case of the rgmii-id modes. > 0 is disabled, even in this patch. The only thing this patch does is > change the behavior when the delays are not set. If the rx delays > should be 0, they should be defined as 0 in the device tree. There is > rgmii-rxid for a reason as well, but if they are setting the rx delay > to 0 with rgmii that implies this hardware is fundamentally broken. Or the delay is implemented by longer tracks on the PCB. It happens sometimes, but not very often. Andrew _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2B1F9C433EF for ; Sat, 25 Jun 2022 06:52:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HEFrXQ7MSYKzr4l+elejrymmWEqeXHKghzUqM2/IyUc=; b=deAOBvmV/aQHUo c/6EaSwF8/DTZUTCcQGrsYgRzX4huueCHfLdaAVdnUwJmtkZtlxpUl0gX0Dh1x7h4xRHABfh0LOjA fYA9CK/FYfy/2Ws+N30iZUK++ucqltTcAsrnC6OL97kb2hCI6aCgl+T8tpwxM9+Mq6BxxqtKjUKEM fld6goFvr/wwNBkL8QzrY+huS5sfE7MminbznHOivMFoJ2cOFqWnohfuC/prYqQ6hmmmRVoFDP3mz kifeqMIz/HQP7z3ujiHu2r4O2BB0jrbOrVZTQV9mzuThx3UilMAcY8wzXfTULQy7oz/Ck8qZttrTy zMxVikSCRUCOMqY8nKaw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o4zdd-004uWd-Lw; Sat, 25 Jun 2022 06:51:25 +0000 Received: from vps0.lunn.ch ([185.16.172.187]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o4zda-004uVC-C3; Sat, 25 Jun 2022 06:51:23 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=DpRcewL0IJOgcup/joXmgDicwFFYm/SKIQKzwXVWCV0=; b=S17dD0BnFVszDueqzqzCO7RBSt L8S1H8njwdNi0KtUNa68tSCRzXhWS+0i/kpyzIF2vo00VrkjZ0Tzt02jQFC3IzLKPPaO6OB7fdH5j UolqLyN+Rbjdv0TyiyzlIKYcWObsFlZvE7uZKigOIOOstQuSclpBhlMIVNyXeYjE60BE=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1o4zdB-008AWB-Sz; Sat, 25 Jun 2022 08:50:57 +0200 Date: Sat, 25 Jun 2022 08:50:57 +0200 From: Andrew Lunn To: Peter Geis Cc: Sebastian Reichel , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Linux Kernel Network Developers , "open list:ARM/Rockchip SoC..." , arm-mail-list , devicetree , David Wu , kernel@collabora.com Subject: Re: [PATCH 1/3] net: ethernet: stmmac: dwmac-rk: Disable delayline if it is invalid Message-ID: References: <20220623162850.245608-1-sebastian.reichel@collabora.com> <20220623162850.245608-2-sebastian.reichel@collabora.com> <20220624162956.vn4b3va5cz2agvrb@mercury.elektranox.org> <20220624173547.ccads2mikb4np5wz@mercury.elektranox.org> <20220624201537.l7p6aoquvvadmpei@mercury.elektranox.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220624_235122_449109_C3021DD9 X-CRM114-Status: UNSURE ( 9.78 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > The driver already sets the delays to 0 in case of the rgmii-id modes. > 0 is disabled, even in this patch. The only thing this patch does is > change the behavior when the delays are not set. If the rx delays > should be 0, they should be defined as 0 in the device tree. There is > rgmii-rxid for a reason as well, but if they are setting the rx delay > to 0 with rgmii that implies this hardware is fundamentally broken. Or the delay is implemented by longer tracks on the PCB. It happens sometimes, but not very often. Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88961C433EF for ; Sat, 25 Jun 2022 06:51:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230077AbiFYGv1 (ORCPT ); Sat, 25 Jun 2022 02:51:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54486 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229931AbiFYGv1 (ORCPT ); Sat, 25 Jun 2022 02:51:27 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [185.16.172.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B61AE4477E; Fri, 24 Jun 2022 23:51:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=DpRcewL0IJOgcup/joXmgDicwFFYm/SKIQKzwXVWCV0=; b=S17dD0BnFVszDueqzqzCO7RBSt L8S1H8njwdNi0KtUNa68tSCRzXhWS+0i/kpyzIF2vo00VrkjZ0Tzt02jQFC3IzLKPPaO6OB7fdH5j UolqLyN+Rbjdv0TyiyzlIKYcWObsFlZvE7uZKigOIOOstQuSclpBhlMIVNyXeYjE60BE=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1o4zdB-008AWB-Sz; Sat, 25 Jun 2022 08:50:57 +0200 Date: Sat, 25 Jun 2022 08:50:57 +0200 From: Andrew Lunn To: Peter Geis Cc: Sebastian Reichel , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Linux Kernel Network Developers , "open list:ARM/Rockchip SoC..." , arm-mail-list , devicetree , David Wu , kernel@collabora.com Subject: Re: [PATCH 1/3] net: ethernet: stmmac: dwmac-rk: Disable delayline if it is invalid Message-ID: References: <20220623162850.245608-1-sebastian.reichel@collabora.com> <20220623162850.245608-2-sebastian.reichel@collabora.com> <20220624162956.vn4b3va5cz2agvrb@mercury.elektranox.org> <20220624173547.ccads2mikb4np5wz@mercury.elektranox.org> <20220624201537.l7p6aoquvvadmpei@mercury.elektranox.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org > The driver already sets the delays to 0 in case of the rgmii-id modes. > 0 is disabled, even in this patch. The only thing this patch does is > change the behavior when the delays are not set. If the rx delays > should be 0, they should be defined as 0 in the device tree. There is > rgmii-rxid for a reason as well, but if they are setting the rx delay > to 0 with rgmii that implies this hardware is fundamentally broken. Or the delay is implemented by longer tracks on the PCB. It happens sometimes, but not very often. Andrew