From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3CC47C433EF for ; Sat, 25 Jun 2022 06:59:19 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E2AA3112E8F; Sat, 25 Jun 2022 06:59:17 +0000 (UTC) Received: from mailrelay3-1.pub.mailoutpod1-cph3.one.com (mailrelay3-1.pub.mailoutpod1-cph3.one.com [46.30.210.184]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6275B112E97 for ; Sat, 25 Jun 2022 06:59:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ravnborg.org; s=rsa1; h=in-reply-to:content-type:mime-version:references:message-id:subject:cc:to: from:date:from; bh=Bx/qs0NbtThx6IT3iLp2kkGrJRu7KCQ5k9Hn0oNQZ/Y=; b=YXeA4/j/3XZ6S4r9jC5aAj7pbyJuP8CSCkgxovdEDc9TDbFOBqWTCpUzmxCizP1RRHWjpz3GvYFC0 hFdD/S09JeBHQ9tL0wTUit/3Y4Z2sGHK1sr+Hl8XdP7SXWs83Ta+6Cx11/iFfIi42bfnmGXU+2CbC1 /UPsf+E84+YjpznwhT4qeP0Ralx8P6xqn8MxNtVQNMQ8xHx9HD38mge/8Bvzcc5cYpULs8ETlCEe8r 11K6RYqOOe33z0Onsx+KxP4m+codiP04GROJqk8HVNEAYjxFH+j3qoBpYWvMrBjWnL3Ak1DvqonbsN Ko3maXSkF0vWleqorPmFCTj61RQGqBw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ravnborg.org; s=ed1; h=in-reply-to:content-type:mime-version:references:message-id:subject:cc:to: from:date:from; bh=Bx/qs0NbtThx6IT3iLp2kkGrJRu7KCQ5k9Hn0oNQZ/Y=; b=sm9/YFgqpRRLFStvT4UcvJJFdASyug4bGMos2doS24I6gpAlhLsUlH4WHlTa4vi+46oplDeC1Dn78 p9yiNEjBw== X-HalOne-Cookie: 99c87bbbc0a59b656e79a037534ce5e53b4b6972 X-HalOne-ID: 52838c54-f454-11ec-be7c-d0431ea8bb03 Received: from mailproxy1.cst.dirpod3-cph3.one.com (80-162-45-141-cable.dk.customer.tdc.net [80.162.45.141]) by mailrelay3.pub.mailoutpod1-cph3.one.com (Halon) with ESMTPSA id 52838c54-f454-11ec-be7c-d0431ea8bb03; Sat, 25 Jun 2022 06:59:14 +0000 (UTC) Date: Sat, 25 Jun 2022 08:59:12 +0200 From: Sam Ravnborg To: Kevin Brace Subject: Re: [PATCH 08/28] drm/via: Add via_cursor.c Message-ID: References: <20220624202633.3978-1-kevinbrace@gmx.com> <20220624202633.3978-9-kevinbrace@gmx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220624202633.3978-9-kevinbrace@gmx.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Brace , dri-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Kevin, a few nitpicks in the following. Sam On Fri, Jun 24, 2022 at 03:26:13PM -0500, Kevin Brace wrote: > From: Kevin Brace > > Signed-off-by: Kevin Brace > --- > drivers/gpu/drm/via/via_cursor.c | 419 +++++++++++++++++++++++++++++++ > 1 file changed, 419 insertions(+) > create mode 100644 drivers/gpu/drm/via/via_cursor.c > > + DRM_DEBUG_KMS("Exiting %s.\n", __func__); The use of the DRM_* for logging is deprecated these days. The recommended variants are names drm_dbg_* and friends. They require a drm_device, and in lack of this use dev_dbg or fallback to pr_* This applies for all the driver, not only this file. > + > +const struct drm_plane_funcs via_cursor_drm_plane_funcs = { > + .update_plane = drm_atomic_helper_update_plane, > + .disable_plane = drm_atomic_helper_disable_plane, > + .destroy = drm_plane_cleanup, > + .reset = drm_atomic_helper_plane_reset, > + .atomic_duplicate_state = drm_atomic_helper_plane_duplicate_state, > + .atomic_destroy_state = drm_atomic_helper_plane_destroy_state, > +}; > + > +const uint32_t via_cursor_formats[] = { > + DRM_FORMAT_ARGB8888, > +}; > + > +const unsigned int via_cursor_formats_size = > + ARRAY_SIZE(via_cursor_formats); The three variables above does not reference anything in this file and can be moved to the file with the single user. Sam