From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9CDE2C433EF for ; Sun, 26 Jun 2022 11:08:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3oSJUBC/2euvHdTAojMoVuHzDoJTtQAtLQLxco41we4=; b=v02MXmoCCYv8Ns Fbxvo1kLdE7TkdbGt1vyNtFQ6MTilmBkWKpmkpCbjMPdBHYhMda03y4ClOchi4lparJWP/RL3iuuD R6ar3L7y7ktv95tMLXTPpQcq9Eczw+ELoE7rCUTGyXjDyqccA85+Cy3csdJhsdpd1YhH8fw02CWaY PGjEmNgOFcXKtaEaiGtkr9FgfUkXys8ppnQ1ax6Rgc3RSYoFZ8FfwtQUeAIJ0Mn/kRNnpowIOAK+I r3KRcfgMjQp/u6nrB/b6mMz7oMJTnfPasaqMIqNFZjEZMr50T9TUaFgc0CSD2MLXmJ1XwX1Kb8fkx 4z8XlYT/rYowsgPFM24w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o5Q7G-00BMmy-J1; Sun, 26 Jun 2022 11:07:46 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o5Q7D-00BMlm-C7 for linux-rockchip@lists.infradead.org; Sun, 26 Jun 2022 11:07:45 +0000 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id E6A4947C; Sun, 26 Jun 2022 13:07:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1656241660; bh=l5MwWhDeebXQoASP278Isyfeu3tY6emg+jOGo6Dfkcc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kD2NWrXX9B3rUaSes0mI09Dlb8d3kJpZegXAx+3M0KCc7Q7zQwbOAY51l+Fhk79/f gEf4nQTFnVicfHb9qua9GRQIDC+77NLIiDf4Ytn5EjvTCuubAdiXsvfXVh9SyTd/oF ztEDRHbKH6s8cIHU/3BPMZb2cp6IAAXeYCuBicy0= Date: Sun, 26 Jun 2022 14:07:22 +0300 From: Laurent Pinchart To: Dafna Hirschfeld Cc: Paul Elder , linux-media@vger.kernel.org, heiko@sntech.de, jeanmichel.hautbois@ideasonboard.com, jacopo@jmondi.org, djrscally@gmail.com, helen.koike@collabora.com, linux-rockchip@lists.infradead.org Subject: Re: [PATCH 48/55] media: rkisp1: Add match data for i.MX8MP ISP Message-ID: References: <20220614191127.3420492-1-paul.elder@ideasonboard.com> <20220614191127.3420492-49-paul.elder@ideasonboard.com> <20220626040543.jswxbusyyydfoxfd@guri> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220626040543.jswxbusyyydfoxfd@guri> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220626_040743_612572_82C1276E X-CRM114-Status: GOOD ( 29.72 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org T24gU3VuLCBKdW4gMjYsIDIwMjIgYXQgMDc6MDU6NDNBTSArMDMwMCwgRGFmbmEgSGlyc2NoZmVs ZCB3cm90ZToKPiBPbiAxOC4wNi4yMDIyIDAyOjI2LCBMYXVyZW50IFBpbmNoYXJ0IHdyb3RlOgo+ ID4gT24gV2VkLCBKdW4gMTUsIDIwMjIgYXQgMDQ6MTE6MjBBTSArMDkwMCwgUGF1bCBFbGRlciB3 cm90ZToKPiA+PiBBZGQgbWF0Y2ggZGF0YSB0byB0aGUgcmtpc3AxIGRyaXZlciB0byBtYXRjaCB0 aGUgaS5NWDhNUCBJU1AuCj4gPj4KPiA+PiBTaWduZWQtb2ZmLWJ5OiBQYXVsIEVsZGVyIDxwYXVs LmVsZGVyQGlkZWFzb25ib2FyZC5jb20+Cj4gPj4gLS0tCj4gPj4gIC4uLi9wbGF0Zm9ybS9yb2Nr Y2hpcC9ya2lzcDEvcmtpc3AxLWRldi5jICAgICB8IDIyICsrKysrKysrKysrKysrKysrKysKPiA+ PiAgaW5jbHVkZS91YXBpL2xpbnV4L3JraXNwMS1jb25maWcuaCAgICAgICAgICAgIHwgIDMgKysr Cj4gPj4gIDIgZmlsZXMgY2hhbmdlZCwgMjUgaW5zZXJ0aW9ucygrKQo+ID4+Cj4gPj4gZGlmZiAt LWdpdCBhL2RyaXZlcnMvbWVkaWEvcGxhdGZvcm0vcm9ja2NoaXAvcmtpc3AxL3JraXNwMS1kZXYu YyBiL2RyaXZlcnMvbWVkaWEvcGxhdGZvcm0vcm9ja2NoaXAvcmtpc3AxL3JraXNwMS1kZXYuYwo+ ID4+IGluZGV4IDYyZmEyYmQyNzVmZS4uM2EwMTE1YmRjZWU1IDEwMDY0NAo+ID4+IC0tLSBhL2Ry aXZlcnMvbWVkaWEvcGxhdGZvcm0vcm9ja2NoaXAvcmtpc3AxL3JraXNwMS1kZXYuYwo+ID4+ICsr KyBiL2RyaXZlcnMvbWVkaWEvcGxhdGZvcm0vcm9ja2NoaXAvcmtpc3AxL3JraXNwMS1kZXYuYwo+ ID4+IEBAIC00ODYsNiArNDg2LDI0IEBAIHN0YXRpYyBjb25zdCBzdHJ1Y3Qgcmtpc3AxX2luZm8g cmszMzk5X2lzcF9pbmZvID0gewo+ID4+ICAJLmZlYXR1cmVzID0gUktJU1AxX0ZFQVRVUkVfTUlQ SV9DU0kyLAo+ID4+ICB9Owo+ID4+Cj4gPj4gK3N0YXRpYyBjb25zdCBjaGFyICogY29uc3QgaW14 OG1wX2lzcF9jbGtzW10gPSB7Cj4gPj4gKwkiaXNwIiwKPiA+PiArCSJoY2xrIiwKPiA+PiArCSJh Y2xrIiwKPiA+PiArfTsKPiA+PiArCj4gPj4gK3N0YXRpYyBjb25zdCBzdHJ1Y3Qgcmtpc3AxX2lz cl9kYXRhIGlteDhtcF9pc3BfaXNyc1tdID0gewo+ID4+ICsJeyBOVUxMLCBya2lzcDFfaXNyIH0s Cj4gPj4gK307Cj4gPj4gKwo+ID4+ICtzdGF0aWMgY29uc3Qgc3RydWN0IHJraXNwMV9pbmZvIGlt eDhtcF9pc3BfaW5mbyA9IHsKPiA+PiArCS5jbGtzID0gaW14OG1wX2lzcF9jbGtzLAo+ID4+ICsJ LmNsa19zaXplID0gQVJSQVlfU0laRShpbXg4bXBfaXNwX2Nsa3MpLAo+ID4+ICsJLmlzcnMgPSBp bXg4bXBfaXNwX2lzcnMsCj4gPj4gKwkuaXNyX3NpemUgPSBBUlJBWV9TSVpFKGlteDhtcF9pc3Bf aXNycyksCj4gPj4gKwkuaXNwX3ZlciA9IElNWDhNUF9WMTAsCj4gPj4gK307Cj4gPj4gKwo+ID4+ ICBzdGF0aWMgY29uc3Qgc3RydWN0IG9mX2RldmljZV9pZCBya2lzcDFfb2ZfbWF0Y2hbXSA9IHsK PiA+PiAgCXsKPiA+PiAgCQkuY29tcGF0aWJsZSA9ICJyb2NrY2hpcCxweDMwLWNpZi1pc3AiLAo+ ID4+IEBAIC00OTUsNiArNTEzLDEwIEBAIHN0YXRpYyBjb25zdCBzdHJ1Y3Qgb2ZfZGV2aWNlX2lk IHJraXNwMV9vZl9tYXRjaFtdID0gewo+ID4+ICAJCS5jb21wYXRpYmxlID0gInJvY2tjaGlwLHJr MzM5OS1jaWYtaXNwIiwKPiA+PiAgCQkuZGF0YSA9ICZyazMzOTlfaXNwX2luZm8sCj4gPj4gIAl9 LAo+ID4+ICsJewo+ID4+ICsJCS5jb21wYXRpYmxlID0gImZzbCxpbXg4bXAtaXNwIiwKPiA+PiAr CQkuZGF0YSA9ICZpbXg4bXBfaXNwX2luZm8sCj4gPj4gKwl9LAo+ID4+ICAJe30sCj4gPj4gIH07 Cj4gPj4gIE1PRFVMRV9ERVZJQ0VfVEFCTEUob2YsIHJraXNwMV9vZl9tYXRjaCk7Cj4gPj4gZGlm ZiAtLWdpdCBhL2luY2x1ZGUvdWFwaS9saW51eC9ya2lzcDEtY29uZmlnLmggYi9pbmNsdWRlL3Vh cGkvbGludXgvcmtpc3AxLWNvbmZpZy5oCj4gPj4gaW5kZXggNTgzY2EwZDlhNzlkLi40MDY3N2Q0 NzgyNWMgMTAwNjQ0Cj4gPj4gLS0tIGEvaW5jbHVkZS91YXBpL2xpbnV4L3JraXNwMS1jb25maWcu aAo+ID4+ICsrKyBiL2luY2x1ZGUvdWFwaS9saW51eC9ya2lzcDEtY29uZmlnLmgKPiA+PiBAQCAt MTQwLDEyICsxNDAsMTUgQEAKPiA+PiAgICogQFJLSVNQMV9WMTE6IGRlY2xhcmVkIGluIHRoZSBv cmlnaW5hbCB2ZW5kb3IgY29kZSwgYnV0IG5vdCB1c2VkCj4gPj4gICAqIEBSS0lTUDFfVjEyOiB1 c2VkIGF0IGxlYXN0IGluIHJrMzMyNiBhbmQgcHgzMAo+ID4+ICAgKiBAUktJU1AxX1YxMzogdXNl ZCBhdCBsZWFzdCBpbiByazE4MDgKPiA+PiArICogQElNWDhNUF9WMTA6IHVzZWQgaW4gYXQgbGVh c3QgaW14OG1wCj4gPj4gICAqLwo+ID4+ICBlbnVtIHJraXNwMV9jaWZfaXNwX3ZlcnNpb24gewo+ ID4+ICAJUktJU1AxX1YxMCA9IDEwLAo+ID4+ICAJUktJU1AxX1YxMSwKPiA+PiAgCVJLSVNQMV9W MTIsCj4gPj4gIAlSS0lTUDFfVjEzLAo+ID4+ICsJLyogVE9ETyBDaG9vc2UgYSBiZXR0ZXIgdmVy c2lvbiBmb3IgdGhpcyAqLwo+ID4+ICsJSU1YOE1QX1YxMCwKPiA+Cj4gPiBUaW1lIHRvIGFkZHJl c3MgdGhpcyA/IDotKQo+ID4KPiA+IERvZXMgYW55b25lIGtub3cgd2hlcmUgdGhlIGN1cnJlbnQg dmVyc2lvbmluZyBzY2hlbWUgY29tZSBmcm9tID8KPiAKPiBJdCB3YXMgYWRkZWQgYnkgSGVpa28g U3TDvGJuZXIsIGJhc2ljYWxseSB0cnlpbmcgdG8gZmlndXJlIG91dCB0aGUKPiB2ZXJzaW9ucyBm cm9tIHRoZSB2ZWRvciBjb2RlLAo+IHNlZSBodHRwczovL2xvcmUua2VybmVsLm9yZy9hbGwvMjAy MTAxMjExNDQ0MDcuOTA0NS02LWRhZm5hLmhpcnNjaGZlbGRAY29sbGFib3JhLmNvbS8KCklzIHRo YXQgcHVibGljIGNvZGUgPyBIZWlrbywgZG8geW91IGhhdmUgYW55IHBvaW50ZXIgdG8gaXQgPwoK QXMgZmFyIGFzIEkgdW5kZXJzdGFuZCwgdGhpcyBJU1AgSVAgaGFzIGJlZW4gZm9ya2VkLCBhbmQg aXMgbm93CmRldmVsb3BlZCBpbiBwYXJhbGxlbCBieSBSb2NrY2hpcCAoZm9yIHRoZWlyIG93biBT b0NzKSBhbmQgYnkKVmVyaVNpbGljb24gKHVuZGVyIHRoZSBuYW1lIG9mIElTUDgwMDBOYW5vKS4g VGhlIHZlcnNpb25pbmcgc2NoZW1lcyBvbgp0aGUgdHdvIHNpZGVzIGFyZSBkaWZmZXJlbnQsIGFu ZCBtYXkgaGF2ZSBjb21tb24gcm9vdHMuIFRoZSBmYWN0IHRoYXQKdGhlIElTUDgwMDBOYW5vIGNh biBiZSBjdXN0b21pemVkIGF0IHN5bnRoZXNpcyB0aW1lIGFsc28gY29tcGxpY2F0ZXMKdGhpcy4K ClRoZSBxdWVzdGlvbiBhdCBoYW5kIGlzIGhvdyB0byBleHBvc2UgYSBzaW5nbGUgY29oZXJlbnQg dmVyc2lvbmluZwpzY2hlbWUgdG8gdXNlcnNwYWNlIGluIHRoaXMgZHJpdmVyLiBUaGUgaGFyZHdh cmUgaGFzIGEgdmVyc2lvbgppZGVudGlmaWNhdGlvbiByZWdpc3RlciB0aGF0IHdlIGNvdWxkIHVz ZSwgYnV0IEkgZG9uJ3Qga25vdyBpZiBpdCBnaXZlcwp1cyBlbm91Z2ggaW5mb3JtYXRpb24gKGFz IGluIGd1YXJhbnRlZWluZyB0aGF0IHRoZSBzYW1lIHZlcnNpb24gdmFsdWUKd29uJ3QgYmUgdXNl ZCBmb3IgZGlmZmVyZW50IElQIHZlcnNpb25zIHRoYXQgd291bGQgbmVlZCB0byBiZQpkaXN0aW5n dWlzaGVkIGZyb20gZWFjaCBvdGhlciBpbiB1c2Vyc3BhY2UpLiBUaGUgZmFjdCB0aGF0IFJvY2tj aGlwIGFuZApWZXJpU2lsaWNvbiBwcm9iYWJseSBkZXZlbG9wIHRoZWlyIG93biBuZXcgdmVyc2lv bnMgd2l0aG91dCBjb29wZXJhdGluZwppbmNyZWFzZXMgdGhlIHJpc2sgb2YgY29sbGlzaW9uLgoK V2Ugd2lsbCBhbHNvIGhhdmUgdG8gdGFja2xlIHRoZSBxdWVzdGlvbiBvZiBVQUJJLiBOZXdlciBJ U1AgdmVyc2lvbnMKd2lsbCByZXF1aXJlIGV4dGVuc2lvbnMgdG8gdGhlIElTUCBwYXJhbWV0ZXJz IHN0cnVjdHVyZS4gVGhlIGkuTVg4TVAgaGFzCmV4dHJhIHByb2Nlc3NpbmcgYmxvY2tzIHRoYXQg YXJlIG5vdCBzdXBwb3J0ZWQgYnkgdGhlIGRyaXZlciB0b2RheS4gT25lCm9wdGlvbiB3b3VsZCBi ZSB0byBkdXBsaWNhdGUgdGhlIHRvcC1sZXZlbCBya2lzcDFfcGFyYW1zX2NmZyBzdHJ1Y3R1cmUK cGVyIElTUCB2ZXJzaW9uLCBhcyB3ZWxsIGFzIGEgc2V0IG9mIGxvd2VyLWxldmVsIHN0cnVjdHVy ZSB3aGVyZQphcHByb3ByaWF0ZSAoaG93IHRvIGhhbmRsZSB0aGF0IGVhc2lseSBhbmQgZWZmaWNp ZW50bHkgb24gdGhlIGRyaXZlcgpzaWRlIHdpbGwgYmUgaW50ZXJlc3RpbmcgdG8gZmlndXJlIG91 dCkuIEFub3RoZXIgb3B0aW9uIGlzIHRvIG9ubHkgYWRkCnBhcmFtZXRlcnMgdG8gdGhlIGVuZCBv ZiB0aGUgcmtpc3AxX3BhcmFtc19jZmcgc3RydWN0dXJlLCBidXQgSSBmZWFyCnRoYXQgd29uJ3Qg c2NhbGUuIFdlJ2xsIGVuZCB1cCB3aXRoIGEgbGFyZ2Ugc3RydWN0dXJlIHdoZXJlIGxvdHMgb2Yg ZGF0YQp3aWxsIGJlIGlycmVsZXZhbnQgZm9yIGFueSBwYXJ0aWN1bGFyIElTUCB2ZXJzaW9uLCBh bmQgdGhhdCB3aWxsIGJlCmVycm9yLXByb25lLgoKQ29tbWVudHMgYW5kIGlkZWEgd2lsbCBiZSBh cHByZWNpYXRlZC4KCj4gPj4gIH07Cj4gPj4KPiA+PiAgZW51bSBya2lzcDFfY2lmX2lzcF9oaXN0 b2dyYW1fbW9kZSB7CgotLSAKUmVnYXJkcywKCkxhdXJlbnQgUGluY2hhcnQKCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkxpbnV4LXJvY2tjaGlwIG1haWxp bmcgbGlzdApMaW51eC1yb2NrY2hpcEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5p bmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtcm9ja2NoaXAK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A09EFC433EF for ; Sun, 26 Jun 2022 11:07:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234347AbiFZLHp (ORCPT ); Sun, 26 Jun 2022 07:07:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48068 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234345AbiFZLHo (ORCPT ); Sun, 26 Jun 2022 07:07:44 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 528F9E029 for ; Sun, 26 Jun 2022 04:07:43 -0700 (PDT) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id E6A4947C; Sun, 26 Jun 2022 13:07:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1656241660; bh=l5MwWhDeebXQoASP278Isyfeu3tY6emg+jOGo6Dfkcc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kD2NWrXX9B3rUaSes0mI09Dlb8d3kJpZegXAx+3M0KCc7Q7zQwbOAY51l+Fhk79/f gEf4nQTFnVicfHb9qua9GRQIDC+77NLIiDf4Ytn5EjvTCuubAdiXsvfXVh9SyTd/oF ztEDRHbKH6s8cIHU/3BPMZb2cp6IAAXeYCuBicy0= Date: Sun, 26 Jun 2022 14:07:22 +0300 From: Laurent Pinchart To: Dafna Hirschfeld Cc: Paul Elder , linux-media@vger.kernel.org, heiko@sntech.de, jeanmichel.hautbois@ideasonboard.com, jacopo@jmondi.org, djrscally@gmail.com, helen.koike@collabora.com, linux-rockchip@lists.infradead.org Subject: Re: [PATCH 48/55] media: rkisp1: Add match data for i.MX8MP ISP Message-ID: References: <20220614191127.3420492-1-paul.elder@ideasonboard.com> <20220614191127.3420492-49-paul.elder@ideasonboard.com> <20220626040543.jswxbusyyydfoxfd@guri> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220626040543.jswxbusyyydfoxfd@guri> Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Sun, Jun 26, 2022 at 07:05:43AM +0300, Dafna Hirschfeld wrote: > On 18.06.2022 02:26, Laurent Pinchart wrote: > > On Wed, Jun 15, 2022 at 04:11:20AM +0900, Paul Elder wrote: > >> Add match data to the rkisp1 driver to match the i.MX8MP ISP. > >> > >> Signed-off-by: Paul Elder > >> --- > >> .../platform/rockchip/rkisp1/rkisp1-dev.c | 22 +++++++++++++++++++ > >> include/uapi/linux/rkisp1-config.h | 3 +++ > >> 2 files changed, 25 insertions(+) > >> > >> diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c > >> index 62fa2bd275fe..3a0115bdcee5 100644 > >> --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c > >> +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c > >> @@ -486,6 +486,24 @@ static const struct rkisp1_info rk3399_isp_info = { > >> .features = RKISP1_FEATURE_MIPI_CSI2, > >> }; > >> > >> +static const char * const imx8mp_isp_clks[] = { > >> + "isp", > >> + "hclk", > >> + "aclk", > >> +}; > >> + > >> +static const struct rkisp1_isr_data imx8mp_isp_isrs[] = { > >> + { NULL, rkisp1_isr }, > >> +}; > >> + > >> +static const struct rkisp1_info imx8mp_isp_info = { > >> + .clks = imx8mp_isp_clks, > >> + .clk_size = ARRAY_SIZE(imx8mp_isp_clks), > >> + .isrs = imx8mp_isp_isrs, > >> + .isr_size = ARRAY_SIZE(imx8mp_isp_isrs), > >> + .isp_ver = IMX8MP_V10, > >> +}; > >> + > >> static const struct of_device_id rkisp1_of_match[] = { > >> { > >> .compatible = "rockchip,px30-cif-isp", > >> @@ -495,6 +513,10 @@ static const struct of_device_id rkisp1_of_match[] = { > >> .compatible = "rockchip,rk3399-cif-isp", > >> .data = &rk3399_isp_info, > >> }, > >> + { > >> + .compatible = "fsl,imx8mp-isp", > >> + .data = &imx8mp_isp_info, > >> + }, > >> {}, > >> }; > >> MODULE_DEVICE_TABLE(of, rkisp1_of_match); > >> diff --git a/include/uapi/linux/rkisp1-config.h b/include/uapi/linux/rkisp1-config.h > >> index 583ca0d9a79d..40677d47825c 100644 > >> --- a/include/uapi/linux/rkisp1-config.h > >> +++ b/include/uapi/linux/rkisp1-config.h > >> @@ -140,12 +140,15 @@ > >> * @RKISP1_V11: declared in the original vendor code, but not used > >> * @RKISP1_V12: used at least in rk3326 and px30 > >> * @RKISP1_V13: used at least in rk1808 > >> + * @IMX8MP_V10: used in at least imx8mp > >> */ > >> enum rkisp1_cif_isp_version { > >> RKISP1_V10 = 10, > >> RKISP1_V11, > >> RKISP1_V12, > >> RKISP1_V13, > >> + /* TODO Choose a better version for this */ > >> + IMX8MP_V10, > > > > Time to address this ? :-) > > > > Does anyone know where the current versioning scheme come from ? > > It was added by Heiko Stübner, basically trying to figure out the > versions from the vedor code, > see https://lore.kernel.org/all/20210121144407.9045-6-dafna.hirschfeld@collabora.com/ Is that public code ? Heiko, do you have any pointer to it ? As far as I understand, this ISP IP has been forked, and is now developed in parallel by Rockchip (for their own SoCs) and by VeriSilicon (under the name of ISP8000Nano). The versioning schemes on the two sides are different, and may have common roots. The fact that the ISP8000Nano can be customized at synthesis time also complicates this. The question at hand is how to expose a single coherent versioning scheme to userspace in this driver. The hardware has a version identification register that we could use, but I don't know if it gives us enough information (as in guaranteeing that the same version value won't be used for different IP versions that would need to be distinguished from each other in userspace). The fact that Rockchip and VeriSilicon probably develop their own new versions without cooperating increases the risk of collision. We will also have to tackle the question of UABI. Newer ISP versions will require extensions to the ISP parameters structure. The i.MX8MP has extra processing blocks that are not supported by the driver today. One option would be to duplicate the top-level rkisp1_params_cfg structure per ISP version, as well as a set of lower-level structure where appropriate (how to handle that easily and efficiently on the driver side will be interesting to figure out). Another option is to only add parameters to the end of the rkisp1_params_cfg structure, but I fear that won't scale. We'll end up with a large structure where lots of data will be irrelevant for any particular ISP version, and that will be error-prone. Comments and idea will be appreciated. > >> }; > >> > >> enum rkisp1_cif_isp_histogram_mode { -- Regards, Laurent Pinchart