From: Andrew Lunn <andrew@lunn.ch>
To: alexandru.tachici@analog.com
Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, devicetree@vger.kernel.org,
krzysztof.kozlowski+dt@linaro.org, gerhard@engleder-embedded.com,
geert+renesas@glider.be, joel@jms.id.au, stefan.wahren@i2se.com,
wellslutw@gmail.com, geert@linux-m68k.org, robh+dt@kernel.org,
d.michailidis@fungible.com, stephen@networkplumber.org,
l.stelmach@samsung.com, linux-kernel@vger.kernel.org
Subject: Re: [net-next 1/2] net: ethernet: adi: Add ADIN1110 support
Date: Sun, 26 Jun 2022 11:16:09 +0200 [thread overview]
Message-ID: <Yrgj2WM5/O7YSUeZ@lunn.ch> (raw)
In-Reply-To: <20220624200628.77047-2-alexandru.tachici@analog.com>
> +static int adin1110_mdio_read(struct mii_bus *bus, int phy_id, int reg)
> +{
> + struct adin1110_priv *priv = bus->priv;
> + u32 val = 0;
> + int ret;
> +
> + mutex_lock(&priv->lock);
> +
> + val |= FIELD_PREP(ADIN1110_MDIO_OP, ADIN1110_MDIO_OP_RD);
> + val |= FIELD_PREP(ADIN1110_MDIO_ST, 0x1);
> + val |= FIELD_PREP(ADIN1110_MDIO_PRTAD, phy_id);
> + val |= FIELD_PREP(ADIN1110_MDIO_DEVAD, reg);
> +
> + /* write the clause 22 read command to the chip */
Please return -EOPNOTSUPP if asked to do a C45 transfer.
> +static int adin1110_mdio_write(struct mii_bus *bus, int phy_id, int reg, u16 reg_val)
> +{
> + struct adin1110_priv *priv = bus->priv;
> + u32 val = 0;
> + int ret;
same here.
Andrew
next prev parent reply other threads:[~2022-06-26 9:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-24 20:06 [net-next 0/2] net: ethernet: adi: Add ADIN1110 support alexandru.tachici
2022-06-24 20:06 ` [net-next 1/2] " alexandru.tachici
2022-06-25 5:36 ` Jakub Kicinski
2022-06-26 9:16 ` Andrew Lunn [this message]
2022-06-26 10:01 ` Andrew Lunn
2022-06-26 12:39 ` Stefan Wahren
2022-06-24 20:06 ` [net-next 2/2] dt-bindings: net: adin1110: Add docs alexandru.tachici
2022-06-25 20:59 ` Krzysztof Kozlowski
2022-06-26 10:06 ` Andrew Lunn
2022-06-27 13:31 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yrgj2WM5/O7YSUeZ@lunn.ch \
--to=andrew@lunn.ch \
--cc=alexandru.tachici@analog.com \
--cc=d.michailidis@fungible.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=geert+renesas@glider.be \
--cc=geert@linux-m68k.org \
--cc=gerhard@engleder-embedded.com \
--cc=joel@jms.id.au \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=l.stelmach@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=stefan.wahren@i2se.com \
--cc=stephen@networkplumber.org \
--cc=wellslutw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.