From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 861A6C43334 for ; Mon, 27 Jun 2022 13:55:09 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 20BCF167F; Mon, 27 Jun 2022 15:54:17 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 20BCF167F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1656338107; bh=hOra6tWIonMVr2SGNZGAGnM9x38Jczr9VTOWZhcix7o=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=MIoYdj+NGlzxWTjuJAzuVN92hOVlpwedgg/HTKQ2klc4JXmLR55dvcnlQkm0fDtNa Qz8fsNx/MJB8JNVJzvH4ve4YWznHyqKq3tspeVzSdKhJhFHFf6c22XlLCHHAwslzCf l0SuBLe9XleFnLjm818w55CchePFCLo9W9SRSz3g= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 630FDF8012F; Mon, 27 Jun 2022 15:54:16 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 47A5CF8028B; Mon, 27 Jun 2022 15:54:14 +0200 (CEST) Received: from muru.com (muru.com [72.249.23.125]) by alsa1.perex.cz (Postfix) with ESMTP id 6DF70F80128 for ; Mon, 27 Jun 2022 15:54:03 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 6DF70F80128 Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 634648106; Mon, 27 Jun 2022 13:48:49 +0000 (UTC) Date: Mon, 27 Jun 2022 16:53:58 +0300 From: Tony Lindgren To: "H. Nikolaus Schaller" Subject: Re: Pandora audio using machine_is_omap3_pandora() check Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Cc: alsa-devel@alsa-project.org, Discussions about the Letux Kernel , Arnd Bergmann , Grond , Stefan Leichter , Mark Brown , Grazvydas Ignotas , linux-omap X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" * H. Nikolaus Schaller [220627 11:36]: > Hi Tony, > > > Am 27.06.2022 um 11:52 schrieb Tony Lindgren : > > > > Hi Grazvydas, > > > > Arnd noticed that pandora audio is using machine_is_omap3_pandora() check > > that never succeeds for devicetree booting machines. Looks like this has > > been broken at some point many years ago with the devicetree conversion. > > > > Does anybody have an interest in fixing this driver? > > we already have fixes by Stefan Leichter and Grond here (incl. removing any call to machine_is_omap3_pandora): > > https://git.goldelico.com/?p=letux-kernel.git;a=shortlog;h=refs/heads/letux/sound-soc OK :) > But I don't know who can volunteer to run this series through the upstreaming discussions > and do regression tests (AFAIR the Pandora of Grond is broken and he has no replacement). Probably best that Stefan and Grond do it :) Not sure what the minimal fix for the mainline kernel might be to get things at least try to probe. Regards, Tony From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE884C433EF for ; Mon, 27 Jun 2022 13:54:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236391AbiF0NyG (ORCPT ); Mon, 27 Jun 2022 09:54:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56768 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236375AbiF0NyF (ORCPT ); Mon, 27 Jun 2022 09:54:05 -0400 Received: from muru.com (muru.com [72.249.23.125]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 9276C643F for ; Mon, 27 Jun 2022 06:54:00 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 634648106; Mon, 27 Jun 2022 13:48:49 +0000 (UTC) Date: Mon, 27 Jun 2022 16:53:58 +0300 From: Tony Lindgren To: "H. Nikolaus Schaller" Cc: Grazvydas Ignotas , Arnd Bergmann , Mark Brown , alsa-devel@alsa-project.org, linux-omap , Stefan Leichter , Grond , Discussions about the Letux Kernel Subject: Re: Pandora audio using machine_is_omap3_pandora() check Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org * H. Nikolaus Schaller [220627 11:36]: > Hi Tony, > > > Am 27.06.2022 um 11:52 schrieb Tony Lindgren : > > > > Hi Grazvydas, > > > > Arnd noticed that pandora audio is using machine_is_omap3_pandora() check > > that never succeeds for devicetree booting machines. Looks like this has > > been broken at some point many years ago with the devicetree conversion. > > > > Does anybody have an interest in fixing this driver? > > we already have fixes by Stefan Leichter and Grond here (incl. removing any call to machine_is_omap3_pandora): > > https://git.goldelico.com/?p=letux-kernel.git;a=shortlog;h=refs/heads/letux/sound-soc OK :) > But I don't know who can volunteer to run this series through the upstreaming discussions > and do regression tests (AFAIR the Pandora of Grond is broken and he has no replacement). Probably best that Stefan and Grond do it :) Not sure what the minimal fix for the mainline kernel might be to get things at least try to probe. Regards, Tony