All of lore.kernel.org
 help / color / mirror / Atom feed
From: Leon Romanovsky <leonro@nvidia.com>
To: Tao Liu <thomas.liu@ucloud.cn>
Cc: <linux-rdma@vger.kernel.org>, <saeedm@nvidia.com>,
	<talgi@nvidia.com>, <mgurtovoy@nvidia.com>, <jgg@nvidia.com>,
	<yaminf@nvidia.com>
Subject: Re: [PATCH v2] linux/dim: Fix divide 0 in RDMA DIM.
Date: Mon, 27 Jun 2022 15:51:39 +0300	[thread overview]
Message-ID: <Yrmn2x0Q8gon6msb@unreal> (raw)
In-Reply-To: <20220627113036.1324-1-thomas.liu@ucloud.cn>

On Mon, Jun 27, 2022 at 07:30:36PM +0800, Tao Liu wrote:
> We hit a divide 0 error in ofed 5.1.2.3.7.1. It is caused in
> rdma_dim_stats_compare() when prev->cpe_ratio == 0.
> 
> dim.c and rdma_dim.c in ofed share same code with upstream.
> We check the 0 case in IS_SIGNIFICANT_DIFF(), and do not change
> decision order.
> 
> Signed-off-by: Tao Liu <thomas.liu@ucloud.cn>
> ---
>  include/linux/dim.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

I liked the commit message from v1 more.
It had proper kernel panic dump together with Fixes line.
https://lore.kernel.org/all/20220623085858.42945-1-thomas.liu@ucloud.cn

The change itself is ok.

Thanks,
Acked-by: Leon Romanovsky <leonro@nvidia.com>

  reply	other threads:[~2022-06-27 12:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-27 11:30 [PATCH v2] linux/dim: Fix divide 0 in RDMA DIM Tao Liu
2022-06-27 12:51 ` Leon Romanovsky [this message]
2022-06-27 12:57   ` Max Gurtovoy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yrmn2x0Q8gon6msb@unreal \
    --to=leonro@nvidia.com \
    --cc=jgg@nvidia.com \
    --cc=linux-rdma@vger.kernel.org \
    --cc=mgurtovoy@nvidia.com \
    --cc=saeedm@nvidia.com \
    --cc=talgi@nvidia.com \
    --cc=thomas.liu@ucloud.cn \
    --cc=yaminf@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.