From: Lee Jones <lee.jones@linaro.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Hans de Goede <hdegoede@redhat.com>,
linux-kernel@vger.kernel.org, Andy Shevchenko <andy@kernel.org>
Subject: Re: [PATCH v1 1/9] mfd: intel_soc_pmic_crc: Merge Intel PMIC core to crc
Date: Mon, 27 Jun 2022 14:08:39 +0100 [thread overview]
Message-ID: <Yrmr175fsQi6ToEY@google.com> (raw)
In-Reply-To: <20220616182524.7956-1-andriy.shevchenko@linux.intel.com>
On Thu, 16 Jun 2022, Andy Shevchenko wrote:
> The core part is misleading since its only purpose to serve Crystal Cove PMIC,
> although for couple of different platforms. Merge core part into crc one.
>
> Advantages among others are:
> - speed up a compilation and build
> - decreasing the code base
> - reducing noise in the namespace by making some data static and const
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/mfd/Makefile | 3 +-
> drivers/mfd/intel_soc_pmic_core.c | 160 -----------------------------
> drivers/mfd/intel_soc_pmic_core.h | 25 -----
> drivers/mfd/intel_soc_pmic_crc.c | 162 ++++++++++++++++++++++++++++--
> 4 files changed, 157 insertions(+), 193 deletions(-)
> delete mode 100644 drivers/mfd/intel_soc_pmic_core.c
> delete mode 100644 drivers/mfd/intel_soc_pmic_core.h
Can you submit this again with the -M flag please.
Trying to figure out what exactly changed is proving challenging.
--
Lee Jones [李琼斯]
Principal Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2022-06-27 13:10 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-16 18:25 [PATCH v1 1/9] mfd: intel_soc_pmic_crc: Merge Intel PMIC core to crc Andy Shevchenko
2022-06-16 18:25 ` [PATCH v1 2/9] mfd: intel_soc_pmic: Move non-Intel Makefile entries to their own group Andy Shevchenko
2022-06-27 13:23 ` Lee Jones
2022-06-16 18:25 ` [PATCH v1 3/9] mfd: intel_soc_pmic_crc: Use devm_regmap_add_irq_chip() Andy Shevchenko
2022-06-27 13:24 ` Lee Jones
2022-06-16 18:25 ` [PATCH v1 4/9] mfd: intel_soc_pmic_crc: Convert to use i2c_get/set_clientdata() Andy Shevchenko
2022-06-27 13:26 ` Lee Jones
2022-06-16 18:25 ` [PATCH v1 5/9] mfd: intel_soc_pmic_crc: Switch from CONFIG_PM_SLEEP guards to pm_sleep_ptr() etc Andy Shevchenko
2022-06-27 13:26 ` Lee Jones
2022-06-27 13:39 ` Lee Jones
2022-06-16 18:25 ` [PATCH v1 6/9] mfd: intel_soc_pmic_crc: Drop redundant ACPI_PTR() and ifdeffery Andy Shevchenko
2022-06-27 13:27 ` Lee Jones
2022-06-27 13:39 ` Lee Jones
2022-06-16 18:25 ` [PATCH v1 7/9] mfd: intel_soc_pmic_crc: Convert driver to use ->probe_new() Andy Shevchenko
2022-06-27 13:43 ` Lee Jones
2022-06-16 18:25 ` [PATCH v1 8/9] mfd: intel_soc_pmic_crc: Replace intel_soc_pmic with crystal_cove Andy Shevchenko
2022-06-27 13:45 ` Lee Jones
2022-06-16 18:25 ` [PATCH v1 9/9] mfd: intel_soc_pmic_crc: Update the copyright year Andy Shevchenko
2022-06-27 13:46 ` Lee Jones
2022-06-28 9:48 ` Andy Shevchenko
2022-06-20 8:51 ` [PATCH v1 1/9] mfd: intel_soc_pmic_crc: Merge Intel PMIC core to crc Hans de Goede
2022-06-20 9:42 ` Andy Shevchenko
2022-06-20 10:00 ` Hans de Goede
2022-06-20 10:44 ` Andy Shevchenko
2022-06-20 9:04 ` Hans de Goede
2022-06-20 9:42 ` Andy Shevchenko
2022-06-28 23:06 ` Andy Shevchenko
2022-06-29 13:18 ` Hans de Goede
2022-06-29 13:19 ` Hans de Goede
2022-06-29 16:03 ` Andy Shevchenko
2022-06-27 13:08 ` Lee Jones [this message]
2022-06-28 9:50 ` Andy Shevchenko
2022-06-29 14:35 ` Lee Jones
2022-06-29 15:41 ` Andy Shevchenko
2022-06-30 8:01 ` Lee Jones
2022-06-30 8:07 ` Andy Shevchenko
2022-06-30 8:36 ` Hans de Goede
2022-06-30 8:45 ` Lee Jones
2022-07-15 19:54 ` Andy Shevchenko
2022-07-18 8:12 ` Lee Jones
2022-07-18 8:12 ` Lee Jones
2022-07-18 12:19 ` Andy Shevchenko
2022-07-18 15:17 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yrmr175fsQi6ToEY@google.com \
--to=lee.jones@linaro.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy@kernel.org \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.