From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Christopherson Subject: Re: [PATCH v5 3/4] KVM: x86/mmu: count KVM mmu usage in secondary pagetable stats. Date: Mon, 27 Jun 2022 16:22:46 +0000 Message-ID: References: <20220606222058.86688-1-yosryahmed@google.com> <20220606222058.86688-4-yosryahmed@google.com> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=cV3hVzy9TYCqPFueATEq37SOh6vFTuLA/SrvAB62Xzg=; b=BseriqoiozT548bWf87kfEM21QE/lsC7Xh53iRBx2LmFdeNav386MocuZafko2ZdzZ JQe5ovxOhcstFhT8iCD21C825q81Za8C3tdgW13ebnSYPD7k8WHS3yPH0VHQSCGZnmQf FicGbHrtEuD0O3jI+Q4LIietAgpYwoWp5qedMxPLBADENHHnn+UkkXouxHyxDA/j0F9g moM6KAIDklQszHLohnncrg9SWHa8qDcecTbUS930nHP7JYFxSIbGRQKh+59wLE+AXy7E fCLhJT8SPzPCj5eph3yGYAVFqleuzS1aYTb4Me1axhRhNHXk+NS3u9/PAs9nbb1c6HO+ fcfA== Content-Disposition: inline In-Reply-To: <20220606222058.86688-4-yosryahmed@google.com> List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Yosry Ahmed Cc: Tejun Heo , Johannes Weiner , Zefan Li , Marc Zyngier , James Morse , Alexandru Elisei , Suzuki K Poulose , Paolo Bonzini , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Andrew Morton , Michal Hocko , Roman Gushchin , Shakeel Butt , Oliver Upton , cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.ker On Mon, Jun 06, 2022, Yosry Ahmed wrote: > Count the pages used by KVM mmu on x86 for in secondary pagetable stats. "for in" is funky. And it's worth providing a brief explanation of what the secondary pagetable stats actually are. "secondary" is confusingly close to "second level pagetables", e.g. might be misconstrued as KVM counters for the number of stage-2 / two-dimension paging page (TDP) tables. Code looks good, though it needs a rebased on kvm/queue. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21A9FC43334 for ; Mon, 27 Jun 2022 16:22:54 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 968B84B2BC; Mon, 27 Jun 2022 12:22:54 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@google.com Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DOXs1X1DzuSg; Mon, 27 Jun 2022 12:22:53 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 97A594B29E; Mon, 27 Jun 2022 12:22:53 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 198CA4B1DB for ; Mon, 27 Jun 2022 12:22:52 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 67pKmTSzmUVL for ; Mon, 27 Jun 2022 12:22:51 -0400 (EDT) Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 1F4A149EE3 for ; Mon, 27 Jun 2022 12:22:51 -0400 (EDT) Received: by mail-pl1-f176.google.com with SMTP id q18so8587740pld.13 for ; Mon, 27 Jun 2022 09:22:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=cV3hVzy9TYCqPFueATEq37SOh6vFTuLA/SrvAB62Xzg=; b=BseriqoiozT548bWf87kfEM21QE/lsC7Xh53iRBx2LmFdeNav386MocuZafko2ZdzZ JQe5ovxOhcstFhT8iCD21C825q81Za8C3tdgW13ebnSYPD7k8WHS3yPH0VHQSCGZnmQf FicGbHrtEuD0O3jI+Q4LIietAgpYwoWp5qedMxPLBADENHHnn+UkkXouxHyxDA/j0F9g moM6KAIDklQszHLohnncrg9SWHa8qDcecTbUS930nHP7JYFxSIbGRQKh+59wLE+AXy7E fCLhJT8SPzPCj5eph3yGYAVFqleuzS1aYTb4Me1axhRhNHXk+NS3u9/PAs9nbb1c6HO+ fcfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=cV3hVzy9TYCqPFueATEq37SOh6vFTuLA/SrvAB62Xzg=; b=IpUcIbhptTs/seu7fmxMDasJ3lpEMf4hGp0gsU0feicr4REvkT+t4Y7PvQ+9il2nss rADVAQtVjJyiXcAxyDmCBlxnA5U5w9dZxigocAl2av1bgv2/2sVUNZzYvfULC/Wmqbqf nqqU35j4ZqcCSVztSmwDHrgDmHXD3sUSSUAN1lnHne9t0+A/vLkh3eqBNo3pbtEt2/sT 8DbSEHp97k3CNA9onkFeB1inmokWcO0n5C0sYrcmrPFg+H3c/QqTcasm62Vlj7jA6Lkm n1ZWzAIEw49Dz+KVZ9bCevmcNbzIyZxQj+kpiiZgMbuNze9ifW6STT90IOyCkGBssN1d Y7Vw== X-Gm-Message-State: AJIora8q/iQkuVNzvPB0+Is3amCJ7wlAPIu49HCIoWJtdsqKNUmhxQlF AGbhju5ClqnSM8gkaBCQDLnUzA== X-Google-Smtp-Source: AGRyM1v1/klo71FJcOnTZoW3zB85VLk+X/utjbZmu0W37du2cpFLJFufJZy1ShhykQNqxxTcsGcOvw== X-Received: by 2002:a17:902:e54f:b0:16a:29de:9603 with SMTP id n15-20020a170902e54f00b0016a29de9603mr15741779plf.46.1656346970060; Mon, 27 Jun 2022 09:22:50 -0700 (PDT) Received: from google.com (123.65.230.35.bc.googleusercontent.com. [35.230.65.123]) by smtp.gmail.com with ESMTPSA id o14-20020a17090a4e8e00b001e2bd411079sm9752135pjh.20.2022.06.27.09.22.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jun 2022 09:22:49 -0700 (PDT) Date: Mon, 27 Jun 2022 16:22:46 +0000 From: Sean Christopherson To: Yosry Ahmed Subject: Re: [PATCH v5 3/4] KVM: x86/mmu: count KVM mmu usage in secondary pagetable stats. Message-ID: References: <20220606222058.86688-1-yosryahmed@google.com> <20220606222058.86688-4-yosryahmed@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220606222058.86688-4-yosryahmed@google.com> Cc: Wanpeng Li , kvm@vger.kernel.org, Roman Gushchin , Michal Hocko , linux-mm@kvack.org, Zefan Li , kvmarm@lists.cs.columbia.edu, Marc Zyngier , Joerg Roedel , Shakeel Butt , cgroups@vger.kernel.org, Andrew Morton , linux-arm-kernel@lists.infradead.org, Jim Mattson , linux-kernel@vger.kernel.org, Johannes Weiner , Tejun Heo , Paolo Bonzini , Vitaly Kuznetsov X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On Mon, Jun 06, 2022, Yosry Ahmed wrote: > Count the pages used by KVM mmu on x86 for in secondary pagetable stats. "for in" is funky. And it's worth providing a brief explanation of what the secondary pagetable stats actually are. "secondary" is confusingly close to "second level pagetables", e.g. might be misconstrued as KVM counters for the number of stage-2 / two-dimension paging page (TDP) tables. Code looks good, though it needs a rebased on kvm/queue. _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9A274C433EF for ; Mon, 27 Jun 2022 16:24:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vbgoDw8ozv/MOSZTH9kO8J3KAAuaC0kV27t/BhO7Xkk=; b=V/XDS3V8i2aqs4 R1ZysxtAJQeJn3rlrAsoENlD/vMcsKPZz9WU1zRmEYNPBf1vqXzm2LnS0KJ9K82BmQkxbPfeVLhFt +sAyZeWV/ODtv7QHPDRNeIyjqdqijAHeepVviaqHGMqWj8/TyB9NE6lynkynI9rIbVoj9osP/AorJ Vpuul9Z4zV2gDWiXPLb7vDsYqTfDLBg4ex/KfdqMj1E0NH3WB1PKWH6Q+m/oVNTxNinWPVgnLSL4S /9XznGtDk9ToIKhdmeFvhpPSzB7rjfWXqMqFD9PBYpY7zj1v2DPUqGU4Ew1zmUUDGREcZ8u8MB/nk EbKqppSve6yiSz/FuEzA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o5rVu-001nDh-6s; Mon, 27 Jun 2022 16:23:02 +0000 Received: from mail-pj1-x1029.google.com ([2607:f8b0:4864:20::1029]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o5rVk-001nAk-Op for linux-arm-kernel@lists.infradead.org; Mon, 27 Jun 2022 16:22:53 +0000 Received: by mail-pj1-x1029.google.com with SMTP id w19-20020a17090a8a1300b001ec79064d8dso12987713pjn.2 for ; Mon, 27 Jun 2022 09:22:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=cV3hVzy9TYCqPFueATEq37SOh6vFTuLA/SrvAB62Xzg=; b=BseriqoiozT548bWf87kfEM21QE/lsC7Xh53iRBx2LmFdeNav386MocuZafko2ZdzZ JQe5ovxOhcstFhT8iCD21C825q81Za8C3tdgW13ebnSYPD7k8WHS3yPH0VHQSCGZnmQf FicGbHrtEuD0O3jI+Q4LIietAgpYwoWp5qedMxPLBADENHHnn+UkkXouxHyxDA/j0F9g moM6KAIDklQszHLohnncrg9SWHa8qDcecTbUS930nHP7JYFxSIbGRQKh+59wLE+AXy7E fCLhJT8SPzPCj5eph3yGYAVFqleuzS1aYTb4Me1axhRhNHXk+NS3u9/PAs9nbb1c6HO+ fcfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=cV3hVzy9TYCqPFueATEq37SOh6vFTuLA/SrvAB62Xzg=; b=GKu10/8UZCksKlWrIWfE5C1l0xQ6QBfmfSMOgGNTsmOM7fbVHsxQbA1g5Ir1lMKDNy xXA7X79xvuKKkiH63KN/JzHCqqe/emqrGYlSe1p3ynbJiMHuo95vmY7TTELPIk81UOrD ZyYT1b5UWsrEZcOmjQtVpMHCRQjdIv954Fp8gvzbRP/Xax2JRQuFGkoobVkxmK7SXa1K 3m2IAEtXg5UVCFTOTU8PBIFYmtbWjyQSP9mZ6tGPZxkAEZF7rwNOqDmeIkpxoVhxj9Yk aEeQQ5ux5HXeBaD642buuPIxrwkq0dXloQQQov8v/UeonFhN1GYg96sfvw8qSMeB2za6 X5Bg== X-Gm-Message-State: AJIora/VUh2JHstWCwy8u2J/kv6b1RpMMGgOmkHEFpS1EjyYjPHYB82L nUfx3Xqhc+joPBRR1hrWXCgaRg== X-Google-Smtp-Source: AGRyM1v1/klo71FJcOnTZoW3zB85VLk+X/utjbZmu0W37du2cpFLJFufJZy1ShhykQNqxxTcsGcOvw== X-Received: by 2002:a17:902:e54f:b0:16a:29de:9603 with SMTP id n15-20020a170902e54f00b0016a29de9603mr15741779plf.46.1656346970060; Mon, 27 Jun 2022 09:22:50 -0700 (PDT) Received: from google.com (123.65.230.35.bc.googleusercontent.com. [35.230.65.123]) by smtp.gmail.com with ESMTPSA id o14-20020a17090a4e8e00b001e2bd411079sm9752135pjh.20.2022.06.27.09.22.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jun 2022 09:22:49 -0700 (PDT) Date: Mon, 27 Jun 2022 16:22:46 +0000 From: Sean Christopherson To: Yosry Ahmed Cc: Tejun Heo , Johannes Weiner , Zefan Li , Marc Zyngier , James Morse , Alexandru Elisei , Suzuki K Poulose , Paolo Bonzini , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Andrew Morton , Michal Hocko , Roman Gushchin , Shakeel Butt , Oliver Upton , cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v5 3/4] KVM: x86/mmu: count KVM mmu usage in secondary pagetable stats. Message-ID: References: <20220606222058.86688-1-yosryahmed@google.com> <20220606222058.86688-4-yosryahmed@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220606222058.86688-4-yosryahmed@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220627_092252_848355_6E78348C X-CRM114-Status: UNSURE ( 8.56 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jun 06, 2022, Yosry Ahmed wrote: > Count the pages used by KVM mmu on x86 for in secondary pagetable stats. "for in" is funky. And it's worth providing a brief explanation of what the secondary pagetable stats actually are. "secondary" is confusingly close to "second level pagetables", e.g. might be misconstrued as KVM counters for the number of stage-2 / two-dimension paging page (TDP) tables. Code looks good, though it needs a rebased on kvm/queue. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E418C433EF for ; Mon, 27 Jun 2022 16:22:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239229AbiF0QWx (ORCPT ); Mon, 27 Jun 2022 12:22:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53816 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239145AbiF0QWv (ORCPT ); Mon, 27 Jun 2022 12:22:51 -0400 Received: from mail-pl1-x630.google.com (mail-pl1-x630.google.com [IPv6:2607:f8b0:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A6CE5D86 for ; Mon, 27 Jun 2022 09:22:50 -0700 (PDT) Received: by mail-pl1-x630.google.com with SMTP id m14so8626117plg.5 for ; Mon, 27 Jun 2022 09:22:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=cV3hVzy9TYCqPFueATEq37SOh6vFTuLA/SrvAB62Xzg=; b=BseriqoiozT548bWf87kfEM21QE/lsC7Xh53iRBx2LmFdeNav386MocuZafko2ZdzZ JQe5ovxOhcstFhT8iCD21C825q81Za8C3tdgW13ebnSYPD7k8WHS3yPH0VHQSCGZnmQf FicGbHrtEuD0O3jI+Q4LIietAgpYwoWp5qedMxPLBADENHHnn+UkkXouxHyxDA/j0F9g moM6KAIDklQszHLohnncrg9SWHa8qDcecTbUS930nHP7JYFxSIbGRQKh+59wLE+AXy7E fCLhJT8SPzPCj5eph3yGYAVFqleuzS1aYTb4Me1axhRhNHXk+NS3u9/PAs9nbb1c6HO+ fcfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=cV3hVzy9TYCqPFueATEq37SOh6vFTuLA/SrvAB62Xzg=; b=xT1/cdUsEOqxgxUCX60UJ/7wZbFSE1OMQjpCDi1eB1OgJeS6Ym8GxlYQ6wHUOwIBRe HXczBMm7VDyiqXr1nTj0XBnG67/bSS/Y2PV3H+w5nMuXRRydpcqwWInuySOadlPKB3GC a9nhVzgHUaaf1lg+2SIG5j+/Hs12VB7puA4lsIaM3kFkULs36e/IqYzPPFncMMPIaNH1 Ji6w/oKTjsT3Pr++8ZnbL1RVrgHr1RrNAWtBm4Nekudsgk6wmBH6WYL5MrSTATkigcoR 2xghLB0AH/kmnYWZYlp2+Mu0e+NN/33MrhTnKDXNlPZ+7HB18JShgMsuyQ5q5TUEReei JgiA== X-Gm-Message-State: AJIora/uelXmG/+iRKHrRZr6Eb3YEk+srcuApo45zfBk1Dg0FMHDDzG9 8UyWEJ94r2VRKb4mgyzRYZP/Yg== X-Google-Smtp-Source: AGRyM1v1/klo71FJcOnTZoW3zB85VLk+X/utjbZmu0W37du2cpFLJFufJZy1ShhykQNqxxTcsGcOvw== X-Received: by 2002:a17:902:e54f:b0:16a:29de:9603 with SMTP id n15-20020a170902e54f00b0016a29de9603mr15741779plf.46.1656346970060; Mon, 27 Jun 2022 09:22:50 -0700 (PDT) Received: from google.com (123.65.230.35.bc.googleusercontent.com. [35.230.65.123]) by smtp.gmail.com with ESMTPSA id o14-20020a17090a4e8e00b001e2bd411079sm9752135pjh.20.2022.06.27.09.22.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jun 2022 09:22:49 -0700 (PDT) Date: Mon, 27 Jun 2022 16:22:46 +0000 From: Sean Christopherson To: Yosry Ahmed Cc: Tejun Heo , Johannes Weiner , Zefan Li , Marc Zyngier , James Morse , Alexandru Elisei , Suzuki K Poulose , Paolo Bonzini , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Andrew Morton , Michal Hocko , Roman Gushchin , Shakeel Butt , Oliver Upton , cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v5 3/4] KVM: x86/mmu: count KVM mmu usage in secondary pagetable stats. Message-ID: References: <20220606222058.86688-1-yosryahmed@google.com> <20220606222058.86688-4-yosryahmed@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220606222058.86688-4-yosryahmed@google.com> Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Mon, Jun 06, 2022, Yosry Ahmed wrote: > Count the pages used by KVM mmu on x86 for in secondary pagetable stats. "for in" is funky. And it's worth providing a brief explanation of what the secondary pagetable stats actually are. "secondary" is confusingly close to "second level pagetables", e.g. might be misconstrued as KVM counters for the number of stage-2 / two-dimension paging page (TDP) tables. Code looks good, though it needs a rebased on kvm/queue.