From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AA92CCA473 for ; Mon, 27 Jun 2022 16:28:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239224AbiF0Q2V (ORCPT ); Mon, 27 Jun 2022 12:28:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58054 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239230AbiF0Q2R (ORCPT ); Mon, 27 Jun 2022 12:28:17 -0400 Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0DFCAB4BE for ; Mon, 27 Jun 2022 09:28:13 -0700 (PDT) Received: by mail-wr1-x436.google.com with SMTP id b26so1439350wrc.2 for ; Mon, 27 Jun 2022 09:28:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=RFbscGfZ1HvqkolFfPgOHxRAqCYKsO6AGhI1CWcF3U0=; b=QL9P5fYJiAGJ0cVberqQxZgecUlCyO035Rs/RHERScTvlSGjFZWJwcJ83NKx7icnCf MmmkqeK7/MKYHkhThvS+4I5n6eilA1iv0cTdd1jM4UXHDDaaVEXvSnXIRzJWnCUCUcUi hfbpR0k3AwYuP7wFzDx1Qb4iWIpTN9nBpMOsMz5YzOvQfMZ+aNGdk1BwqtUaNtHKCBDC fA9t5x0TJ4kWUQmeUPz8VsbAvV+0a4AUoZiJIyO7qENghiYMyKTM8whwQHTooEBVZnfa hv7NO7jkwT4JYF/WPaOvNMBn/r4c0lJo2uE2cyoUPVH1HBvXxtPYqUUryaiaIppTOHk7 Xteg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=RFbscGfZ1HvqkolFfPgOHxRAqCYKsO6AGhI1CWcF3U0=; b=77nOHoklfhilsAPtN2EmgXd9kpafYzwUn+TfE/6/jVSgBAu22HBktM8z0XSpm3vToA nGVOWkrCstDjzE2oAEHEpZHcy6bPz2OxhjmKYpxsoq6CFa+gugooMjmhyd0gT0uauCTm MTXhGHzripcWUZl9HQBDcc8YBT8L2TDi00ypMkgNjecxAlYpqNI8iPzk7EzeO74joxNa joyjZV3r4wmlbYjwH6IDqZcrYuQt5hOSibFNFOGPwbAZysR2BVgeemfIMtn/VKTdrdpz e5NkTHA9YyxaZMUO4L9WLYWg9exw/ULEXzBp7OpMEOHTZBA8KeQEgxqztK0EyN1pkVsc 9q9Q== X-Gm-Message-State: AJIora/Nur6JT/pxkC2D9qcX/XQNeLM5I7HxZE1EcOFFsWNeMrUU2Tg9 8OJsNH+Ba5UGcl73xazw00Yp9A== X-Google-Smtp-Source: AGRyM1tWghCzrhvaQKuNnG4CtD67zaV7MVCuo84J73jDL9LXJFGuDL/uN51RLsUeyYqHqBL/FNulUA== X-Received: by 2002:a5d:5966:0:b0:21b:80b5:ecc3 with SMTP id e38-20020a5d5966000000b0021b80b5ecc3mr12930472wri.130.1656347292409; Mon, 27 Jun 2022 09:28:12 -0700 (PDT) Received: from google.com (cpc155339-bagu17-2-0-cust87.1-3.cable.virginm.net. [86.27.177.88]) by smtp.gmail.com with ESMTPSA id m17-20020adfe0d1000000b0021b866397a7sm11132854wri.1.2022.06.27.09.28.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jun 2022 09:28:12 -0700 (PDT) Date: Mon, 27 Jun 2022 17:28:09 +0100 From: Lee Jones To: ChiaEn Wu Cc: Jonathan Cameron , Lars-Peter Clausen , Matthias Brugger , Daniel Thompson , Jingoo Han , Pavel Machek , Rob Herring , Krzysztof Kozlowski , linux-iio , linux-arm Mailing List , "moderated list:ARM/Mediatek SoC support" , Linux Kernel Mailing List , dri-devel , Linux LED Subsystem , devicetree , Linux PM , USB , "open list:FRAMEBUFFER LAYER" , szuni chen , ChiYuan Huang Subject: Re: [PATCH v2 08/15] mfd: mt6370: Add Mediatek MT6370 support Message-ID: References: <20220613111146.25221-1-peterwu.pub@gmail.com> <20220613111146.25221-9-peterwu.pub@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org [...] > > > > > +#define MT6370_IRQ_DSV_VPOS_OCP 124 > > > > > +#define MT6370_IRQ_DSV_BST_OCP 125 > > > > > +#define MT6370_IRQ_DSV_VNEG_SCP 126 > > > > > +#define MT6370_IRQ_DSV_VPOS_SCP 127 > > > > > + > > > > > +struct mt6370_info { > > > > > + struct i2c_client *i2c[MT6370_MAX_I2C]; > > > > > + struct device *dev; > > > > > + struct regmap *regmap; > > > > > + struct regmap_irq_chip_data *irq_data; > > > > > +}; > > > > > > > > Can we shove all of the above into a header file? > > > > > > Well... In Patch v1, we put these "#define IRQ" into > > > "include/dt-bindings/mfd/mediatek,mt6370.h". > > > But the reviewer of DT files hoped us to remove this header file, we > > > put these "#define IRQ" in this .c file. > > > Shall we leave them here or put them into the header file in > > > "driver/power/supply/mt6370-charger.h"? > > > > Where are they used? > > Sorry, I wrote the wrong path last time... > What I should say last time was to put them into the header file into > "driver/mfd/mt6370.h" > These "#define IRQ" are just used in "driver/mfd/mt6370.c" > I’m really sorry for making this mistake... Yes, that would be fine. -- Lee Jones [李琼斯] Principal Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A131FC433EF for ; Mon, 27 Jun 2022 16:29:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hWZH1ndX/O48t/s/KSYxddWQtzZ2X37JS89IVocAvHw=; b=o3EGO+mb9GTp94 4nr5sSumoIe61XABMYUMJmmismiCFYcO5Gym+KNolIqkPhFBHRx6u84+TX1u+v/r3H2vUiuvbANeQ SLwUtGKY1NQyFk92l0nrJSEUqjC3jJqnQNMQt9tE323blsdrGA5Ba5+fnPYKpkCmbLlihuIClkWcf 65QJTarBeQMUFifXdxWyNlE9cpxKFdHBj3jGXH2D9hNVHQA+nOL9pSoSRqOoBWeiZ1EAlUc6UZEtQ UbNThChrZXgjJJLDyUi3yOouF0BOot7Psfjg5wXe0zoywCURzYiuG9A5k8kZe9D2a8/x67MBBZ5IY xH1PILdmg33LGAAegbZg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o5rb2-001pQU-JL; Mon, 27 Jun 2022 16:28:21 +0000 Received: from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o5rax-001pNp-Iv for linux-arm-kernel@lists.infradead.org; Mon, 27 Jun 2022 16:28:16 +0000 Received: by mail-wr1-x42e.google.com with SMTP id o4so9877696wrh.3 for ; Mon, 27 Jun 2022 09:28:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=RFbscGfZ1HvqkolFfPgOHxRAqCYKsO6AGhI1CWcF3U0=; b=QL9P5fYJiAGJ0cVberqQxZgecUlCyO035Rs/RHERScTvlSGjFZWJwcJ83NKx7icnCf MmmkqeK7/MKYHkhThvS+4I5n6eilA1iv0cTdd1jM4UXHDDaaVEXvSnXIRzJWnCUCUcUi hfbpR0k3AwYuP7wFzDx1Qb4iWIpTN9nBpMOsMz5YzOvQfMZ+aNGdk1BwqtUaNtHKCBDC fA9t5x0TJ4kWUQmeUPz8VsbAvV+0a4AUoZiJIyO7qENghiYMyKTM8whwQHTooEBVZnfa hv7NO7jkwT4JYF/WPaOvNMBn/r4c0lJo2uE2cyoUPVH1HBvXxtPYqUUryaiaIppTOHk7 Xteg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=RFbscGfZ1HvqkolFfPgOHxRAqCYKsO6AGhI1CWcF3U0=; b=6IbwbctrZ4sKrkofzlpNIfrwuyMnAcASRF0R9YWYEv9JkWwvkDEE5CwZ0RiJTO/OA5 VSrbCGnRnAsaN+8nc2WnjzBsFd5WMzjYoZCY/zrxB1lQQMoX54LPDNoybp/LgMjz5khq NodHneT0CYnR+o5+tuGlf41BpoWhoCMj97VflrGeYu3GUfiB1CeZyKlMLxQJWSPQqZpk u3TNKoT8zTINCQBScNEQ7JjV3JAzuBmwhcNpgVMXHHKomc0mK8rFpEzTJgj65Lm8J3Hx gSVbQc2lYmqzY6cgm2lOJAm18ZbM3YQqTqaDk9Z6PtFMA8gQZmZpnwy0Cb1xbHkmyVI+ 4rbw== X-Gm-Message-State: AJIora+91lqhrfO1LbUiNyhbixHvATSxI33pwLOmZgH16OftKFdBNH2R DcjXCniZCysomie3whsyjvvZ/6LGUx7olw== X-Google-Smtp-Source: AGRyM1tWghCzrhvaQKuNnG4CtD67zaV7MVCuo84J73jDL9LXJFGuDL/uN51RLsUeyYqHqBL/FNulUA== X-Received: by 2002:a5d:5966:0:b0:21b:80b5:ecc3 with SMTP id e38-20020a5d5966000000b0021b80b5ecc3mr12930472wri.130.1656347292409; Mon, 27 Jun 2022 09:28:12 -0700 (PDT) Received: from google.com (cpc155339-bagu17-2-0-cust87.1-3.cable.virginm.net. [86.27.177.88]) by smtp.gmail.com with ESMTPSA id m17-20020adfe0d1000000b0021b866397a7sm11132854wri.1.2022.06.27.09.28.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jun 2022 09:28:12 -0700 (PDT) Date: Mon, 27 Jun 2022 17:28:09 +0100 From: Lee Jones To: ChiaEn Wu Cc: Jonathan Cameron , Lars-Peter Clausen , Matthias Brugger , Daniel Thompson , Jingoo Han , Pavel Machek , Rob Herring , Krzysztof Kozlowski , linux-iio , linux-arm Mailing List , "moderated list:ARM/Mediatek SoC support" , Linux Kernel Mailing List , dri-devel , Linux LED Subsystem , devicetree , Linux PM , USB , "open list:FRAMEBUFFER LAYER" , szuni chen , ChiYuan Huang Subject: Re: [PATCH v2 08/15] mfd: mt6370: Add Mediatek MT6370 support Message-ID: References: <20220613111146.25221-1-peterwu.pub@gmail.com> <20220613111146.25221-9-peterwu.pub@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220627_092815_661871_4B705D63 X-CRM114-Status: GOOD ( 17.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Wy4uLl0KCj4gPiA+ID4gPiArI2RlZmluZSBNVDYzNzBfSVJRX0RTVl9WUE9TX09DUCAgICAgICAg ICAgICAgMTI0Cj4gPiA+ID4gPiArI2RlZmluZSBNVDYzNzBfSVJRX0RTVl9CU1RfT0NQICAgICAg ICAgICAgICAgMTI1Cj4gPiA+ID4gPiArI2RlZmluZSBNVDYzNzBfSVJRX0RTVl9WTkVHX1NDUCAg ICAgICAgICAgICAgMTI2Cj4gPiA+ID4gPiArI2RlZmluZSBNVDYzNzBfSVJRX0RTVl9WUE9TX1ND UCAgICAgICAgICAgICAgMTI3Cj4gPiA+ID4gPiArCj4gPiA+ID4gPiArc3RydWN0IG10NjM3MF9p bmZvIHsKPiA+ID4gPiA+ICsgICAgIHN0cnVjdCBpMmNfY2xpZW50ICppMmNbTVQ2MzcwX01BWF9J MkNdOwo+ID4gPiA+ID4gKyAgICAgc3RydWN0IGRldmljZSAqZGV2Owo+ID4gPiA+ID4gKyAgICAg c3RydWN0IHJlZ21hcCAqcmVnbWFwOwo+ID4gPiA+ID4gKyAgICAgc3RydWN0IHJlZ21hcF9pcnFf Y2hpcF9kYXRhICppcnFfZGF0YTsKPiA+ID4gPiA+ICt9Owo+ID4gPiA+Cj4gPiA+ID4gQ2FuIHdl IHNob3ZlIGFsbCBvZiB0aGUgYWJvdmUgaW50byBhIGhlYWRlciBmaWxlPwo+ID4gPgo+ID4gPiBX ZWxsLi4uIEluIFBhdGNoIHYxLCB3ZSBwdXQgdGhlc2UgIiNkZWZpbmUgSVJRIiBpbnRvCj4gPiA+ ICJpbmNsdWRlL2R0LWJpbmRpbmdzL21mZC9tZWRpYXRlayxtdDYzNzAuaCIuCj4gPiA+IEJ1dCB0 aGUgcmV2aWV3ZXIgb2YgRFQgZmlsZXMgaG9wZWQgdXMgdG8gcmVtb3ZlIHRoaXMgaGVhZGVyIGZp bGUsIHdlCj4gPiA+IHB1dCB0aGVzZSAiI2RlZmluZSBJUlEiIGluIHRoaXMgLmMgZmlsZS4KPiA+ ID4gU2hhbGwgd2UgbGVhdmUgdGhlbSBoZXJlIG9yIHB1dCB0aGVtIGludG8gdGhlIGhlYWRlciBm aWxlIGluCj4gPiA+ICJkcml2ZXIvcG93ZXIvc3VwcGx5L210NjM3MC1jaGFyZ2VyLmgiPwo+ID4K PiA+IFdoZXJlIGFyZSB0aGV5IHVzZWQ/Cj4gCj4gU29ycnksIEkgd3JvdGUgdGhlIHdyb25nIHBh dGggbGFzdCB0aW1lLi4uCj4gV2hhdCBJIHNob3VsZCBzYXkgbGFzdCB0aW1lIHdhcyB0byBwdXQg dGhlbSBpbnRvIHRoZSBoZWFkZXIgZmlsZSBpbnRvCj4gImRyaXZlci9tZmQvbXQ2MzcwLmgiCj4g VGhlc2UgIiNkZWZpbmUgSVJRIiBhcmUganVzdCB1c2VkIGluICJkcml2ZXIvbWZkL210NjM3MC5j Igo+IEnigJltIHJlYWxseSBzb3JyeSBmb3IgbWFraW5nIHRoaXMgbWlzdGFrZS4uLgoKWWVzLCB0 aGF0IHdvdWxkIGJlIGZpbmUuCgotLSAKTGVlIEpvbmVzIFvmnY7nkLzmlq9dClByaW5jaXBhbCBU ZWNobmljYWwgTGVhZCAtIERldmVsb3BlciBTZXJ2aWNlcwpMaW5hcm8ub3JnIOKUgiBPcGVuIHNv dXJjZSBzb2Z0d2FyZSBmb3IgQXJtIFNvQ3MKRm9sbG93IExpbmFybzogRmFjZWJvb2sgfCBUd2l0 dGVyIHwgQmxvZwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5p bmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8v bGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 135C4C433EF for ; Mon, 27 Jun 2022 16:28:15 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7BE1310E7D7; Mon, 27 Jun 2022 16:28:15 +0000 (UTC) Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by gabe.freedesktop.org (Postfix) with ESMTPS id D84CA10E7D7 for ; Mon, 27 Jun 2022 16:28:13 +0000 (UTC) Received: by mail-wr1-x42f.google.com with SMTP id k22so13831686wrd.6 for ; Mon, 27 Jun 2022 09:28:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=RFbscGfZ1HvqkolFfPgOHxRAqCYKsO6AGhI1CWcF3U0=; b=QL9P5fYJiAGJ0cVberqQxZgecUlCyO035Rs/RHERScTvlSGjFZWJwcJ83NKx7icnCf MmmkqeK7/MKYHkhThvS+4I5n6eilA1iv0cTdd1jM4UXHDDaaVEXvSnXIRzJWnCUCUcUi hfbpR0k3AwYuP7wFzDx1Qb4iWIpTN9nBpMOsMz5YzOvQfMZ+aNGdk1BwqtUaNtHKCBDC fA9t5x0TJ4kWUQmeUPz8VsbAvV+0a4AUoZiJIyO7qENghiYMyKTM8whwQHTooEBVZnfa hv7NO7jkwT4JYF/WPaOvNMBn/r4c0lJo2uE2cyoUPVH1HBvXxtPYqUUryaiaIppTOHk7 Xteg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=RFbscGfZ1HvqkolFfPgOHxRAqCYKsO6AGhI1CWcF3U0=; b=jeJWEip0BxG8zVBA2q3oWbU2lxneobGFmemLNsMpXxe6CxIU3eeMOJVRcUrecwtt8M LZRTvgpegMWJ2pZVEkWW592ynSoTcToMzzrKeSyymkHs9spuLo+OFDRQMIUJild/Pml8 bVPwTSTjtDZNDeFd0tuDawmwUFvt/kqALQ2DgVqbPpmHn4Hzh3E+kDjXNLa1Qla9/KMH CwPTNyXJvnM0v2TI/EJ68J1Fgda6OSl0rhUDiduy2PYaaANMpApudr941nDdzynM8riC TdgZpxgXOsHWkDlxuqtdHNgYfdJOmAPNemeUPP2k6B19co4z+kDGg9wxah1rQ+sb3DGd PPIQ== X-Gm-Message-State: AJIora/ou09o+m8tCxUfpMQGhwNwGF1HwPBNkunoNo2bbemMXLqFR4YN bKZWnhGkG23vpnepPK+A+q8Vrw== X-Google-Smtp-Source: AGRyM1tWghCzrhvaQKuNnG4CtD67zaV7MVCuo84J73jDL9LXJFGuDL/uN51RLsUeyYqHqBL/FNulUA== X-Received: by 2002:a5d:5966:0:b0:21b:80b5:ecc3 with SMTP id e38-20020a5d5966000000b0021b80b5ecc3mr12930472wri.130.1656347292409; Mon, 27 Jun 2022 09:28:12 -0700 (PDT) Received: from google.com (cpc155339-bagu17-2-0-cust87.1-3.cable.virginm.net. [86.27.177.88]) by smtp.gmail.com with ESMTPSA id m17-20020adfe0d1000000b0021b866397a7sm11132854wri.1.2022.06.27.09.28.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jun 2022 09:28:12 -0700 (PDT) Date: Mon, 27 Jun 2022 17:28:09 +0100 From: Lee Jones To: ChiaEn Wu Subject: Re: [PATCH v2 08/15] mfd: mt6370: Add Mediatek MT6370 support Message-ID: References: <20220613111146.25221-1-peterwu.pub@gmail.com> <20220613111146.25221-9-peterwu.pub@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree , Daniel Thompson , Krzysztof Kozlowski , Linux PM , linux-iio , Jingoo Han , USB , Linux Kernel Mailing List , dri-devel , "open list:FRAMEBUFFER LAYER" , ChiYuan Huang , szuni chen , Rob Herring , "moderated list:ARM/Mediatek SoC support" , linux-arm Mailing List , Pavel Machek , Matthias Brugger , Linux LED Subsystem , Jonathan Cameron Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" [...] > > > > > +#define MT6370_IRQ_DSV_VPOS_OCP 124 > > > > > +#define MT6370_IRQ_DSV_BST_OCP 125 > > > > > +#define MT6370_IRQ_DSV_VNEG_SCP 126 > > > > > +#define MT6370_IRQ_DSV_VPOS_SCP 127 > > > > > + > > > > > +struct mt6370_info { > > > > > + struct i2c_client *i2c[MT6370_MAX_I2C]; > > > > > + struct device *dev; > > > > > + struct regmap *regmap; > > > > > + struct regmap_irq_chip_data *irq_data; > > > > > +}; > > > > > > > > Can we shove all of the above into a header file? > > > > > > Well... In Patch v1, we put these "#define IRQ" into > > > "include/dt-bindings/mfd/mediatek,mt6370.h". > > > But the reviewer of DT files hoped us to remove this header file, we > > > put these "#define IRQ" in this .c file. > > > Shall we leave them here or put them into the header file in > > > "driver/power/supply/mt6370-charger.h"? > > > > Where are they used? > > Sorry, I wrote the wrong path last time... > What I should say last time was to put them into the header file into > "driver/mfd/mt6370.h" > These "#define IRQ" are just used in "driver/mfd/mt6370.c" > I’m really sorry for making this mistake... Yes, that would be fine. -- Lee Jones [李琼斯] Principal Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog