From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1238DC433EF for ; Tue, 28 Jun 2022 04:38:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231405AbiF1Eiw (ORCPT ); Tue, 28 Jun 2022 00:38:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34464 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230241AbiF1Eiv (ORCPT ); Tue, 28 Jun 2022 00:38:51 -0400 Received: from muru.com (muru.com [72.249.23.125]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id BE9D73B5; Mon, 27 Jun 2022 21:38:50 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 6517B81BC; Tue, 28 Jun 2022 04:33:38 +0000 (UTC) Date: Tue, 28 Jun 2022 07:38:49 +0300 From: Tony Lindgren To: Liang He Cc: linux@armlinux.org.uk, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm: mach-omap2: omap4-common: Fix refcount leak bug Message-ID: References: <20220617035548.4003393-1-windhl@126.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220617035548.4003393-1-windhl@126.com> Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org * Liang He [220617 06:51]: > In omap4_sram_init(), of_find_compatible_node() will return a node > pointer with refcount incremented. We should use of_node_put() when > it is not used anymore. > > Signed-off-by: Liang He > --- > arch/arm/mach-omap2/omap4-common.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/mach-omap2/omap4-common.c b/arch/arm/mach-omap2/omap4-common.c > index 6d1eb4eefefe..e981bf57e64f 100644 > --- a/arch/arm/mach-omap2/omap4-common.c > +++ b/arch/arm/mach-omap2/omap4-common.c > @@ -135,6 +135,7 @@ static int __init omap4_sram_init(void) > pr_warn("%s:Unable to allocate sram needed to handle errata I688\n", > __func__); > sram_pool = of_gen_pool_get(np, "sram", 0); > + of_node_put(np); > if (!sram_pool) > pr_warn("%s:Unable to get sram pool needed to handle errata I688\n", > __func__); Here too sram_pool is used aftger of_node_put(). Regards, Tony From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CA33DC43334 for ; Tue, 28 Jun 2022 04:39:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0gazkJvgAj26GIcTRKUCNdtY7t+6onDMr+eXnv4C+zo=; b=1++c5p3iY1q/F5 sArjF/c2WcrfIJeiLQKTboZ5pxmwc5ySkVMK6XcRRLmPE/O4DKbT75nMqYKX2zAA8HD2nnT65v04Q lVTOdAUkfywi5vYd0R2rTwG7Z96hkp5pLeo3ONx5kYFKEAmt58B3IHr97/d9bVSMP2SUoqp3d3GQx AxEZzcsJaoKKxvdRBIgxmx7p3YG/cKZ/VKui0fiIElH+RIoOBUCyV5n8zHTT7+HHfO5Wr3RLMrOan Me3XFhZXuNH6eEVFLAR7UQnXFlN1J4tExFmcqMre5uqF/CzOUzigH73WegbygjGaO/nbGDmjhKeNj PB4FMkt5e+Z9Fvm0gZmA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o6301-004Bp1-8x; Tue, 28 Jun 2022 04:38:53 +0000 Received: from muru.com ([72.249.23.125]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o62zy-004BoX-SV for linux-arm-kernel@lists.infradead.org; Tue, 28 Jun 2022 04:38:52 +0000 Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 6517B81BC; Tue, 28 Jun 2022 04:33:38 +0000 (UTC) Date: Tue, 28 Jun 2022 07:38:49 +0300 From: Tony Lindgren To: Liang He Cc: linux@armlinux.org.uk, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm: mach-omap2: omap4-common: Fix refcount leak bug Message-ID: References: <20220617035548.4003393-1-windhl@126.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220617035548.4003393-1-windhl@126.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220627_213850_971894_E1CFB446 X-CRM114-Status: GOOD ( 15.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org * Liang He [220617 06:51]: > In omap4_sram_init(), of_find_compatible_node() will return a node > pointer with refcount incremented. We should use of_node_put() when > it is not used anymore. > > Signed-off-by: Liang He > --- > arch/arm/mach-omap2/omap4-common.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/mach-omap2/omap4-common.c b/arch/arm/mach-omap2/omap4-common.c > index 6d1eb4eefefe..e981bf57e64f 100644 > --- a/arch/arm/mach-omap2/omap4-common.c > +++ b/arch/arm/mach-omap2/omap4-common.c > @@ -135,6 +135,7 @@ static int __init omap4_sram_init(void) > pr_warn("%s:Unable to allocate sram needed to handle errata I688\n", > __func__); > sram_pool = of_gen_pool_get(np, "sram", 0); > + of_node_put(np); > if (!sram_pool) > pr_warn("%s:Unable to get sram pool needed to handle errata I688\n", > __func__); Here too sram_pool is used aftger of_node_put(). Regards, Tony _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel