From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E957C433EF for ; Tue, 28 Jun 2022 04:57:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243350AbiF1E5P (ORCPT ); Tue, 28 Jun 2022 00:57:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44552 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232942AbiF1E5P (ORCPT ); Tue, 28 Jun 2022 00:57:15 -0400 Received: from muru.com (muru.com [72.249.23.125]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 2113560D5; Mon, 27 Jun 2022 21:57:14 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id B2D718106; Tue, 28 Jun 2022 04:52:01 +0000 (UTC) Date: Tue, 28 Jun 2022 07:57:12 +0300 From: Tony Lindgren To: Liang He Cc: linux@armlinux.org.uk, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm/mach-omap2: Fix refcount leak bug in omap_hwmod.c Message-ID: References: <20220618014747.4055279-1-windhl@126.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220618014747.4055279-1-windhl@126.com> Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org Hi, * Liang He [220618 04:43]: > In _init(), of_find_node_by_name() will return a node pointer with > refcount incremented. We should use of_node_put() in fail path or > when it is not used anymore. > > NOTE: As the ref will be passed from 'bus' to 'np' by the xx_lookup(), > in normal exit path, we should call of_node_put() at the end use of 'np', > not the end use of 'bus'. Looks correct to me. What about missing of_node_put() for of_get_next_child() also in the _init() function? Regards, Tony From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5C3CCC433EF for ; Tue, 28 Jun 2022 04:58:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7uZaYROHlGEJpO/OG5OZUBAWhNA5AW3uhWxoHx8t/uE=; b=uIjHFnF9u5vPmo UXc5S6NExM9Jw1eA9lae1olRVXIGdz+ZnYxlyXqNW7jgFhsUY4r7gxkSBQtkpekmjQbwXMrD4kZGh urMajxi8Lm6qR+RvGDx0Wd16Dum4erBu9lfqz62TvcVt7++KSIeOKyDRhDRSP1w9Gv2pbx/uKtwtD mhd4tdZUQCvKpEBQDxf4aBuBLv6f01SjGzzF0+ESZXQzbXFDhb/KZO2A9Pc7W//f4ddDy+nGK8adD R2C0fX+/8BcWzdcc5XUlsEZjIOFoRFqwbWKmGeayFqM+iFcndHGeyfqPjvMhjn+YzM3TfGZt/hGEB YN622opDKcLBD0OLa3Wg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o63Hp-004HXD-AZ; Tue, 28 Jun 2022 04:57:17 +0000 Received: from muru.com ([72.249.23.125]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o63Hm-004HWE-Hs for linux-arm-kernel@lists.infradead.org; Tue, 28 Jun 2022 04:57:15 +0000 Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id B2D718106; Tue, 28 Jun 2022 04:52:01 +0000 (UTC) Date: Tue, 28 Jun 2022 07:57:12 +0300 From: Tony Lindgren To: Liang He Cc: linux@armlinux.org.uk, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm/mach-omap2: Fix refcount leak bug in omap_hwmod.c Message-ID: References: <20220618014747.4055279-1-windhl@126.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220618014747.4055279-1-windhl@126.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220627_215714_664089_F8E2B6FB X-CRM114-Status: GOOD ( 11.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, * Liang He [220618 04:43]: > In _init(), of_find_node_by_name() will return a node pointer with > refcount incremented. We should use of_node_put() in fail path or > when it is not used anymore. > > NOTE: As the ref will be passed from 'bus' to 'np' by the xx_lookup(), > in normal exit path, we should call of_node_put() at the end use of 'np', > not the end use of 'bus'. Looks correct to me. What about missing of_node_put() for of_get_next_child() also in the _init() function? Regards, Tony _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel