From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Yangxi Xiang <xyangxi5@gmail.com>
Cc: Jiri Slaby <jirislaby@kernel.org>,
linux-kernel@vger.kernel.org, Johan Hovold <johan@kernel.org>,
Igor Matheus Andrade Torrente <igormtorrente@gmail.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
nick black <dankamongmen@gmail.com>
Subject: Re: [PATCH] vt: fix memory overlapping when deleting chars in the buffer
Date: Tue, 28 Jun 2022 11:11:05 +0200 [thread overview]
Message-ID: <YrrFqfFdwDM0vrrw@kroah.com> (raw)
In-Reply-To: <20220628085922.22460-1-xyangxi5@gmail.com>
On Tue, Jun 28, 2022 at 04:59:22PM +0800, Yangxi Xiang wrote:
> >> Both of them works, and I pick one of them.
> >
> > Sorry, I don't understand.
>
> We can use both scr_memcpyw() and scr_memmovew() for the not
> overlapping case (cp <= nr), which is more likely to happen.
> In this case I keep using scr_memcpyw().
The point is we should just do one type of copy, let's pick the one that
always works and do that, no need to check anything here.
thanks,
greg k-h
next prev parent reply other threads:[~2022-06-28 9:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-27 12:54 [PATCH v2] vt: fix memory overlapping when deleting chars in the buffer Yangxi Xiang
2022-06-27 13:07 ` Greg Kroah-Hartman
2022-06-28 8:08 ` Jiri Slaby
2022-06-28 8:27 ` [PATCH] " Yangxi Xiang
2022-06-28 8:38 ` Jiri Slaby
2022-06-28 8:59 ` Yangxi Xiang
2022-06-28 9:11 ` Greg Kroah-Hartman [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-06-27 10:29 Yangxi Xiang
2022-06-27 10:47 ` Greg Kroah-Hartman
2022-06-27 11:04 ` Yangxi Xiang
2022-06-27 11:07 ` Greg Kroah-Hartman
2022-06-27 11:40 ` Yangxi Xiang
2022-06-27 12:29 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YrrFqfFdwDM0vrrw@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=borntraeger@linux.ibm.com \
--cc=dankamongmen@gmail.com \
--cc=igormtorrente@gmail.com \
--cc=jirislaby@kernel.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xyangxi5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.