From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Gwendal Grignou <gwendal@chromium.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>
Subject: Re: [PATCH v2 1/2] iio: proximity: sx_common: Don't use IIO device for properties
Date: Wed, 29 Jun 2022 01:00:53 +0300 [thread overview]
Message-ID: <Yrt6FVHilUuoPrnL@smile.fi.intel.com> (raw)
In-Reply-To: <20220615114746.2767-1-andriy.shevchenko@linux.intel.com>
On Wed, Jun 15, 2022 at 02:47:45PM +0300, Andy Shevchenko wrote:
> It's not correct to use artificial device created by IIO core to
> retrieve device properties. Even ->get_default_reg() callback
> takes a simple struct device pointer which suggests it wants to
> operate on the real device.
>
> Correct this by replacing pointer to IIO device by a real device
> pointer in the caller of ->get_default_reg().
Gwendal, any comments on this version?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-06-28 22:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-15 11:47 [PATCH v2 1/2] iio: proximity: sx_common: Don't use IIO device for properties Andy Shevchenko
2022-06-15 11:47 ` [PATCH v2 2/2] iio: proximity: sx_common: Allow IIO core to take care of firmware node Andy Shevchenko
2022-06-29 17:07 ` Gwendal Grignou
2022-07-03 15:45 ` Andy Shevchenko
2022-07-16 15:42 ` Jonathan Cameron
2022-06-28 22:00 ` Andy Shevchenko [this message]
2022-06-28 23:34 ` [PATCH v2 1/2] iio: proximity: sx_common: Don't use IIO device for properties Gwendal Grignou
2022-06-29 9:21 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yrt6FVHilUuoPrnL@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=gwendal@chromium.org \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.