From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DEDFC43334 for ; Tue, 28 Jun 2022 23:43:42 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id E4D6D4B4DD; Tue, 28 Jun 2022 19:43:41 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@linux.dev Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cle2ZaxxiNG4; Tue, 28 Jun 2022 19:43:39 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id A2C6A4B45A; Tue, 28 Jun 2022 19:43:39 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 402A84B325 for ; Tue, 28 Jun 2022 19:43:38 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8v3EjcWwssjj for ; Tue, 28 Jun 2022 19:43:36 -0400 (EDT) Received: from out2.migadu.com (out2.migadu.com [188.165.223.204]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 8ECAC4B4D1 for ; Tue, 28 Jun 2022 19:43:36 -0400 (EDT) Date: Tue, 28 Jun 2022 16:43:29 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1656459815; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iD9bxhnD+YSICtIu8LvsIbymkt3lQEvJM0mEtuYjhPE=; b=TK4gj2Rv519E4qzCOGaITxugQWfp+8adRlhp2JUURpxNugn+mwNHPjt8j233/0tNVbux64 2Jp48OgWF/tFoxFJ0trFrFmxOzVrFUL8fVD8DmswWdFNvKJ/NmcvVgok1TI1fR+Ho4ROMG ermU4KO3Ec3i4mFyW0LNWE58JQb9eOE= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Oliver Upton To: Ricardo Koller Subject: Re: [PATCH v4 09/13] KVM: selftests: aarch64: Add aarch64/page_fault_test Message-ID: References: <20220624213257.1504783-1-ricarkol@google.com> <20220624213257.1504783-10-ricarkol@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220624213257.1504783-10-ricarkol@google.com> X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev Cc: drjones@redhat.com, kvm@vger.kernel.org, maz@kernel.org, axelrasmussen@google.com, bgardon@google.com, dmatlack@google.com, pbonzini@redhat.com, kvmarm@lists.cs.columbia.edu X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu SGkgUmljYXJkbywKCk9uIEZyaSwgSnVuIDI0LCAyMDIyIGF0IDAyOjMyOjUzUE0gLTA3MDAsIFJp Y2FyZG8gS29sbGVyIHdyb3RlOgo+IEFkZCBhIG5ldyB0ZXN0IGZvciBzdGFnZSAyIGZhdWx0cyB3 aGVuIHVzaW5nIGRpZmZlcmVudCBjb21iaW5hdGlvbnMgb2YKPiBndWVzdCBhY2Nlc3NlcyAoZS5n Liwgd3JpdGUsIFMxUFRXKSwgYmFja2luZyBzb3VyY2UgdHlwZSAoZS5nLiwgYW5vbikKPiBhbmQg dHlwZXMgb2YgZmF1bHRzIChlLmcuLCByZWFkIG9uIGh1Z2V0bGJmcyB3aXRoIGEgaG9sZSkuIFRo ZSBuZXh0Cj4gY29tbWl0cyB3aWxsIGFkZCBkaWZmZXJlbnQgaGFuZGxpbmcgbWV0aG9kcyBhbmQg bW9yZSBmYXVsdHMgKGUuZy4sIHVmZmQKPiBhbmQgZGlydHkgbG9nZ2luZykuIFRoaXMgZmlyc3Qg Y29tbWl0IHN0YXJ0cyBieSBhZGRpbmcgdHdvIHNhbml0eSBjaGVja3MKPiBmb3IgYWxsIHR5cGVz IG9mIGFjY2Vzc2VzOiBBRiBzZXR0aW5nIGJ5IHRoZSBodywgYW5kIGFjY2Vzc2luZyBtZW1zbG90 cwo+IHdpdGggaG9sZXMuCj4gCj4gU2lnbmVkLW9mZi1ieTogUmljYXJkbyBLb2xsZXIgPHJpY2Fy a29sQGdvb2dsZS5jb20+Cj4gLS0tCj4gIHRvb2xzL3Rlc3Rpbmcvc2VsZnRlc3RzL2t2bS9NYWtl ZmlsZSAgICAgICAgICB8ICAgMSArCj4gIC4uLi9zZWxmdGVzdHMva3ZtL2FhcmNoNjQvcGFnZV9m YXVsdF90ZXN0LmMgICB8IDY5NSArKysrKysrKysrKysrKysrKysKPiAgLi4uL3NlbGZ0ZXN0cy9r dm0vaW5jbHVkZS9hYXJjaDY0L3Byb2Nlc3Nvci5oIHwgICA2ICsKPiAgMyBmaWxlcyBjaGFuZ2Vk LCA3MDIgaW5zZXJ0aW9ucygrKQo+ICBjcmVhdGUgbW9kZSAxMDA2NDQgdG9vbHMvdGVzdGluZy9z ZWxmdGVzdHMva3ZtL2FhcmNoNjQvcGFnZV9mYXVsdF90ZXN0LmMKPiAKPiBkaWZmIC0tZ2l0IGEv dG9vbHMvdGVzdGluZy9zZWxmdGVzdHMva3ZtL01ha2VmaWxlIGIvdG9vbHMvdGVzdGluZy9zZWxm dGVzdHMva3ZtL01ha2VmaWxlCj4gaW5kZXggZTQ0OTdhM2EyN2Q0Li4xM2I5MTMyMjVhZTcgMTAw NjQ0Cj4gLS0tIGEvdG9vbHMvdGVzdGluZy9zZWxmdGVzdHMva3ZtL01ha2VmaWxlCj4gKysrIGIv dG9vbHMvdGVzdGluZy9zZWxmdGVzdHMva3ZtL01ha2VmaWxlCj4gQEAgLTEzOSw2ICsxMzksNyBA QCBURVNUX0dFTl9QUk9HU19hYXJjaDY0ICs9IGFhcmNoNjQvYXJjaF90aW1lcgo+ICBURVNUX0dF Tl9QUk9HU19hYXJjaDY0ICs9IGFhcmNoNjQvZGVidWctZXhjZXB0aW9ucwo+ICBURVNUX0dFTl9Q Uk9HU19hYXJjaDY0ICs9IGFhcmNoNjQvZ2V0LXJlZy1saXN0Cj4gIFRFU1RfR0VOX1BST0dTX2Fh cmNoNjQgKz0gYWFyY2g2NC9oeXBlcmNhbGxzCj4gK1RFU1RfR0VOX1BST0dTX2FhcmNoNjQgKz0g YWFyY2g2NC9wYWdlX2ZhdWx0X3Rlc3QKPiAgVEVTVF9HRU5fUFJPR1NfYWFyY2g2NCArPSBhYXJj aDY0L3BzY2lfdGVzdAo+ICBURVNUX0dFTl9QUk9HU19hYXJjaDY0ICs9IGFhcmNoNjQvdmNwdV93 aWR0aF9jb25maWcKPiAgVEVTVF9HRU5fUFJPR1NfYWFyY2g2NCArPSBhYXJjaDY0L3ZnaWNfaW5p dAo+IGRpZmYgLS1naXQgYS90b29scy90ZXN0aW5nL3NlbGZ0ZXN0cy9rdm0vYWFyY2g2NC9wYWdl X2ZhdWx0X3Rlc3QuYyBiL3Rvb2xzL3Rlc3Rpbmcvc2VsZnRlc3RzL2t2bS9hYXJjaDY0L3BhZ2Vf ZmF1bHRfdGVzdC5jCj4gbmV3IGZpbGUgbW9kZSAxMDA2NDQKPiBpbmRleCAwMDAwMDAwMDAwMDAu LmJkZGE0ZTNmY2RhYQo+IC0tLSAvZGV2L251bGwKPiArKysgYi90b29scy90ZXN0aW5nL3NlbGZ0 ZXN0cy9rdm0vYWFyY2g2NC9wYWdlX2ZhdWx0X3Rlc3QuYwoKWy4uLl0KCj4gKy8qIENvbXBhcmUg YW5kIHN3YXAgaW5zdHJ1Y3Rpb24uICovCj4gK3N0YXRpYyB2b2lkIGd1ZXN0X2Nhcyh2b2lkKQo+ ICt7Cj4gKwl1aW50NjRfdCB2YWw7Cj4gKwo+ICsJR1VFU1RfQVNTRVJUX0VRKGd1ZXN0X2NoZWNr X2xzZSgpLCAxKTsKCldoeSBub3QganVzdCBHVUVTVF9BU1NFUlQoZ3Vlc3RfY2hlY2tfbHNlKCkp ID8KCj4gKwlhc20gdm9sYXRpbGUoIi5hcmNoX2V4dGVuc2lvbiBsc2VcbiIKPiArCQkgICAgICJj YXNhbCAlMCwgJTEsIFslMl1cbiIKPiArCQkJOjogInIiICgwKSwgInIiIChURVNUX0RBVEEpLCAi ciIgKGd1ZXN0X3Rlc3RfbWVtb3J5KSk7Cj4gKwl2YWwgPSBSRUFEX09OQ0UoKmd1ZXN0X3Rlc3Rf bWVtb3J5KTsKPiArCUdVRVNUX0FTU0VSVF9FUSh2YWwsIFRFU1RfREFUQSk7Cj4gK30KPiArCj4g K3N0YXRpYyB2b2lkIGd1ZXN0X3JlYWQ2NCh2b2lkKQo+ICt7Cj4gKwl1aW50NjRfdCB2YWw7Cj4g Kwo+ICsJdmFsID0gUkVBRF9PTkNFKCpndWVzdF90ZXN0X21lbW9yeSk7Cj4gKwlHVUVTVF9BU1NF UlRfRVEodmFsLCAwKTsKPiArfQo+ICsKPiArLyogQWRkcmVzcyB0cmFuc2xhdGlvbiBpbnN0cnVj dGlvbiAqLwo+ICtzdGF0aWMgdm9pZCBndWVzdF9hdCh2b2lkKQo+ICt7Cj4gKwl1aW50NjRfdCBw YXI7Cj4gKwl1aW50NjRfdCBwYWRkcjsKPiArCj4gKwlhc20gdm9sYXRpbGUoImF0IHMxZTFyLCAl MCIgOjogInIiIChndWVzdF90ZXN0X21lbW9yeSkpOwo+ICsJcGFyID0gcmVhZF9zeXNyZWcocGFy X2VsMSk7CgpJIGJlbGlldmUgeW91IG5lZWQgZXhwbGljaXQgc3luY2hyb25pemF0aW9uIChhbiBp c2IpIGJlZm9yZSB0aGUgZmF1bHQKaW5mb3JtYXRpb24gaXMgZ3VhcmFudGVlZCB2aXNpYmlsZSBp biBQQVJfRUwxLgoKPiArCS8qIEJpdCAxIGluZGljYXRlcyB3aGV0aGVyIHRoZSBBVCB3YXMgc3Vj Y2Vzc2Z1bCAqLwo+ICsJR1VFU1RfQVNTRVJUX0VRKHBhciAmIDEsIDApOwo+ICsJLyogVGhlIFBB IGluIGJpdHMgWzUxOjEyXSAqLwo+ICsJcGFkZHIgPSBwYXIgJiAoKCgxVUxMIDw8IDQwKSAtIDEp IDw8IDEyKTsKPiArCUdVRVNUX0FTU0VSVF9FUShwYWRkciwgbWVtc2xvdFtURVNUXS5ncGEpOwo+ ICt9Cj4gKwo+ICsvKgo+ICsgKiBUaGUgc2l6ZSBvZiB0aGUgYmxvY2sgd3JpdHRlbiBieSAiZGMg enZhIiBpcyBndWFyYW50ZWVkIHRvIGJlIGJldHdlZW4gKDIgPDwKPiArICogMCkgYW5kICgyIDw8 IDkpLCB3aGljaCBpcyBzYWZlIGluIG91ciBjYXNlIGFzIHdlIG5lZWQgdGhlIHdyaXRlIHRvIGhh cHBlbgo+ICsgKiBmb3IgYXQgbGVhc3QgYSB3b3JkLCBhbmQgbm90IG1vcmUgdGhhbiBhIHBhZ2Uu Cj4gKyAqLwo+ICtzdGF0aWMgdm9pZCBndWVzdF9kY196dmEodm9pZCkKPiArewo+ICsJdWludDE2 X3QgdmFsOwo+ICsKPiArCWFzbSB2b2xhdGlsZSgiZGMgenZhLCAlMFxuIgo+ICsJCQkiZHNiIGlz aFxuIgoKbml0OiB1c2UgdGhlIGRzYigpIG1hY3JvIGluc3RlYWQuIEV4dHJlbWVseSBtaW5vciwg YnV0IG1ha2VzIGl0IGEgYml0Cm1vcmUgb2J2aW91cyB0byB0aGUgcmVhZGVyLiBPciBtYXliZSBJ IG5lZWQgdG8gZ2V0IG15IGV5ZXMgY2hlY2tlZCA7LSkKCj4gKwkJCTo6ICJyIiAoZ3Vlc3RfdGVz dF9tZW1vcnkpKTsKPiArCXZhbCA9IFJFQURfT05DRSgqZ3Vlc3RfdGVzdF9tZW1vcnkpOwo+ICsJ R1VFU1RfQVNTRVJUX0VRKHZhbCwgMCk7Cj4gK30KPiArCj4gKy8qCj4gKyAqIFByZS1pbmRleGlu ZyBsb2FkcyBhbmQgc3RvcmVzIGRvbid0IGhhdmUgYSB2YWxpZCBzeW5kcm9tZSAoRVNSX0VMMi5J U1Y9PTApLgo+ICsgKiBBbmQgdGhhdCdzIHNwZWNpYWwgYmVjYXVzZSBLVk0gbXVzdCB0YWtlIHNw ZWNpYWwgY2FyZSB3aXRoIHRob3NlOiB0aGV5Cj4gKyAqIHNob3VsZCBzdGlsbCBjb3VudCBhcyBh Y2Nlc3NlcyBmb3IgZGlydHkgbG9nZ2luZyBvciB1c2VyLWZhdWx0aW5nLCBidXQKPiArICogc2hv dWxkIGJlIGhhbmRsZWQgZGlmZmVyZW50bHkgb24gbW1pby4KPiArICovCj4gK3N0YXRpYyB2b2lk IGd1ZXN0X2xkX3ByZWlkeCh2b2lkKQo+ICt7Cj4gKwl1aW50NjRfdCB2YWw7Cj4gKwl1aW50NjRf dCBhZGRyID0gVEVTVF9HVkEgLSA4Owo+ICsKPiArCS8qCj4gKwkgKiBUaGlzIGVuZHMgdXAgYWNj ZXNzaW5nICJURVNUX0dWQSArIDggLSA4Iiwgd2hlcmUgIlRFU1RfR1ZBIC0gOCIgaXMKPiArCSAq IGluIGEgZ2FwIGJldHdlZW4gbWVtc2xvdHMgbm90IGJhY2tpbmcgYnkgYW55dGhpbmcuCj4gKwkg Ki8KPiArCWFzbSB2b2xhdGlsZSgibGRyICUwLCBbJTEsICM4XSEiCj4gKwkJCTogIj1yIiAodmFs KSwgIityIiAoYWRkcikpOwo+ICsJR1VFU1RfQVNTRVJUX0VRKHZhbCwgMCk7Cj4gKwlHVUVTVF9B U1NFUlRfRVEoYWRkciwgVEVTVF9HVkEpOwo+ICt9Cj4gKwo+ICtzdGF0aWMgdm9pZCBndWVzdF9z dF9wcmVpZHgodm9pZCkKPiArewo+ICsJdWludDY0X3QgdmFsID0gVEVTVF9EQVRBOwo+ICsJdWlu dDY0X3QgYWRkciA9IFRFU1RfR1ZBIC0gODsKPiArCj4gKwlhc20gdm9sYXRpbGUoInN0ciAlMCwg WyUxLCAjOF0hIgo+ICsJCQk6ICIrciIgKHZhbCksICIrciIgKGFkZHIpKTsKPiArCj4gKwlHVUVT VF9BU1NFUlRfRVEoYWRkciwgVEVTVF9HVkEpOwo+ICsJdmFsID0gUkVBRF9PTkNFKCpndWVzdF90 ZXN0X21lbW9yeSk7Cj4gK30KPiArCj4gK3N0YXRpYyBib29sIGd1ZXN0X3NldF9oYSh2b2lkKQo+ ICt7Cj4gKwl1aW50NjRfdCBtbWZyMSA9IHJlYWRfc3lzcmVnKGlkX2FhNjRtbWZyMV9lbDEpOwo+ ICsJdWludDY0X3QgaGFkYnMsIHRjcjsKPiArCj4gKwkvKiBTa2lwIGlmIEhBIGlzIG5vdCBzdXBw b3J0ZWQuICovCj4gKwloYWRicyA9IEZJRUxEX0dFVChBUk02NF9GRUFUVVJFX01BU0soSURfQUE2 NE1NRlIxX0hBREJTKSwgbW1mcjEpOwo+ICsJaWYgKGhhZGJzID09IDApCj4gKwkJcmV0dXJuIGZh bHNlOwo+ICsKPiArCXRjciA9IHJlYWRfc3lzcmVnKHRjcl9lbDEpIHwgVENSX0VMMV9IQTsKPiAr CXdyaXRlX3N5c3JlZyh0Y3IsIHRjcl9lbDEpOwo+ICsJaXNiKCk7Cj4gKwo+ICsJcmV0dXJuIHRy dWU7Cj4gK30KPiArCj4gK3N0YXRpYyBib29sIGd1ZXN0X2NsZWFyX3B0ZV9hZih2b2lkKQo+ICt7 Cj4gKwkqKCh1aW50NjRfdCAqKVRFU1RfUFRFX0dWQSkgJj0gflBURV9BRjsKPiArCWZsdXNoX3Rs Yl9wYWdlKFRFU1RfUFRFX0dWQSk7CgpEb24ndCB5b3Ugd2FudCB0byBhY3R1YWxseSBmbHVzaCBU RVNUX0dWQSB0byBmb3JjZSB0aGUgVExCIGZpbGwgd2hlbiB5b3UKcG9rZSB0aGUgYWRkcmVzcyBh Z2Fpbj8gVGhpcyBsb29rcyBsaWtlIHlvdSdyZSBmbHVzaGluZyB0aGUgVkEgb2YgdGhlCipQVEUq IG5vdCB0aGUgdGVzdCBhZGRyZXNzLgoKPiArCXJldHVybiB0cnVlOwo+ICt9Cj4gKwo+ICtzdGF0 aWMgdm9pZCBndWVzdF9jaGVja19wdGVfYWYodm9pZCkKCm5pdDogY2FsbCB0aGlzIGd1ZXN0X3Rl c3RfcHRlX2FmKCkuIFlvdSB1c2UgdGhlIGd1ZXN0X2NoZWNrXyogcGF0dGVybgpmb3IgdGVzdCBw cmVjb25kaXRpb25zIChsaWtlIGd1ZXN0X2NoZWNrX2xzZSgpKS4KCj4gK3sKPiArCWZsdXNoX3Rs Yl9wYWdlKFRFU1RfUFRFX0dWQSk7CgpXaGF0IGlzIHRoZSBwdXJwb3NlIG9mIHRoaXMgZmx1c2g/ IEkgYmVsaWV2ZSB5b3UgYXJlIGFjdHVhbGx5IGRlcGVuZGluZwpvbiBhIGRzYihpc2gpIGJldHdl ZW4gdGhlIGhhcmR3YXJlIFBURSB1cGRhdGUgYW5kIHRoZSBsb2FkIGJlbG93LiBPciwKdGhhdCdz IGF0IGxlYXN0IHdoYXQgSSBnbGVhbmVkIGZyb20gdGhlIGphcmdvbiBvZiBEREkwNDg3SC5hIEQ1 LjQuMTMgCidPcmRlcmluZyBvZiBoYXJkd2FyZSB1cGRhdGVzIHRvIHRoZSB0cmFuc2xhdGlvbiB0 YWJsZXMnLgoKPiArCUdVRVNUX0FTU0VSVF9FUSgqKCh1aW50NjRfdCAqKVRFU1RfUFRFX0dWQSkg JiBQVEVfQUYsIFBURV9BRik7Cj4gK30KClsuLi5dCgo+ICtzdGF0aWMgdm9pZCBzeW5jX3N0YXRz X2Zyb21fZ3Vlc3Qoc3RydWN0IGt2bV92bSAqdm0pCj4gK3sKPiArCXN0cnVjdCBldmVudF9jbnQg KmVjID0gYWRkcl9ndmEyaHZhKHZtLCAodWludDY0X3QpJmV2ZW50cyk7Cj4gKwo+ICsJZXZlbnRz LmFib3J0cyArPSBlYy0+YWJvcnRzOwo+ICt9CgpJIGJlbGlldmUgeW91IGNhbiB1c2Ugc3luY19n bG9iYWxfZnJvbV9ndWVzdCgpIGluc3RlYWQgb2YgdGhpcy4KCj4gK3ZvaWQgZmFpbF92Y3B1X3J1 bl9ub19oYW5kbGVyKGludCByZXQpCj4gK3sKPiArCVRFU1RfRkFJTCgiVW5leHBlY3RlZCB2Y3B1 IHJ1biBmYWlsdXJlXG4iKTsKPiArfQo+ICsKPiArZXh0ZXJuIHVuc2lnbmVkIGNoYXIgX19leGVj X3Rlc3Q7Cj4gKwo+ICt2b2lkIG5vaW5saW5lIF9fcmV0dXJuXzB4Nzcodm9pZCkKPiArewo+ICsJ YXNtIHZvbGF0aWxlKCJfX2V4ZWNfdGVzdDogbW92IHgwLCAjMHg3N1xuIgo+ICsJCQkicmV0XG4i KTsKPiArfQo+ICsKPiArc3RhdGljIHZvaWQgbG9hZF9leGVjX2NvZGVfZm9yX3Rlc3Qodm9pZCkK PiArewo+ICsJdWludDY0X3QgKmNvZGUsICpjOwo+ICsKPiArCWFzc2VydChURVNUX0VYRUNfR1ZB IC0gVEVTVF9HVkEpOwo+ICsJY29kZSA9IG1lbXNsb3RbVEVTVF0uaHZhICsgODsKPiArCj4gKwkv Kgo+ICsJICogV2UgbmVlZCB0aGUgY2FzdCB0byBiZSBzZXBhcmF0ZSBpbiBvcmRlciBmb3IgdGhl IGNvbXBpbGVyIHRvIG5vdAo+ICsJICogY29tcGxhaW4gd2l0aDogIuKAmG1lbWNweeKAmSBmb3Jt aW5nIG9mZnNldCBbMSwgN10gaXMgb3V0IG9mIHRoZSBib3VuZHMKPiArCSAqIFswLCAxXSBvZiBv YmplY3Qg4oCYX19leGVjX3Rlc3TigJkgd2l0aCB0eXBlIOKAmHVuc2lnbmVkIGNoYXLigJkiCj4g KwkgKi8KPiArCWMgPSAodWludDY0X3QgKikmX19leGVjX3Rlc3Q7Cj4gKwltZW1jcHkoY29kZSwg YywgOCk7CgpEb24ndCB5b3UgbmVlZCB0byBzeW5jIEQkIGFuZCBJJD8KCi0tClRoYW5rcywKT2xp dmVyCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmt2bWFy bSBtYWlsaW5nIGxpc3QKa3ZtYXJtQGxpc3RzLmNzLmNvbHVtYmlhLmVkdQpodHRwczovL2xpc3Rz LmNzLmNvbHVtYmlhLmVkdS9tYWlsbWFuL2xpc3RpbmZvL2t2bWFybQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF0B8C433EF for ; Tue, 28 Jun 2022 23:43:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230118AbiF1Xnk (ORCPT ); Tue, 28 Jun 2022 19:43:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56688 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229450AbiF1Xni (ORCPT ); Tue, 28 Jun 2022 19:43:38 -0400 Received: from out2.migadu.com (out2.migadu.com [IPv6:2001:41d0:2:aacc::]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D3F7F37A08 for ; Tue, 28 Jun 2022 16:43:36 -0700 (PDT) Date: Tue, 28 Jun 2022 16:43:29 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1656459815; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iD9bxhnD+YSICtIu8LvsIbymkt3lQEvJM0mEtuYjhPE=; b=TK4gj2Rv519E4qzCOGaITxugQWfp+8adRlhp2JUURpxNugn+mwNHPjt8j233/0tNVbux64 2Jp48OgWF/tFoxFJ0trFrFmxOzVrFUL8fVD8DmswWdFNvKJ/NmcvVgok1TI1fR+Ho4ROMG ermU4KO3Ec3i4mFyW0LNWE58JQb9eOE= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Oliver Upton To: Ricardo Koller Cc: kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, drjones@redhat.com, maz@kernel.org, bgardon@google.com, dmatlack@google.com, pbonzini@redhat.com, axelrasmussen@google.com Subject: Re: [PATCH v4 09/13] KVM: selftests: aarch64: Add aarch64/page_fault_test Message-ID: References: <20220624213257.1504783-1-ricarkol@google.com> <20220624213257.1504783-10-ricarkol@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220624213257.1504783-10-ricarkol@google.com> X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Hi Ricardo, On Fri, Jun 24, 2022 at 02:32:53PM -0700, Ricardo Koller wrote: > Add a new test for stage 2 faults when using different combinations of > guest accesses (e.g., write, S1PTW), backing source type (e.g., anon) > and types of faults (e.g., read on hugetlbfs with a hole). The next > commits will add different handling methods and more faults (e.g., uffd > and dirty logging). This first commit starts by adding two sanity checks > for all types of accesses: AF setting by the hw, and accessing memslots > with holes. > > Signed-off-by: Ricardo Koller > --- > tools/testing/selftests/kvm/Makefile | 1 + > .../selftests/kvm/aarch64/page_fault_test.c | 695 ++++++++++++++++++ > .../selftests/kvm/include/aarch64/processor.h | 6 + > 3 files changed, 702 insertions(+) > create mode 100644 tools/testing/selftests/kvm/aarch64/page_fault_test.c > > diff --git a/tools/testing/selftests/kvm/Makefile b/tools/testing/selftests/kvm/Makefile > index e4497a3a27d4..13b913225ae7 100644 > --- a/tools/testing/selftests/kvm/Makefile > +++ b/tools/testing/selftests/kvm/Makefile > @@ -139,6 +139,7 @@ TEST_GEN_PROGS_aarch64 += aarch64/arch_timer > TEST_GEN_PROGS_aarch64 += aarch64/debug-exceptions > TEST_GEN_PROGS_aarch64 += aarch64/get-reg-list > TEST_GEN_PROGS_aarch64 += aarch64/hypercalls > +TEST_GEN_PROGS_aarch64 += aarch64/page_fault_test > TEST_GEN_PROGS_aarch64 += aarch64/psci_test > TEST_GEN_PROGS_aarch64 += aarch64/vcpu_width_config > TEST_GEN_PROGS_aarch64 += aarch64/vgic_init > diff --git a/tools/testing/selftests/kvm/aarch64/page_fault_test.c b/tools/testing/selftests/kvm/aarch64/page_fault_test.c > new file mode 100644 > index 000000000000..bdda4e3fcdaa > --- /dev/null > +++ b/tools/testing/selftests/kvm/aarch64/page_fault_test.c [...] > +/* Compare and swap instruction. */ > +static void guest_cas(void) > +{ > + uint64_t val; > + > + GUEST_ASSERT_EQ(guest_check_lse(), 1); Why not just GUEST_ASSERT(guest_check_lse()) ? > + asm volatile(".arch_extension lse\n" > + "casal %0, %1, [%2]\n" > + :: "r" (0), "r" (TEST_DATA), "r" (guest_test_memory)); > + val = READ_ONCE(*guest_test_memory); > + GUEST_ASSERT_EQ(val, TEST_DATA); > +} > + > +static void guest_read64(void) > +{ > + uint64_t val; > + > + val = READ_ONCE(*guest_test_memory); > + GUEST_ASSERT_EQ(val, 0); > +} > + > +/* Address translation instruction */ > +static void guest_at(void) > +{ > + uint64_t par; > + uint64_t paddr; > + > + asm volatile("at s1e1r, %0" :: "r" (guest_test_memory)); > + par = read_sysreg(par_el1); I believe you need explicit synchronization (an isb) before the fault information is guaranteed visibile in PAR_EL1. > + /* Bit 1 indicates whether the AT was successful */ > + GUEST_ASSERT_EQ(par & 1, 0); > + /* The PA in bits [51:12] */ > + paddr = par & (((1ULL << 40) - 1) << 12); > + GUEST_ASSERT_EQ(paddr, memslot[TEST].gpa); > +} > + > +/* > + * The size of the block written by "dc zva" is guaranteed to be between (2 << > + * 0) and (2 << 9), which is safe in our case as we need the write to happen > + * for at least a word, and not more than a page. > + */ > +static void guest_dc_zva(void) > +{ > + uint16_t val; > + > + asm volatile("dc zva, %0\n" > + "dsb ish\n" nit: use the dsb() macro instead. Extremely minor, but makes it a bit more obvious to the reader. Or maybe I need to get my eyes checked ;-) > + :: "r" (guest_test_memory)); > + val = READ_ONCE(*guest_test_memory); > + GUEST_ASSERT_EQ(val, 0); > +} > + > +/* > + * Pre-indexing loads and stores don't have a valid syndrome (ESR_EL2.ISV==0). > + * And that's special because KVM must take special care with those: they > + * should still count as accesses for dirty logging or user-faulting, but > + * should be handled differently on mmio. > + */ > +static void guest_ld_preidx(void) > +{ > + uint64_t val; > + uint64_t addr = TEST_GVA - 8; > + > + /* > + * This ends up accessing "TEST_GVA + 8 - 8", where "TEST_GVA - 8" is > + * in a gap between memslots not backing by anything. > + */ > + asm volatile("ldr %0, [%1, #8]!" > + : "=r" (val), "+r" (addr)); > + GUEST_ASSERT_EQ(val, 0); > + GUEST_ASSERT_EQ(addr, TEST_GVA); > +} > + > +static void guest_st_preidx(void) > +{ > + uint64_t val = TEST_DATA; > + uint64_t addr = TEST_GVA - 8; > + > + asm volatile("str %0, [%1, #8]!" > + : "+r" (val), "+r" (addr)); > + > + GUEST_ASSERT_EQ(addr, TEST_GVA); > + val = READ_ONCE(*guest_test_memory); > +} > + > +static bool guest_set_ha(void) > +{ > + uint64_t mmfr1 = read_sysreg(id_aa64mmfr1_el1); > + uint64_t hadbs, tcr; > + > + /* Skip if HA is not supported. */ > + hadbs = FIELD_GET(ARM64_FEATURE_MASK(ID_AA64MMFR1_HADBS), mmfr1); > + if (hadbs == 0) > + return false; > + > + tcr = read_sysreg(tcr_el1) | TCR_EL1_HA; > + write_sysreg(tcr, tcr_el1); > + isb(); > + > + return true; > +} > + > +static bool guest_clear_pte_af(void) > +{ > + *((uint64_t *)TEST_PTE_GVA) &= ~PTE_AF; > + flush_tlb_page(TEST_PTE_GVA); Don't you want to actually flush TEST_GVA to force the TLB fill when you poke the address again? This looks like you're flushing the VA of the *PTE* not the test address. > + return true; > +} > + > +static void guest_check_pte_af(void) nit: call this guest_test_pte_af(). You use the guest_check_* pattern for test preconditions (like guest_check_lse()). > +{ > + flush_tlb_page(TEST_PTE_GVA); What is the purpose of this flush? I believe you are actually depending on a dsb(ish) between the hardware PTE update and the load below. Or, that's at least what I gleaned from the jargon of DDI0487H.a D5.4.13 'Ordering of hardware updates to the translation tables'. > + GUEST_ASSERT_EQ(*((uint64_t *)TEST_PTE_GVA) & PTE_AF, PTE_AF); > +} [...] > +static void sync_stats_from_guest(struct kvm_vm *vm) > +{ > + struct event_cnt *ec = addr_gva2hva(vm, (uint64_t)&events); > + > + events.aborts += ec->aborts; > +} I believe you can use sync_global_from_guest() instead of this. > +void fail_vcpu_run_no_handler(int ret) > +{ > + TEST_FAIL("Unexpected vcpu run failure\n"); > +} > + > +extern unsigned char __exec_test; > + > +void noinline __return_0x77(void) > +{ > + asm volatile("__exec_test: mov x0, #0x77\n" > + "ret\n"); > +} > + > +static void load_exec_code_for_test(void) > +{ > + uint64_t *code, *c; > + > + assert(TEST_EXEC_GVA - TEST_GVA); > + code = memslot[TEST].hva + 8; > + > + /* > + * We need the cast to be separate in order for the compiler to not > + * complain with: "‘memcpy’ forming offset [1, 7] is out of the bounds > + * [0, 1] of object ‘__exec_test’ with type ‘unsigned char’" > + */ > + c = (uint64_t *)&__exec_test; > + memcpy(code, c, 8); Don't you need to sync D$ and I$? -- Thanks, Oliver