From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Miaoqian Lin <linmq006@gmail.com>
Cc: Lucas Stach <l.stach@pengutronix.de>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: exc3000 - Fix return value check of wait_for_completion_timeout
Date: Tue, 28 Jun 2022 22:47:05 -0700 [thread overview]
Message-ID: <YrvnWd0SkyG/QXyt@google.com> (raw)
In-Reply-To: <20220411105828.22140-1-linmq006@gmail.com>
On Mon, Apr 11, 2022 at 10:58:23AM +0000, Miaoqian Lin wrote:
> wait_for_completion_timeout() returns unsigned long not int.
> It returns 0 if timed out, and positive if completed.
> The check for <= 0 is ambiguous and should be == 0 here
> indicating timeout which is the only error case.
>
> Fixes: 102feb1ddfd0 ("Input: exc3000 - factor out vendor data request")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Applied, thank you.
--
Dmitry
prev parent reply other threads:[~2022-06-29 5:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-11 10:58 [PATCH] Input: exc3000 - Fix return value check of wait_for_completion_timeout Miaoqian Lin
2022-06-29 5:47 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YrvnWd0SkyG/QXyt@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=l.stach@pengutronix.de \
--cc=linmq006@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.