From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: Gregory Erwin <gregerwin256@gmail.com>
Cc: "Herbert Xu" <herbert@gondor.apana.org.au>,
linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org,
"Toke Høiland-Jørgensen" <toke@redhat.com>,
"Kalle Valo" <kvalo@kernel.org>,
"Rui Salvaterra" <rsalvaterra@gmail.com>,
stable@vger.kernel.org
Subject: Re: [PATCH v7] ath9k: let sleep be interrupted when unregistering hwrng
Date: Wed, 29 Jun 2022 13:37:35 +0200 [thread overview]
Message-ID: <Yrw5f8GN2fh2orid@zx2c4.com> (raw)
In-Reply-To: <CAO+Okf56VAqKt5a6OoGUnMAoMsbQoBd7V_tcLf9yuqheWKH1SA@mail.gmail.com>
Hi Gregory,
On Tue, Jun 28, 2022 at 08:41:44PM -0700, Gregory Erwin wrote:
> Hmm, set_notify_signal() calls wake_up_state() in kernel/sched/core.c, which
> is not currently exported. Only by including EXPORT_SYMBOL(wake_up_state) and
> rebuilding vmlinux was I able to build rng-core.ko and load it successfully.
>
> That said, this patch allows 'ip link set wlan0 down' to wake a blocked process
> reading from /dev/hwrng, eliminating the delay as described. I'll give my
> sign-off with the EXPORT_SYMBOL sorted out.
Thanks for testing, and thanks for the note about EXPORT_SYMBOL(). I'll
send a v+1 with that fixed. And then it sounds like this patch finally
addresses all the issues you were seeing. Pfiew!
Jason
next prev parent reply other threads:[~2022-06-29 11:37 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-28 15:18 [PATCH v7] ath9k: let sleep be interrupted when unregistering hwrng Jason A. Donenfeld
2022-06-29 3:41 ` Gregory Erwin
2022-06-29 11:37 ` Jason A. Donenfeld [this message]
2022-06-29 11:42 ` [PATCH v8] " Jason A. Donenfeld
2022-06-29 15:28 ` Greg KH
2022-06-29 16:15 ` Jason A. Donenfeld
2022-06-29 16:49 ` Greg KH
2022-06-30 14:03 ` Jason A. Donenfeld
2022-07-01 1:17 ` Gregory Erwin
2022-07-04 22:04 ` Toke Høiland-Jørgensen
2022-07-07 16:26 ` Kalle Valo
2022-07-11 11:41 ` Valentin Schneider
2022-07-11 11:53 ` Jason A. Donenfeld
2022-07-19 15:15 ` Valentin Schneider
2022-07-19 17:21 ` Jason A. Donenfeld
2022-07-19 17:33 ` [PATCH v9] " Jason A. Donenfeld
2022-07-19 19:25 ` Eric W. Biederman
2022-07-19 20:05 ` Jason A. Donenfeld
2022-07-19 20:11 ` [PATCH v10] " Jason A. Donenfeld
2022-07-19 20:51 ` Eric W. Biederman
2022-07-19 20:55 ` Jason A. Donenfeld
2022-07-22 20:08 ` Valentin Schneider
2022-07-22 20:13 ` Jason A. Donenfeld
2022-07-25 10:08 ` Valentin Schneider
2022-07-25 11:41 ` Jason A. Donenfeld
2022-07-25 17:56 ` Valentin Schneider
2022-06-29 9:24 ` [PATCH v7] " Toke Høiland-Jørgensen
2022-06-29 11:40 ` Jason A. Donenfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yrw5f8GN2fh2orid@zx2c4.com \
--to=jason@zx2c4.com \
--cc=gregerwin256@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=rsalvaterra@gmail.com \
--cc=stable@vger.kernel.org \
--cc=toke@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.