All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zach O'Keefe <zokeefe@google.com>
To: songliubraving@fb.com, willy@infradead.org, shy828301@gmail.com,
	linmiaohe@huawei.com
Cc: linux-mm@kvack.org
Subject: thp: enforcing constraints on file thps
Date: Wed, 29 Jun 2022 07:01:36 -0700	[thread overview]
Message-ID: <YrxbQGiwml24APCx@google.com> (raw)

Hey All,

There are currently a number of paths where we can collapse file memory into
THPs:

1a) khugepaged - target of vma being processed
1b) khugepaged - other vma found mapping file, able to lock mmap_lock in
		 retract_page_tables()
1b) khugepaged - other vma found mapping file, deferred pte-mapped THP collapse,
		 processed in collapse_pte_mapped_thp()
2)  page fault finds hugepage in page cache + filemap_map_pages()

In terms of system-enforced THP constraints:

* vma flags + thps sysfs settings

  Checked in 1a. (1b now at least respects "never" THP mode after Yang Shi's
  cleanup series, but still doesn't respect "madvise" THP mode)

* MMF_DISABLE_THP

  Checked in 1a and 1b

I'm wondering if we should align these, and if so, in what direction? I would
argue that a process marked MMF_DISABLE_THP, or a vma marked VM_NOHUGEPAGE,
probably shouldn't be mapping at the pmd level, and that the appropriate checks
should be added in those paths.

Thanks,
Zach


             reply	other threads:[~2022-06-29 14:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-29 14:01 Zach O'Keefe [this message]
2022-06-29 17:25 ` thp: enforcing constraints on file thps Yang Shi
2022-06-29 20:43   ` Zach O'Keefe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YrxbQGiwml24APCx@google.com \
    --to=zokeefe@google.com \
    --cc=linmiaohe@huawei.com \
    --cc=linux-mm@kvack.org \
    --cc=shy828301@gmail.com \
    --cc=songliubraving@fb.com \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.